Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1403)

Side by Side Diff: talk/session/media/channelmanager.h

Issue 1457653003: Remove SetVideoLogging/SetAudioLogging from ChannelManager and down the stack. (Closed) Base URL: https://chromium.googlesource.com/external/webrtc.git@master
Patch Set: oops Created 5 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « talk/media/webrtc/webrtcvoiceengine_unittest.cc ('k') | talk/session/media/channelmanager.cc » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 /* 1 /*
2 * libjingle 2 * libjingle
3 * Copyright 2004 Google Inc. 3 * Copyright 2004 Google Inc.
4 * 4 *
5 * Redistribution and use in source and binary forms, with or without 5 * Redistribution and use in source and binary forms, with or without
6 * modification, are permitted provided that the following conditions are met: 6 * modification, are permitted provided that the following conditions are met:
7 * 7 *
8 * 1. Redistributions of source code must retain the above copyright notice, 8 * 1. Redistributions of source code must retain the above copyright notice,
9 * this list of conditions and the following disclaimer. 9 * this list of conditions and the following disclaimer.
10 * 2. Redistributions in binary form must reproduce the above copyright notice, 10 * 2. Redistributions in binary form must reproduce the above copyright notice,
(...skipping 119 matching lines...) Expand 10 before | Expand all | Expand 10 after
130 bool GetOutputVolume(int* level); 130 bool GetOutputVolume(int* level);
131 bool SetOutputVolume(int level); 131 bool SetOutputVolume(int level);
132 bool SetDefaultVideoEncoderConfig(const VideoEncoderConfig& config); 132 bool SetDefaultVideoEncoderConfig(const VideoEncoderConfig& config);
133 // RTX will be enabled/disabled in engines that support it. The supporting 133 // RTX will be enabled/disabled in engines that support it. The supporting
134 // engines will start offering an RTX codec. Must be called before Init(). 134 // engines will start offering an RTX codec. Must be called before Init().
135 bool SetVideoRtxEnabled(bool enable); 135 bool SetVideoRtxEnabled(bool enable);
136 136
137 // Starts/stops the local microphone and enables polling of the input level. 137 // Starts/stops the local microphone and enables polling of the input level.
138 bool capturing() const { return capturing_; } 138 bool capturing() const { return capturing_; }
139 139
140 // Configures the logging output of the mediaengine(s).
141 void SetVoiceLogging(int level, const char* filter);
142 void SetVideoLogging(int level, const char* filter);
143
144 // Gets capturer's supported formats in a thread safe manner 140 // Gets capturer's supported formats in a thread safe manner
145 std::vector<cricket::VideoFormat> GetSupportedFormats( 141 std::vector<cricket::VideoFormat> GetSupportedFormats(
146 VideoCapturer* capturer) const; 142 VideoCapturer* capturer) const;
147 // The following are done in the new "CaptureManager" style that 143 // The following are done in the new "CaptureManager" style that
148 // all local video capturers, processors, and managers should move to. 144 // all local video capturers, processors, and managers should move to.
149 // TODO(pthatcher): Make methods nicer by having start return a handle that 145 // TODO(pthatcher): Make methods nicer by having start return a handle that
150 // can be used for stop and restart, rather than needing to pass around 146 // can be used for stop and restart, rather than needing to pass around
151 // formats a a pseudo-handle. 147 // formats a a pseudo-handle.
152 bool StartVideoCapture(VideoCapturer* video_capturer, 148 bool StartVideoCapture(VideoCapturer* video_capturer,
153 const VideoFormat& video_format); 149 const VideoFormat& video_format);
(...skipping 89 matching lines...) Expand 10 before | Expand all | Expand 10 after
243 VideoEncoderConfig default_video_encoder_config_; 239 VideoEncoderConfig default_video_encoder_config_;
244 VideoRenderer* local_renderer_; 240 VideoRenderer* local_renderer_;
245 bool enable_rtx_; 241 bool enable_rtx_;
246 242
247 bool capturing_; 243 bool capturing_;
248 }; 244 };
249 245
250 } // namespace cricket 246 } // namespace cricket
251 247
252 #endif // TALK_SESSION_MEDIA_CHANNELMANAGER_H_ 248 #endif // TALK_SESSION_MEDIA_CHANNELMANAGER_H_
OLDNEW
« no previous file with comments | « talk/media/webrtc/webrtcvoiceengine_unittest.cc ('k') | talk/session/media/channelmanager.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698