[rtp_rtcp] rtcp::Dlrr block moved into own file and got Parse function

rtcp::Dlrr block moved into own file and got Parse function

BUG=webrtc:5260
Committed: https://crrev.com/54999d411b97e3df54121e5f7bfb28846f3c8086
Cr-Commit-Position: refs/heads/master@{#11044}

[danilchap, 2015-11-18 14:50:24]

danilchap@webrtc.org changed reviewers:
+ asapersson@webrtc.org, sprang@webrtc.org

[danilchap, 2015-12-15 09:35:34]

Description was changed from

==========
rtcp::Dlrr block moved into own file and got Parse function
==========

to

==========
rtcp::Dlrr block moved into own file and got Parse function

BUG=webrtc:5260
==========

[danilchap, 2015-12-15 09:35:34]

danilchap@webrtc.org changed reviewers:
- sprang@webrtc.org

[åsapersson, 2015-12-15 12:20:55]

https://codereview.webrtc.org/1453973005/diff/40001/webrtc/modules/rtp_rtcp/s...
File webrtc/modules/rtp_rtcp/source/rtcp_packet/dlrr.h (right):

https://codereview.webrtc.org/1453973005/diff/40001/webrtc/modules/rtp_rtcp/s...
webrtc/modules/rtp_rtcp/source/rtcp_packet/dlrr.h:15: #include <algorithm>
needed?

https://codereview.webrtc.org/1453973005/diff/40001/webrtc/modules/rtp_rtcp/s...
File webrtc/modules/rtp_rtcp/source/rtcp_packet/dlrr_unittest.cc (right):

https://codereview.webrtc.org/1453973005/diff/40001/webrtc/modules/rtp_rtcp/s...
webrtc/modules/rtp_rtcp/source/rtcp_packet/dlrr_unittest.cc:15: #include
"webrtc/modules/rtp_rtcp/source/byte_io.h"
nit: new line

https://codereview.webrtc.org/1453973005/diff/40001/webrtc/modules/rtp_rtcp/s...
webrtc/modules/rtp_rtcp/source/rtcp_packet/dlrr_unittest.cc:26: const size_t
kBlockLength = sizeof(kBlock);
kBlockSizeBytes (as in other tests)

https://codereview.webrtc.org/1453973005/diff/40001/webrtc/modules/rtp_rtcp/s...
webrtc/modules/rtp_rtcp/source/rtcp_packet/dlrr_unittest.cc:60: buffer[0] = 5; 
// BlockType.
Dlrr::kBlockType

https://codereview.webrtc.org/1453973005/diff/40001/webrtc/modules/rtp_rtcp/s...
webrtc/modules/rtp_rtcp/source/rtcp_packet/dlrr_unittest.cc:66: // Parse should
be succesful only when size is multiple of 3.
s/succesful/successful

https://codereview.webrtc.org/1453973005/diff/40001/webrtc/modules/rtp_rtcp/s...
webrtc/modules/rtp_rtcp/source/rtcp_packet/dlrr_unittest.cc:67: EXPECT_EQ(size %
3 == 0, dlrr.Parse(buffer, (uint16_t)size));
static_cast<uint16_t>

https://codereview.webrtc.org/1453973005/diff/40001/webrtc/modules/rtp_rtcp/s...
webrtc/modules/rtp_rtcp/source/rtcp_packet/dlrr_unittest.cc:73: const size_t
kSubBlockLimit = 100;
Dlrr::kMaxNumberOfDlrrItems

https://codereview.webrtc.org/1453973005/diff/40001/webrtc/modules/rtp_rtcp/s...
webrtc/modules/rtp_rtcp/source/rtcp_packet/dlrr_unittest.cc:80:
TEST(RtcpPacketDlrrTest, CreateAndParseMaxSize) {
maybe CreateAndParseMaxSubBlocks

https://codereview.webrtc.org/1453973005/diff/40001/webrtc/modules/rtp_rtcp/s...
webrtc/modules/rtp_rtcp/source/rtcp_packet/dlrr_unittest.cc:81: const size_t
kSubBlockLimit = 100;
Dlrr::kMaxNumberOfDlrrItems

https://codereview.webrtc.org/1453973005/diff/40001/webrtc/modules/rtp_rtcp/s...
webrtc/modules/rtp_rtcp/source/rtcp_packet/dlrr_unittest.cc:93: }
{} needed? and below

[danilchap, 2015-12-15 13:02:17]

https://codereview.webrtc.org/1453973005/diff/40001/webrtc/modules/rtp_rtcp/s...
File webrtc/modules/rtp_rtcp/source/rtcp_packet/dlrr.h (right):

https://codereview.webrtc.org/1453973005/diff/40001/webrtc/modules/rtp_rtcp/s...
webrtc/modules/rtp_rtcp/source/rtcp_packet/dlrr.h:15: #include <algorithm>
On 2015/12/15 12:20:55, åsapersson wrote:
> needed?

Done. Not any more. (forgot to remove after removing swap)

https://codereview.webrtc.org/1453973005/diff/40001/webrtc/modules/rtp_rtcp/s...
File webrtc/modules/rtp_rtcp/source/rtcp_packet/dlrr_unittest.cc (right):

https://codereview.webrtc.org/1453973005/diff/40001/webrtc/modules/rtp_rtcp/s...
webrtc/modules/rtp_rtcp/source/rtcp_packet/dlrr_unittest.cc:15: #include
"webrtc/modules/rtp_rtcp/source/byte_io.h"
On 2015/12/15 12:20:55, åsapersson wrote:
> nit: new line

Done.

https://codereview.webrtc.org/1453973005/diff/40001/webrtc/modules/rtp_rtcp/s...
webrtc/modules/rtp_rtcp/source/rtcp_packet/dlrr_unittest.cc:26: const size_t
kBlockLength = sizeof(kBlock);
On 2015/12/15 12:20:55, åsapersson wrote:
> kBlockSizeBytes (as in other tests)

Done.

https://codereview.webrtc.org/1453973005/diff/40001/webrtc/modules/rtp_rtcp/s...
webrtc/modules/rtp_rtcp/source/rtcp_packet/dlrr_unittest.cc:60: buffer[0] = 5; 
// BlockType.
On 2015/12/15 12:20:55, åsapersson wrote:
> Dlrr::kBlockType

Done.

https://codereview.webrtc.org/1453973005/diff/40001/webrtc/modules/rtp_rtcp/s...
webrtc/modules/rtp_rtcp/source/rtcp_packet/dlrr_unittest.cc:66: // Parse should
be succesful only when size is multiple of 3.
On 2015/12/15 12:20:55, åsapersson wrote:
> s/succesful/successful

Done.

https://codereview.webrtc.org/1453973005/diff/40001/webrtc/modules/rtp_rtcp/s...
webrtc/modules/rtp_rtcp/source/rtcp_packet/dlrr_unittest.cc:67: EXPECT_EQ(size %
3 == 0, dlrr.Parse(buffer, (uint16_t)size));
On 2015/12/15 12:20:55, åsapersson wrote:
> static_cast<uint16_t>

Done.

https://codereview.webrtc.org/1453973005/diff/40001/webrtc/modules/rtp_rtcp/s...
webrtc/modules/rtp_rtcp/source/rtcp_packet/dlrr_unittest.cc:73: const size_t
kSubBlockLimit = 100;
On 2015/12/15 12:20:55, åsapersson wrote:
> Dlrr::kMaxNumberOfDlrrItems

Done.

https://codereview.webrtc.org/1453973005/diff/40001/webrtc/modules/rtp_rtcp/s...
webrtc/modules/rtp_rtcp/source/rtcp_packet/dlrr_unittest.cc:80:
TEST(RtcpPacketDlrrTest, CreateAndParseMaxSize) {
On 2015/12/15 12:20:55, åsapersson wrote:
> maybe CreateAndParseMaxSubBlocks

Done.

https://codereview.webrtc.org/1453973005/diff/40001/webrtc/modules/rtp_rtcp/s...
webrtc/modules/rtp_rtcp/source/rtcp_packet/dlrr_unittest.cc:81: const size_t
kSubBlockLimit = 100;
On 2015/12/15 12:20:55, åsapersson wrote:
> Dlrr::kMaxNumberOfDlrrItems

Done.

https://codereview.webrtc.org/1453973005/diff/40001/webrtc/modules/rtp_rtcp/s...
webrtc/modules/rtp_rtcp/source/rtcp_packet/dlrr_unittest.cc:93: }
On 2015/12/15 12:20:55, åsapersson wrote:
> {} needed? and below

used to show that Create and Parse parts use only buffer to talk to each other.
Guess it complicates test more than it clarifies it. Removed.

[åsapersson, 2015-12-15 14:03:44]

lgtm (see comment)

https://codereview.webrtc.org/1453973005/diff/60001/webrtc/modules/rtp_rtcp/s...
File webrtc/modules/rtp_rtcp/source/rtcp_packet/dlrr_unittest.cc (right):

https://codereview.webrtc.org/1453973005/diff/60001/webrtc/modules/rtp_rtcp/s...
webrtc/modules/rtp_rtcp/source/rtcp_packet/dlrr_unittest.cc:81: const size_t
kSubBlockLimit = Dlrr::kMaxNumberOfDlrrItems;
remove kSubBlockLimit

[danilchap, 2015-12-15 14:10:12]

https://codereview.webrtc.org/1453973005/diff/60001/webrtc/modules/rtp_rtcp/s...
File webrtc/modules/rtp_rtcp/source/rtcp_packet/dlrr_unittest.cc (right):

https://codereview.webrtc.org/1453973005/diff/60001/webrtc/modules/rtp_rtcp/s...
webrtc/modules/rtp_rtcp/source/rtcp_packet/dlrr_unittest.cc:81: const size_t
kSubBlockLimit = Dlrr::kMaxNumberOfDlrrItems;
On 2015/12/15 14:03:44, åsapersson wrote:
> remove kSubBlockLimit

Removed, though that change forces to turn last EXPECT_EQ(a,b) into
EXPECT_TRUE(a == b)

[danilchap, 2015-12-16 08:59:22]

The CQ bit was checked by danilchap@webrtc.org

[danilchap, 2015-12-16 08:59:22]

The patchset sent to the CQ was uploaded after l-g-t-m from
asapersson@webrtc.org
Link to the patchset: https://codereview.webrtc.org/1453973005/#ps140001 (title:
"made Dlrr block copyable instead of movable")

[commit-bot: I haz the power, 2015-12-16 08:59:30]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1453973005/140001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1453973005/140001

[commit-bot: I haz the power, 2015-12-16 09:56:22]

Description was changed from

==========
rtcp::Dlrr block moved into own file and got Parse function

BUG=webrtc:5260
==========

to

==========
rtcp::Dlrr block moved into own file and got Parse function

BUG=webrtc:5260
==========

[commit-bot: I haz the power, 2015-12-16 09:56:23]

Committed patchset #8 (id:140001)

[commit-bot: I haz the power, 2015-12-16 09:56:26]

Description was changed from

==========
rtcp::Dlrr block moved into own file and got Parse function

BUG=webrtc:5260
==========

to

==========
rtcp::Dlrr block moved into own file and got Parse function

BUG=webrtc:5260

Committed: https://crrev.com/54999d411b97e3df54121e5f7bfb28846f3c8086
Cr-Commit-Position: refs/heads/master@{#11044}
==========

[commit-bot: I haz the power, 2015-12-16 09:56:27]

Patchset 8 (id:??) landed as
https://crrev.com/54999d411b97e3df54121e5f7bfb28846f3c8086
Cr-Commit-Position: refs/heads/master@{#11044}