Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(916)

Side by Side Diff: webrtc/modules/rtp_rtcp/source/rtcp_packet/dlrr_unittest.cc

Issue 1453973005: [rtp_rtcp] rtcp::Dlrr block moved into own file and got Parse function (Closed) Base URL: https://chromium.googlesource.com/external/webrtc.git@master
Patch Set: made Dlrr block copyable instead of movable Created 5 years ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « webrtc/modules/rtp_rtcp/source/rtcp_packet/dlrr.cc ('k') | no next file » | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
(Empty)
1 /*
2 * Copyright (c) 2015 The WebRTC project authors. All Rights Reserved.
3 *
4 * Use of this source code is governed by a BSD-style license
5 * that can be found in the LICENSE file in the root of the source
6 * tree. An additional intellectual property rights grant can be found
7 * in the file PATENTS. All contributing project authors may
8 * be found in the AUTHORS file in the root of the source tree.
9 */
10
11 #include "webrtc/modules/rtp_rtcp/source/rtcp_packet/dlrr.h"
12
13 #include "testing/gtest/include/gtest/gtest.h"
14
15 #include "webrtc/modules/rtp_rtcp/source/byte_io.h"
16
17 using webrtc::rtcp::Dlrr;
18
19 namespace webrtc {
20 namespace {
21
22 const uint32_t kSsrc = 0x12345678;
23 const uint32_t kLastRR = 0x23344556;
24 const uint32_t kDelay = 0x33343536;
25 const uint8_t kBlock[] = {0x05, 0x00, 0x00, 0x03, 0x12, 0x34, 0x56, 0x78,
26 0x23, 0x34, 0x45, 0x56, 0x33, 0x34, 0x35, 0x36};
27 const size_t kBlockSizeBytes = sizeof(kBlock);
28
29 TEST(RtcpPacketDlrrTest, Empty) {
30 Dlrr dlrr;
31
32 EXPECT_EQ(0u, dlrr.BlockLength());
33 }
34
35 TEST(RtcpPacketDlrrTest, Create) {
36 Dlrr dlrr;
37 EXPECT_TRUE(dlrr.WithDlrrItem(kSsrc, kLastRR, kDelay));
38
39 ASSERT_EQ(kBlockSizeBytes, dlrr.BlockLength());
40 uint8_t buffer[kBlockSizeBytes];
41
42 dlrr.Create(buffer);
43 EXPECT_EQ(0, memcmp(buffer, kBlock, kBlockSizeBytes));
44 }
45
46 TEST(RtcpPacketDlrrTest, Parse) {
47 Dlrr dlrr;
48 uint16_t block_length = ByteReader<uint16_t>::ReadBigEndian(&kBlock[2]);
49 EXPECT_TRUE(dlrr.Parse(kBlock, block_length));
50
51 EXPECT_EQ(1u, dlrr.sub_blocks().size());
52 const Dlrr::SubBlock& block = dlrr.sub_blocks().front();
53 EXPECT_EQ(kSsrc, block.ssrc);
54 EXPECT_EQ(kLastRR, block.last_rr);
55 EXPECT_EQ(kDelay, block.delay_since_last_rr);
56 }
57
58 TEST(RtcpPacketDlrrTest, ParseFailsOnBadSize) {
59 const size_t kBigBufferSize = 0x100; // More than enough.
60 uint8_t buffer[kBigBufferSize];
61 buffer[0] = Dlrr::kBlockType;
62 buffer[1] = 0; // Reserved.
63 buffer[2] = 0; // Most significant size byte.
64 for (uint8_t size = 3; size < 6; ++size) {
65 buffer[3] = size;
66 Dlrr dlrr;
67 // Parse should be successful only when size is multiple of 3.
68 EXPECT_EQ(size % 3 == 0, dlrr.Parse(buffer, static_cast<uint16_t>(size)));
69 }
70 }
71
72 TEST(RtcpPacketDlrrTest, FailsOnTooManySubBlocks) {
73 Dlrr dlrr;
74 for (size_t i = 1; i <= Dlrr::kMaxNumberOfDlrrItems; ++i) {
75 EXPECT_TRUE(dlrr.WithDlrrItem(kSsrc + i, kLastRR + i, kDelay + i));
76 }
77 EXPECT_FALSE(dlrr.WithDlrrItem(kSsrc, kLastRR, kDelay));
78 }
79
80 TEST(RtcpPacketDlrrTest, CreateAndParseMaxSubBlocks) {
81 const size_t kBufferSize = 0x1000; // More than enough.
82 uint8_t buffer[kBufferSize];
83
84 // Create.
85 Dlrr dlrr;
86 for (size_t i = 1; i <= Dlrr::kMaxNumberOfDlrrItems; ++i) {
87 EXPECT_TRUE(dlrr.WithDlrrItem(kSsrc + i, kLastRR + i, kDelay + i));
88 }
89 size_t used_buffer_size = dlrr.BlockLength();
90 ASSERT_LE(used_buffer_size, kBufferSize);
91 dlrr.Create(buffer);
92
93 // Parse.
94 Dlrr parsed;
95 uint16_t block_length = ByteReader<uint16_t>::ReadBigEndian(&buffer[2]);
96 EXPECT_EQ(used_buffer_size, (block_length + 1) * 4u);
97 EXPECT_TRUE(parsed.Parse(buffer, block_length));
98 EXPECT_TRUE(parsed.sub_blocks().size() == Dlrr::kMaxNumberOfDlrrItems);
99 }
100
101 } // namespace
102 } // namespace webrtc
OLDNEW
« no previous file with comments | « webrtc/modules/rtp_rtcp/source/rtcp_packet/dlrr.cc ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698