Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(267)

Issue 1453093002: Revert of Create rtc::AtomicInt POD struct. (Closed)

Created:
5 years, 1 month ago by pbos-webrtc
Modified:
5 years, 1 month ago
Reviewers:
tommi, kwiberg-webrtc
CC:
webrtc-reviews_webrtc.org, yujie_mao (webrtc), Andrew MacDonald, henrika_webrtc, stefan-webrtc, tterriberry_mozilla.com, andresp, peah-webrtc, the sun, perkj_webrtc, mflodman
Base URL:
https://chromium.googlesource.com/external/webrtc.git@master
Target Ref:
refs/pending/heads/master
Project:
webrtc
Visibility:
Public.

Description

Revert of Create rtc::AtomicInt POD struct. (patchset #12 id:220001 of https://codereview.webrtc.org/1420043008/ ) Reason for revert: Caused static initializers. BUG=chromium:556866 TBR=tommi@webrtc.org Original issue's description: > Create rtc::AtomicInt POD struct. > > Prevents accidental non-atomic reads, increments and stores since > "volatile int" doesn't enforce atomic usage. > > BUG= > R=kwiberg@webrtc.org, tommi@webrtc.org > > Committed: https://crrev.com/b27f590ece487819c3d1fda400315e582fb975b6 > Cr-Commit-Position: refs/heads/master@{#10657} TBR=kwiberg@webrtc.org,tommi@webrtc.org NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG= Committed: https://crrev.com/3c12f4dadb969afb97468aeb1548777bf860085a Cr-Commit-Position: refs/heads/master@{#10669}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+104 lines, -191 lines) Patch
M webrtc/base/atomicops.h View 2 chunks +0 lines, -41 lines 0 comments Download
M webrtc/base/criticalsection.h View 1 chunk +5 lines, -2 lines 0 comments Download
M webrtc/base/criticalsection.cc View 2 chunks +8 lines, -3 lines 0 comments Download
M webrtc/base/refcount.h View 2 chunks +55 lines, -105 lines 0 comments Download
M webrtc/modules/audio_device/ios/audio_device_ios.h View 3 chunks +4 lines, -9 lines 0 comments Download
M webrtc/modules/audio_device/ios/audio_device_ios.mm View 7 chunks +18 lines, -16 lines 0 comments Download
M webrtc/modules/pacing/packet_router.h View 2 chunks +1 line, -2 lines 0 comments Download
M webrtc/modules/pacing/packet_router.cc View 3 chunks +5 lines, -4 lines 0 comments Download
M webrtc/system_wrappers/include/trace.h View 2 chunks +1 line, -2 lines 0 comments Download
M webrtc/system_wrappers/source/trace_impl.cc View 2 chunks +3 lines, -3 lines 0 comments Download
M webrtc/video/video_capture_input.h View 2 chunks +1 line, -2 lines 0 comments Download
M webrtc/video/video_capture_input.cc View 3 chunks +3 lines, -2 lines 0 comments Download

Messages

Total messages: 4 (0 generated)
pbos-webrtc
Created Revert of Create rtc::AtomicInt POD struct.
5 years, 1 month ago (2015-11-17 11:20:42 UTC) #1
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1453093002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1453093002/1
5 years, 1 month ago (2015-11-17 11:20:52 UTC) #2
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 1 month ago (2015-11-17 11:21:05 UTC) #3
commit-bot: I haz the power
5 years, 1 month ago (2015-11-17 11:21:19 UTC) #4
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/3c12f4dadb969afb97468aeb1548777bf860085a
Cr-Commit-Position: refs/heads/master@{#10669}

Powered by Google App Engine
This is Rietveld 408576698