Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(260)

Issue 1452423003: Add option to capture to texture in AppRTCDemo for Android. (Closed)

Created:
5 years, 1 month ago by perkj_webrtc
Modified:
5 years, 1 month ago
Reviewers:
magjed_webrtc, AlexG
CC:
webrtc-reviews_webrtc.org, tterriberry_mozilla.com
Base URL:
https://chromium.googlesource.com/external/webrtc.git@master
Target Ref:
refs/pending/heads/master
Project:
webrtc
Visibility:
Public.

Description

Add option to capture to texture in AppRTCDemo for Android. The purpose is to be able to easier test and find differences between the path when capturing to textures or byte buffers. This require https://codereview.webrtc.org/1403713002/ to work. BUG=webrtc:4993 R=magjed@webrtc.org TBR=glaznew@webrtc.org Committed: https://crrev.com/d48015364d1a3545ea503ce03ec49762a480d42c Cr-Commit-Position: refs/heads/master@{#10766}

Patch Set 1 #

Patch Set 2 : Rebased #

Patch Set 3 : factory.setVideoHwAccelerationOptions. #

Messages

Total messages: 20 (10 generated)
perkj_webrtc
Please?
5 years, 1 month ago (2015-11-18 10:17:17 UTC) #2
magjed_webrtc
lgtm
5 years, 1 month ago (2015-11-18 13:33:18 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1452423003/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1452423003/20001
5 years, 1 month ago (2015-11-20 06:14:29 UTC) #6
commit-bot: I haz the power
Try jobs failed on following builders: mac_x64_gn_rel on tryserver.webrtc (JOB_FAILED, http://build.chromium.org/p/tryserver.webrtc/builders/mac_x64_gn_rel/builds/5336)
5 years, 1 month ago (2015-11-20 06:18:57 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1452423003/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1452423003/20001
5 years, 1 month ago (2015-11-20 08:51:56 UTC) #10
commit-bot: I haz the power
Try jobs failed on following builders: presubmit on tryserver.webrtc (JOB_FAILED, http://build.chromium.org/p/tryserver.webrtc/builders/presubmit/builds/1860)
5 years, 1 month ago (2015-11-20 08:58:59 UTC) #12
perkj_webrtc
5 years, 1 month ago (2015-11-20 10:29:42 UTC) #14
perkj_webrtc
Alex, would you mind taking a look? The needed encoder patch has been landed in ...
5 years, 1 month ago (2015-11-20 10:31:12 UTC) #17
perkj_webrtc
Committed patchset #3 (id:60001) manually as d48015364d1a3545ea503ce03ec49762a480d42c (presubmit successful).
5 years, 1 month ago (2015-11-24 10:13:43 UTC) #19
commit-bot: I haz the power
5 years, 1 month ago (2015-11-24 10:13:43 UTC) #20
Message was sent while issue was closed.
Patchset 3 (id:??) landed as
https://crrev.com/d48015364d1a3545ea503ce03ec49762a480d42c
Cr-Commit-Position: refs/heads/master@{#10766}

Powered by Google App Engine
This is Rietveld 408576698