Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(2)

Issue 1403713002: MediaCodecVideoEncoder add support to encode from textures (Closed)

Created:
5 years, 2 months ago by perkj_webrtc
Modified:
5 years, 1 month ago
Reviewers:
magjed_webrtc, AlexG
CC:
webrtc-reviews_webrtc.org, yujie_mao (webrtc), Andrew MacDonald, tterriberry_mozilla.com, qiang.lu, niklas.enbom, peah-webrtc
Base URL:
https://chromium.googlesource.com/external/webrtc.git@master
Target Ref:
refs/pending/heads/master
Project:
webrtc
Visibility:
Public.

Description

This cl add support to encode from textures to MediaCodecVideoEncoder. This has also partly been reviewed in https://codereview.webrtc.org/1375953002/. BUG=webrtc:4993 TBR=glaznew@webrtc.org Committed: https://crrev.com/30e918278c8e0221ebbb24727fca90676da77220 Cr-Commit-Position: refs/heads/master@{#10725}

Patch Set 1 #

Patch Set 2 : #

Total comments: 14

Patch Set 3 : Addressed Alex comments. #

Total comments: 1

Patch Set 4 : Fixed tests #

Total comments: 26

Patch Set 5 : Addressed magjeds comments #

Total comments: 3

Patch Set 6 : Worked on test. #

Patch Set 7 : REbased #

Patch Set 8 : Fixed factory. Deprecated setVideoHwAccelerationOptions #

Unified diffs Side-by-side diffs Delta from patch set Stats (+363 lines, -92 lines) Patch
M talk/app/webrtc/androidtests/src/org/webrtc/MediaCodecVideoEncoderTest.java View 1 2 3 4 5 4 chunks +87 lines, -5 lines 0 comments Download
M talk/app/webrtc/java/jni/androidmediaencoder_jni.h View 2 chunks +3 lines, -0 lines 0 comments Download
M talk/app/webrtc/java/jni/androidmediaencoder_jni.cc View 1 2 3 4 5 6 25 chunks +161 lines, -69 lines 0 comments Download
M talk/app/webrtc/java/jni/peerconnection_jni.cc View 1 2 3 4 5 6 7 1 chunk +13 lines, -4 lines 0 comments Download
M talk/app/webrtc/java/src/org/webrtc/MediaCodecVideoEncoder.java View 1 2 3 4 5 6 12 chunks +83 lines, -12 lines 0 comments Download
M talk/app/webrtc/java/src/org/webrtc/PeerConnectionFactory.java View 1 2 3 4 5 6 7 2 chunks +16 lines, -2 lines 0 comments Download

Messages

Total messages: 26 (8 generated)
perkj_webrtc
please?
5 years, 2 months ago (2015-10-12 12:08:01 UTC) #2
perkj_webrtc
Alex, here are the encoder changes I would like to land.
5 years, 2 months ago (2015-10-13 15:57:53 UTC) #4
AlexG
https://codereview.webrtc.org/1403713002/diff/20001/talk/app/webrtc/java/android/org/webrtc/EglBase.java File talk/app/webrtc/java/android/org/webrtc/EglBase.java (right): https://codereview.webrtc.org/1403713002/diff/20001/talk/app/webrtc/java/android/org/webrtc/EglBase.java#newcode215 talk/app/webrtc/java/android/org/webrtc/EglBase.java:215: // See https://android.googlesource.com/platform/frameworks/native/+/tools_r22.2/opengl/specs/EGL_ANDROID_presentation_time.txt nit: alignment? https://codereview.webrtc.org/1403713002/diff/20001/talk/app/webrtc/java/jni/androidmediaencoder_jni.cc File talk/app/webrtc/java/jni/androidmediaencoder_jni.cc (right): ...
5 years, 2 months ago (2015-10-14 23:48:27 UTC) #5
perkj_webrtc
PTAL https://codereview.webrtc.org/1403713002/diff/20001/talk/app/webrtc/java/android/org/webrtc/EglBase.java File talk/app/webrtc/java/android/org/webrtc/EglBase.java (right): https://codereview.webrtc.org/1403713002/diff/20001/talk/app/webrtc/java/android/org/webrtc/EglBase.java#newcode215 talk/app/webrtc/java/android/org/webrtc/EglBase.java:215: // See https://android.googlesource.com/platform/frameworks/native/+/tools_r22.2/opengl/specs/EGL_ANDROID_presentation_time.txt On 2015/10/14 23:48:27, AlexG wrote: ...
5 years, 1 month ago (2015-11-16 13:08:52 UTC) #7
perkj_webrtc
And please take a look at this one if you have time.
5 years, 1 month ago (2015-11-17 12:45:52 UTC) #8
magjed_webrtc
https://codereview.webrtc.org/1403713002/diff/80001/talk/app/webrtc/androidtests/src/org/webrtc/MediaCodecVideoEncoderTest.java File talk/app/webrtc/androidtests/src/org/webrtc/MediaCodecVideoEncoderTest.java (right): https://codereview.webrtc.org/1403713002/diff/80001/talk/app/webrtc/androidtests/src/org/webrtc/MediaCodecVideoEncoderTest.java#newcode36 talk/app/webrtc/androidtests/src/org/webrtc/MediaCodecVideoEncoderTest.java:36: import android.util.Log; The import order is wrong. "Import statements ...
5 years, 1 month ago (2015-11-18 13:12:52 UTC) #9
perkj_webrtc
PTAL https://codereview.webrtc.org/1403713002/diff/80001/talk/app/webrtc/androidtests/src/org/webrtc/MediaCodecVideoEncoderTest.java File talk/app/webrtc/androidtests/src/org/webrtc/MediaCodecVideoEncoderTest.java (right): https://codereview.webrtc.org/1403713002/diff/80001/talk/app/webrtc/androidtests/src/org/webrtc/MediaCodecVideoEncoderTest.java#newcode36 talk/app/webrtc/androidtests/src/org/webrtc/MediaCodecVideoEncoderTest.java:36: import android.util.Log; On 2015/11/18 13:12:52, magjed_webrtc wrote: > ...
5 years, 1 month ago (2015-11-18 14:51:21 UTC) #10
magjed_webrtc
https://codereview.webrtc.org/1403713002/diff/80001/talk/app/webrtc/androidtests/src/org/webrtc/MediaCodecVideoEncoderTest.java File talk/app/webrtc/androidtests/src/org/webrtc/MediaCodecVideoEncoderTest.java (right): https://codereview.webrtc.org/1403713002/diff/80001/talk/app/webrtc/androidtests/src/org/webrtc/MediaCodecVideoEncoderTest.java#newcode45 talk/app/webrtc/androidtests/src/org/webrtc/MediaCodecVideoEncoderTest.java:45: public static void testReInitializeUsingByteBuffer() { On 2015/11/18 14:51:20, perkj1 ...
5 years, 1 month ago (2015-11-18 15:38:12 UTC) #11
magjed_webrtc
https://codereview.webrtc.org/1403713002/diff/100001/talk/app/webrtc/androidtests/src/org/webrtc/MediaCodecVideoEncoderTest.java File talk/app/webrtc/androidtests/src/org/webrtc/MediaCodecVideoEncoderTest.java (right): https://codereview.webrtc.org/1403713002/diff/100001/talk/app/webrtc/androidtests/src/org/webrtc/MediaCodecVideoEncoderTest.java#newcode142 talk/app/webrtc/androidtests/src/org/webrtc/MediaCodecVideoEncoderTest.java:142: assertTrue(encoder.encodeTexture(true, oesTextureId, RendererCommon.identityMatrix(), Another thing, can you call GlUtil.checkNoGLES2Error() ...
5 years, 1 month ago (2015-11-18 15:47:31 UTC) #12
perkj_webrtc
https://codereview.webrtc.org/1403713002/diff/100001/talk/app/webrtc/androidtests/src/org/webrtc/MediaCodecVideoEncoderTest.java File talk/app/webrtc/androidtests/src/org/webrtc/MediaCodecVideoEncoderTest.java (right): https://codereview.webrtc.org/1403713002/diff/100001/talk/app/webrtc/androidtests/src/org/webrtc/MediaCodecVideoEncoderTest.java#newcode142 talk/app/webrtc/androidtests/src/org/webrtc/MediaCodecVideoEncoderTest.java:142: assertTrue(encoder.encodeTexture(true, oesTextureId, RendererCommon.identityMatrix(), On 2015/11/18 15:47:31, magjed_webrtc wrote: > ...
5 years, 1 month ago (2015-11-19 10:40:58 UTC) #13
perkj_webrtc
PTAL
5 years, 1 month ago (2015-11-19 10:53:20 UTC) #15
magjed_webrtc
lgtm
5 years, 1 month ago (2015-11-19 12:41:07 UTC) #16
perkj_webrtc
Thanks - Alex - do you want to take a look?
5 years, 1 month ago (2015-11-19 12:54:32 UTC) #17
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1403713002/180001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1403713002/180001
5 years, 1 month ago (2015-11-20 06:14:18 UTC) #20
commit-bot: I haz the power
Try jobs failed on following builders: android_arm64_rel on tryserver.webrtc (JOB_TIMED_OUT, no build URL)
5 years, 1 month ago (2015-11-20 08:14:34 UTC) #22
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1403713002/180001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1403713002/180001
5 years, 1 month ago (2015-11-20 08:51:37 UTC) #24
commit-bot: I haz the power
Committed patchset #8 (id:180001)
5 years, 1 month ago (2015-11-20 09:31:28 UTC) #25
commit-bot: I haz the power
5 years, 1 month ago (2015-11-20 09:31:43 UTC) #26
Message was sent while issue was closed.
Patchset 8 (id:??) landed as
https://crrev.com/30e918278c8e0221ebbb24727fca90676da77220
Cr-Commit-Position: refs/heads/master@{#10725}

Powered by Google App Engine
This is Rietveld 408576698