Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(33)

Issue 1449863002: Revert of Do not delete the turn port entry right away when the respective connection is deleted. (Closed)

Created:
5 years, 1 month ago by tommi
Modified:
5 years, 1 month ago
Reviewers:
pthatcher1, honghaiz3
CC:
webrtc-reviews_webrtc.org, tterriberry_mozilla.com
Base URL:
https://chromium.googlesource.com/external/webrtc@master
Target Ref:
refs/pending/heads/master
Project:
webrtc
Visibility:
Public.

Description

Revert of Do not delete the turn port entry right away when the respective connection is deleted. (patchset #5 id:260001 of https://codereview.webrtc.org/1426673007/ ) Reason for revert: I have to revert this unfortunately because it adds a dependency on AsyncInvoker, which is not included when building libjingle_nacl in Chromium. AsyncInvoker needs to first be added to the list of sources in Chromium. Original issue's description: > Do not delete the turn port entry right away when the respective connection is deleted. > BUG=webrtc:5120 > > Committed: https://crrev.com/e58fe8ef0e6d959f54adee3ed77764927d3845cc > Cr-Commit-Position: refs/heads/master@{#10641} TBR=pthatcher@webrtc.org,honghaiz@webrtc.org NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=webrtc:5120 Committed: https://crrev.com/54e92326af4ce409e5c9e139cd50329b790061e2 Cr-Commit-Position: refs/heads/master@{#10649}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+16 lines, -123 lines) Patch
M webrtc/p2p/base/turnport.h View 4 chunks +3 lines, -14 lines 0 comments Download
M webrtc/p2p/base/turnport.cc View 6 chunks +13 lines, -53 lines 0 comments Download
M webrtc/p2p/base/turnport_unittest.cc View 2 chunks +0 lines, -56 lines 0 comments Download

Messages

Total messages: 5 (0 generated)
tommi
Created Revert of Do not delete the turn port entry right away when the respective ...
5 years, 1 month ago (2015-11-16 12:12:50 UTC) #1
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1449863002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1449863002/1
5 years, 1 month ago (2015-11-16 12:12:53 UTC) #2
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 1 month ago (2015-11-16 12:13:04 UTC) #3
commit-bot: I haz the power
Patchset 1 (id:??) landed as https://crrev.com/54e92326af4ce409e5c9e139cd50329b790061e2 Cr-Commit-Position: refs/heads/master@{#10649}
5 years, 1 month ago (2015-11-16 12:13:11 UTC) #4
tommi
5 years, 1 month ago (2015-11-16 12:13:40 UTC) #5
Message was sent while issue was closed.
Here's an example build error (from
https://build.chromium.org/p/chromium.webrtc.fyi/builders/Win%20Builder/build...)

FAILED: E:\b\depot_tools\python276_bin\python.exe gyp-win-tool action-wrapper
environment.x86
remoting_client_plugin_nacl_target_build_newlib_pexe_b216360c2163a114a01230d9e0df46a0..rsp
..\..\remoting
../out/Release/gen/tc_pnacl_newlib/lib/libjingle_nacl.a: error: undefined
reference to 'rtc::AsyncInvoker::AsyncInvoker()'

../out/Release/gen/tc_pnacl_newlib/lib/libjingle_nacl.a: error: undefined
reference to 'rtc::AsyncInvoker::~AsyncInvoker()'

../out/Release/gen/tc_pnacl_newlib/lib/libjingle_nacl.a: error: undefined
reference to 'rtc::AsyncInvoker::DoInvokeDelayed(rtc::Thread*,
rtc::scoped_refptr<rtc::AsyncClosure> const&, unsigned int, unsigned int)'

FAILED with 1: ..\native_client\toolchain\win_x86\pnacl_newlib\bin\pnacl-clang++
-o ..\out\Release/remoting_client_plugin_newlib.pexe.debug -Wl,--as-needed
..\out\Release\obj\remoting\remoting_client_plugin_nacl.gen/pnacl_newlib/remoting_client_plugin_nacl\pepper_module_72e86210.o
-B..\out\Release/gen/tc_pnacl_newlib/lib -O3 -lppapi_stub
-lremoting_client_plugin_lib_nacl -lremoting_proto_nacl -ljingle_glue_nacl
-lnet_nacl -lcrypto_nacl -lbase_i18n_nacl -lbase_nacl -lurl_nacl
-lremoting_webrtc_nacl -lyuv_nacl -lvpx_nacl -ljingle_p2p_constants_nacl
-ljingle_nacl -lexpat_nacl -lmodp_b64_nacl -lopus_nacl -lboringssl_nacl
-licui18n_nacl -licuuc_nacl -licudata_nacl -lprotobuf_lite_nacl -lppapi_cpp
-lpthread -lnacl_io

Compile options: ['-O2', '-g', '-Wall', '-fdiagnostics-show-option', '-Werror',
'-Wno-unused-function', '-Wno-char-subscripts', '-Wno-c++11-extensions',
'-Wno-unnamed-type-template-args', '-Wno-extra-semi',
'-Wno-unused-private-field', '-Wno-char-subscripts', '-Wno-unused-function',
'-std=gnu++11', '-D__STDC_LIMIT_MACROS=1', '-D__STDC_FORMAT_MACROS=1',
'-D_GNU_SOURCE=1', '-D_POSIX_C_SOURCE=199506', '-D_XOPEN_SOURCE=600',
'-DDYNAMIC_ANNOTATIONS_ENABLED=1', '-DDYNAMIC_ANNOTATIONS_PREFIX=NACL_',
'-DV8_DEPRECATION_WARNINGS', '-DCLD_VERSION=2', '-DNOMINMAX',
'-DPSAPI_VERSION=1', '-D_CRT_RAND_S', '-DCERT_CHAIN_PARA_HAS_EXTRA_FIELDS',
'-D_ATL_NO_OPENGL', '-D_SECURE_ATL', '-D_HAS_EXCEPTIONS=0',
'-D_WINSOCK_DEPRECATED_NO_WARNINGS', '-DCHROMIUM_BUILD',
'-DCR_CLANG_REVISION=247874-1', '-DUSE_AURA=1', '-DUSE_ASH=1',
'-DUSE_DEFAULT_RENDER_THEME=1', '-DUSE_LIBJPEG_TURBO=1',
'-DENABLE_ONE_CLICK_SIGNIN', '-DENABLE_PRE_SYNC_BACKUP', '-DENABLE_WEBRTC=1',
'-DENABLE_MEDIA_ROUTER=1', '-DENABLE_PEPPER_CDMS',
'-DENABLE_CONFIGURATION_POLICY', '-DENABLE_NOTIFICATIONS', '-DENABLE_HIDPI=1',
'-DENABLE_TOPCHROME_MD=1', '-DDONT_EMBED_BUILD_METADATA',
'-DDCHECK_ALWAYS_ON=1', '-DFIELDTRIAL_TESTING_ENABLED', '-DNO_TCMALLOC',
'-DALLOCATOR_SHIM', '-D__STD_C', '-D_CRT_SECURE_NO_DEPRECATE',
'-D_SCL_SECURE_NO_DEPRECATE', '-DNTDDI_VERSION=0x06030000',
'-D_USING_V110_SDK71_', '-DENABLE_TASK_MANAGER=1', '-DENABLE_EXTENSIONS=1',
'-DENABLE_PDF=1', '-DENABLE_PLUGIN_INSTALLATION=1', '-DENABLE_PLUGINS=1',
'-DENABLE_SESSION_SERVICE=1', '-DENABLE_THEMES=1', '-DENABLE_AUTOFILL_DIALOG=1',
'-DENABLE_BACKGROUND=1', '-DENABLE_GOOGLE_NOW=1', '-DENABLE_PRINTING=1',
'-DENABLE_BASIC_PRINTING=1', '-DENABLE_PRINT_PREVIEW=1',
'-DENABLE_SPELLCHECK=1', '-DENABLE_CAPTIVE_PORTAL_DETECTION=1',
'-DENABLE_APP_LIST=1', '-DENABLE_SETTINGS_APP=1', '-DENABLE_SUPERVISED_USERS=1',
'-DENABLE_MDNS=1', '-DENABLE_SERVICE_DISCOVERY=1',
'-DV8_USE_EXTERNAL_STARTUP_DATA', '-DFULL_SAFE_BROWSING', '-DSAFE_BROWSING_CSD',
'-DSAFE_BROWSING_DB_LOCAL', '-DXML_STATIC', '-DU_USING_ICU_NAMESPACE=0',
'-DU_ENABLE_DYLOAD=0', '-DU_STATIC_IMPLEMENTATION', '-DEXPAT_RELATIVE_PATH',
'-DFEATURE_ENABLE_SSL', '-DGTEST_RELATIVE_PATH', '-DNO_MAIN_THREAD_WRAPPING',
'-DNO_SOUND_SYSTEM', '-DWEBRTC_POSIX', '-DSRTP_RELATIVE_PATH',
'-DSSL_USE_OPENSSL', '-DUSE_WEBRTC_DEV_BRANCH', '-DGOOGLE_PROTOBUF_NO_RTTI',
'-DGOOGLE_PROTOBUF_NO_STATIC_INITIALIZER', '-DUSE_LIBPCI=1', '-DUSE_OPENSSL=1',
'-DUSE_OPENSSL_CERTS=1', '-D__STDC_CONSTANT_MACROS', '-D__STDC_FORMAT_MACROS',
'-DNACL_WINDOWS=0', '-DNACL_OSX=0', '-DNACL_LINUX=0', '-DNACL_ANDROID=0',
'-DNACL_BUILD_ARCH=pnacl', '-I..\\out\\Release/gen/tc_pnacl_newlib/include',
'-I..', '-I..\\out\\Release/gen', '-I../third_party/wtl/include',
'-I../third_party/khronos', '-I../gpu', '-I../native_client_sdk/src/libraries',
'-I../native_client_sdk/src/libraries/nacl_io/include',
'-I../native_client_sdk/src/libraries/third_party/newlib-extras',
'-I../third_party/expat/files/lib', '-I../third_party/icu/source/i18n',
'-I../third_party/icu/source/common', '-I../third_party/libjingle/overrides',
'-I../third_party/libjingle/source', '-I../third_party/webrtc_overrides',
'-I../third_party', '-I../third_party/webrtc',
'-I../third_party/libyuv/include', '-I../third_party/boringssl/src/include',
'-I..\\out\\Release/gen/protoc_out', '-I../third_party/protobuf',
'-I../third_party/protobuf/src', '-DNDEBUG']

Linker options: ['-B..\\out\\Release/gen/tc_pnacl_newlib/lib', '-O3',
'-lppapi_stub', '-lremoting_client_plugin_lib_nacl', '-lremoting_proto_nacl',
'-ljingle_glue_nacl', '-lnet_nacl', '-lcrypto_nacl', '-lbase_i18n_nacl',
'-lbase_nacl', '-lurl_nacl', '-lremoting_webrtc_nacl', '-lyuv_nacl',
'-lvpx_nacl', '-ljingle_p2p_constants_nacl', '-ljingle_nacl', '-lexpat_nacl',
'-lmodp_b64_nacl', '-lopus_nacl', '-lboringssl_nacl', '-licui18n_nacl',
'-licuuc_nacl', '-licudata_nacl', '-lprotobuf_lite_nacl', '-lppapi_cpp',
'-lpthread', '-lnacl_io']

Powered by Google App Engine
This is Rietveld 408576698