Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(278)

Issue 1449083002: Add OpenSL ES enable setting to AppRTCDemo. (Closed)

Created:
5 years, 1 month ago by AlexG
Modified:
5 years, 1 month ago
Reviewers:
henrika_webrtc
CC:
webrtc-reviews_webrtc.org, tterriberry_mozilla.com
Base URL:
https://chromium.googlesource.com/external/webrtc@master
Target Ref:
refs/pending/heads/master
Project:
webrtc
Visibility:
Public.

Description

Add OpenSL ES enable setting to AppRTCDemo. Disable OpenSL ES by default. Plus remove no longer used CPU overuse detection option. Committed: https://crrev.com/e66339296b3d2a3f077bf96a7c221c18d96ae630 Cr-Commit-Position: refs/heads/master@{#10670}

Patch Set 1 #

Patch Set 2 : Fix typo #

Messages

Total messages: 13 (4 generated)
AlexG
PTAL
5 years, 1 month ago (2015-11-16 21:33:25 UTC) #2
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1449083002/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1449083002/20001
5 years, 1 month ago (2015-11-16 21:33:43 UTC) #4
commit-bot: I haz the power
Dry run: This issue passed the CQ dry run.
5 years, 1 month ago (2015-11-16 22:30:08 UTC) #6
henrika_webrtc
Nice. LGTM.
5 years, 1 month ago (2015-11-17 12:04:05 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1449083002/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1449083002/20001
5 years, 1 month ago (2015-11-17 12:04:24 UTC) #9
commit-bot: I haz the power
Committed patchset #2 (id:20001)
5 years, 1 month ago (2015-11-17 12:05:33 UTC) #10
commit-bot: I haz the power
Patchset 2 (id:??) landed as https://crrev.com/e66339296b3d2a3f077bf96a7c221c18d96ae630 Cr-Commit-Position: refs/heads/master@{#10670}
5 years, 1 month ago (2015-11-17 12:05:53 UTC) #11
henrika_webrtc
Landed the changes and did some quick tests. I could be wrong but it feels ...
5 years, 1 month ago (2015-11-17 12:33:28 UTC) #12
henrika_webrtc
5 years, 1 month ago (2015-11-17 13:14:01 UTC) #13
Message was sent while issue was closed.
See https://codereview.webrtc.org/1455563002 for more details.

Powered by Google App Engine
This is Rietveld 408576698