Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(15)

Issue 1455563002: Add OpenSL ES enable setting to AppRTCDemo (part 2) (Closed)

Created:
5 years, 1 month ago by henrika_webrtc
Modified:
5 years, 1 month ago
Reviewers:
AlexG
CC:
webrtc-reviews_webrtc.org
Base URL:
https://chromium.googlesource.com/external/webrtc.git@master
Target Ref:
refs/pending/heads/master
Project:
webrtc
Visibility:
Public.

Description

Add OpenSL ES enable setting to AppRTCDemo (part 2). It is now possible to enable OpenSL ES on devices that supports it. Fix for https://codereview.webrtc.org/1449083002/ Committed: https://crrev.com/5c489c9d3e03e57a1c626928ff828b2118626983 Cr-Commit-Position: refs/heads/master@{#10678}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+5 lines, -2 lines) Patch
M webrtc/examples/androidapp/src/org/appspot/apprtc/PeerConnectionClient.java View 1 chunk +4 lines, -1 line 0 comments Download
M webrtc/modules/audio_device/android/java/src/org/webrtc/voiceengine/WebRtcAudioManager.java View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 13 (6 generated)
henrika_webrtc
I think we have to do something like this to ensure that OpenSL ES can ...
5 years, 1 month ago (2015-11-17 13:18:59 UTC) #3
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1455563002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1455563002/1
5 years, 1 month ago (2015-11-17 13:22:45 UTC) #6
commit-bot: I haz the power
Dry run: This issue passed the CQ dry run.
5 years, 1 month ago (2015-11-17 15:36:09 UTC) #8
AlexG
lgtm
5 years, 1 month ago (2015-11-17 18:11:02 UTC) #9
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1455563002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1455563002/1
5 years, 1 month ago (2015-11-17 18:11:33 UTC) #11
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 1 month ago (2015-11-17 18:12:43 UTC) #12
commit-bot: I haz the power
5 years, 1 month ago (2015-11-17 18:12:56 UTC) #13
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/5c489c9d3e03e57a1c626928ff828b2118626983
Cr-Commit-Position: refs/heads/master@{#10678}

Powered by Google App Engine
This is Rietveld 408576698