Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(24)

Issue 1444313002: Adding thread timeout for audio recorer thread in Java (Closed)

Created:
5 years, 1 month ago by henrika_webrtc
Modified:
5 years, 1 month ago
Reviewers:
magjed_webrtc, tommi
CC:
webrtc-reviews_webrtc.org
Base URL:
https://chromium.googlesource.com/external/webrtc.git@master
Target Ref:
refs/pending/heads/master
Project:
webrtc
Visibility:
Public.

Description

Adding thread timeout for audio recorer thread in Java BUG=NONE Committed: https://crrev.com/fd614c2149c7985bd83df809df71d0d60e5a8f74 Cr-Commit-Position: refs/heads/master@{#10671}

Patch Set 1 #

Patch Set 2 : Moved stuff around #

Unified diffs Side-by-side diffs Delta from patch set Stats (+11 lines, -223 lines) Patch
M talk/app/webrtc/java/android/org/webrtc/ThreadUtils.java View 1 1 chunk +0 lines, -192 lines 0 comments Download
M talk/libjingle.gyp View 1 1 chunk +1 line, -1 line 0 comments Download
A + webrtc/base/java/src/org/webrtc/ThreadUtils.java View 1 2 chunks +7 lines, -24 lines 0 comments Download
M webrtc/modules/audio_device/android/java/src/org/webrtc/voiceengine/WebRtcAudioRecord.java View 2 chunks +3 lines, -6 lines 0 comments Download

Messages

Total messages: 16 (7 generated)
henrika_webrtc
PTAL
5 years, 1 month ago (2015-11-16 14:06:04 UTC) #3
magjed_webrtc
lgtm
5 years, 1 month ago (2015-11-16 15:51:30 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1444313002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1444313002/1
5 years, 1 month ago (2015-11-16 16:06:15 UTC) #6
commit-bot: I haz the power
Try jobs failed on following builders: android_clang_dbg on tryserver.webrtc (JOB_FAILED, http://build.chromium.org/p/tryserver.webrtc/builders/android_clang_dbg/builds/8907)
5 years, 1 month ago (2015-11-16 16:10:55 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1444313002/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1444313002/20001
5 years, 1 month ago (2015-11-17 11:36:44 UTC) #11
commit-bot: I haz the power
Committed patchset #2 (id:20001)
5 years, 1 month ago (2015-11-17 12:28:29 UTC) #12
commit-bot: I haz the power
Patchset 2 (id:??) landed as https://crrev.com/fd614c2149c7985bd83df809df71d0d60e5a8f74 Cr-Commit-Position: refs/heads/master@{#10671}
5 years, 1 month ago (2015-11-17 12:28:44 UTC) #13
tommi
was there a bug?
5 years, 1 month ago (2015-11-17 21:01:06 UTC) #15
henrika_webrtc
5 years, 1 month ago (2015-11-19 10:42:48 UTC) #16
Message was sent while issue was closed.
A revert of this CL (patchset #2 id:20001) has been created in
https://codereview.webrtc.org/1459123002/ by henrika@webrtc.org.

The reason for reverting is: Reverting since this fix might hide real issue and
the reported root problem seems extremely rare..

Powered by Google App Engine
This is Rietveld 408576698