Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(36)

Issue 1441363002: Revert of Android MediaCodecVideoDecoder: Manage lifetime of texture frames (Closed)

Created:
5 years, 1 month ago by perkj_webrtc
Modified:
5 years, 1 month ago
Reviewers:
magjed_webrtc, AlexG
CC:
webrtc-reviews_webrtc.org, yujie_mao (webrtc), Andrew MacDonald, tterriberry_mozilla.com, qiang.lu, niklas.enbom, peah-webrtc
Base URL:
https://chromium.googlesource.com/external/webrtc.git@master
Target Ref:
refs/pending/heads/master
Project:
webrtc
Visibility:
Public.

Description

Revert of Android MediaCodecVideoDecoder: Manage lifetime of texture frames (patchset #12 id:320001 of https://codereview.webrtc.org/1422963003/ ) Reason for revert: Causes fallback to SW decoder if a renderer is put in the background. Original issue's description: > Patchset 1 is a pure > revert of "Revert of "Android MediaCodecVideoDecoder: Manage lifetime of texture frames" https://codereview.webrtc.org/1378033003/ > > Following patchsets move the responsibility of calculating the decode time to Java. > > TESTED= Apprtc loopback using H264 and VP8 on N5, N6, N7, S5 > > Committed: https://crrev.com/9cb8982e64f08d3d630bf7c3d2bcc78c10db88e2 > Cr-Commit-Position: refs/heads/master@{#10597} TBR=magjed@webrtc.org,glaznev@webrtc.org NOPRESUBMIT=true NOTREECHECKS=true Committed: https://crrev.com/c01c25434ba92f6ea32cdfdcde77ec8278182851 Cr-Commit-Position: refs/heads/master@{#10637}

Patch Set 1 #

Patch Set 2 : Manual revert. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+271 lines, -352 lines) Patch
M talk/app/webrtc/androidtests/src/org/webrtc/VideoCapturerAndroidTest.java View 1 4 chunks +8 lines, -4 lines 0 comments Download
M talk/app/webrtc/java/android/org/webrtc/SurfaceViewRenderer.java View 1 2 chunks +18 lines, -1 line 0 comments Download
M talk/app/webrtc/java/android/org/webrtc/VideoRendererGui.java View 1 2 chunks +18 lines, -3 lines 0 comments Download
M talk/app/webrtc/java/jni/androidmediadecoder_jni.cc View 1 22 chunks +81 lines, -91 lines 0 comments Download
M talk/app/webrtc/java/jni/androidvideocapturer_jni.h View 1 2 chunks +2 lines, -2 lines 0 comments Download
M talk/app/webrtc/java/jni/androidvideocapturer_jni.cc View 1 2 chunks +12 lines, -6 lines 0 comments Download
M talk/app/webrtc/java/jni/classreferenceholder.cc View 1 1 chunk +1 line, -1 line 0 comments Download
M talk/app/webrtc/java/jni/native_handle_impl.h View 1 1 chunk +31 lines, -6 lines 0 comments Download
M talk/app/webrtc/java/jni/native_handle_impl.cc View 1 2 chunks +32 lines, -4 lines 0 comments Download
M talk/app/webrtc/java/jni/peerconnection_jni.cc View 1 2 chunks +4 lines, -4 lines 0 comments Download
M talk/app/webrtc/java/jni/surfacetexturehelper_jni.h View 1 1 chunk +1 line, -1 line 0 comments Download
M talk/app/webrtc/java/jni/surfacetexturehelper_jni.cc View 1 1 chunk +1 line, -1 line 0 comments Download
M talk/app/webrtc/java/src/org/webrtc/MediaCodecVideoDecoder.java View 1 12 chunks +56 lines, -211 lines 0 comments Download
M talk/app/webrtc/java/src/org/webrtc/VideoRenderer.java View 1 3 chunks +6 lines, -17 lines 0 comments Download

Messages

Total messages: 11 (5 generated)
perkj_webrtc
Created Revert of Android MediaCodecVideoDecoder: Manage lifetime of texture frames
5 years, 1 month ago (2015-11-13 14:56:43 UTC) #1
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1441363002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1441363002/1
5 years, 1 month ago (2015-11-13 14:56:52 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1441363002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1441363002/1
5 years, 1 month ago (2015-11-13 14:57:22 UTC) #7
commit-bot: I haz the power
Try jobs failed on following builders: android_clang_dbg on tryserver.webrtc (JOB_FAILED, http://build.chromium.org/p/tryserver.webrtc/builders/android_clang_dbg/builds/8875) android_gn_rel on tryserver.webrtc (JOB_FAILED, ...
5 years, 1 month ago (2015-11-13 14:58:10 UTC) #9
perkj_webrtc
Committed patchset #2 (id:260001) manually as c01c25434ba92f6ea32cdfdcde77ec8278182851 (presubmit successful).
5 years, 1 month ago (2015-11-13 15:58:41 UTC) #10
commit-bot: I haz the power
5 years, 1 month ago (2015-11-13 15:58:44 UTC) #11
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/c01c25434ba92f6ea32cdfdcde77ec8278182851
Cr-Commit-Position: refs/heads/master@{#10637}

Powered by Google App Engine
This is Rietveld 408576698