Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(57)

Issue 1440623002: OpenSL ES stability improvements (Closed)

Created:
5 years, 1 month ago by henrika_webrtc
Modified:
5 years, 1 month ago
Reviewers:
AlexG
CC:
webrtc-reviews_webrtc.org
Base URL:
https://chromium.googlesource.com/external/webrtc.git@master
Target Ref:
refs/pending/heads/master
Project:
webrtc
Visibility:
Public.

Description

OpenSL ES stability improvements. This CL does two things: 1) Improves stability in the existing OpenSL ES implementation for devices that supports OpenSL ES. The cost is a slight increase in latency since the focus here has been on avoiding audio glitches. 2) Adds a new Java API to exclude usage of OpenSL ES to enable comparisons between OpenSL ES and Java based audio backends. BUG=b/22452539 Committed: https://crrev.com/e71b24e42163afb48f24832ed079a92ee83f01b8 Cr-Commit-Position: refs/heads/master@{#10618}

Patch Set 1 #

Patch Set 2 : Added possibility to override default OpenSL ES blacklist per device #

Patch Set 3 : nit #

Unified diffs Side-by-side diffs Delta from patch set Stats (+43 lines, -5 lines) Patch
M webrtc/modules/audio_device/android/java/src/org/webrtc/voiceengine/WebRtcAudioManager.java View 1 2 2 chunks +16 lines, -2 lines 0 comments Download
M webrtc/modules/audio_device/android/opensles_player.h View 2 chunks +4 lines, -1 line 0 comments Download
M webrtc/modules/audio_device/android/opensles_player.cc View 5 chunks +23 lines, -2 lines 0 comments Download

Messages

Total messages: 9 (4 generated)
henrika_webrtc
Application can now do import package org.webrtc.voiceengine.WebRtcAudioManager and then calll WebRtcAudioManager.setBlacklistDeviceForOpenSLESUsage() to enable/disable OpenSL ES. ...
5 years, 1 month ago (2015-11-11 15:49:13 UTC) #3
AlexG
Thanks Henrik! lgtm
5 years, 1 month ago (2015-11-11 18:28:26 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1440623002/40001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1440623002/40001
5 years, 1 month ago (2015-11-12 08:57:22 UTC) #7
commit-bot: I haz the power
Committed patchset #3 (id:40001)
5 years, 1 month ago (2015-11-12 09:48:35 UTC) #8
commit-bot: I haz the power
5 years, 1 month ago (2015-11-12 09:48:43 UTC) #9
Message was sent while issue was closed.
Patchset 3 (id:??) landed as
https://crrev.com/e71b24e42163afb48f24832ed079a92ee83f01b8
Cr-Commit-Position: refs/heads/master@{#10618}

Powered by Google App Engine
This is Rietveld 408576698