Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(508)

Issue 1432073002: Improve informative message in codereview.settings. (Closed)

Created:
5 years, 1 month ago by kjellander_webrtc
Modified:
5 years, 1 month ago
CC:
webrtc-reviews_webrtc.org, yujie_mao (webrtc), Andrew MacDonald, tterriberry_mozilla.com, qiang.lu, niklas.enbom, peah-webrtc, brucedawson
Base URL:
https://chromium.googlesource.com/external/webrtc.git@master
Target Ref:
refs/pending/heads/master
Project:
webrtc
Visibility:
Public.

Description

Improve informative message in codereview.settings. In https://codereview.webrtc.org/1389963002 the message displayed when trying to create a CL from an unsupported location was improved. However it's confusing for developers working from a WebRTC checkout if they stand in src/webrtc when trying to create a CL. R=henrika@webrtc.org, phoglund@webrtc.org Committed: https://crrev.com/ce83ae1c19eb3fb8aea84d8e02c2c005115e0440 Cr-Commit-Position: refs/heads/master@{#10571}

Patch Set 1 #

Total comments: 2

Patch Set 2 : Comment addressed #

Unified diffs Side-by-side diffs Delta from patch set Stats (+8 lines, -6 lines) Patch
M talk/codereview.settings View 1 1 chunk +4 lines, -3 lines 0 comments Download
M webrtc/codereview.settings View 1 1 chunk +4 lines, -3 lines 0 comments Download

Messages

Total messages: 10 (3 generated)
kjellander_webrtc
5 years, 1 month ago (2015-11-10 08:04:57 UTC) #2
phoglund
lgtm, 1 nit https://codereview.webrtc.org/1432073002/diff/1/talk/codereview.settings File talk/codereview.settings (right): https://codereview.webrtc.org/1432073002/diff/1/talk/codereview.settings#newcode3 talk/codereview.settings:3: working directory is the parent directory ...
5 years, 1 month ago (2015-11-10 08:32:14 UTC) #3
kjellander_webrtc
+henrika for root owner https://codereview.webrtc.org/1432073002/diff/1/talk/codereview.settings File talk/codereview.settings (right): https://codereview.webrtc.org/1432073002/diff/1/talk/codereview.settings#newcode3 talk/codereview.settings:3: working directory is the parent ...
5 years, 1 month ago (2015-11-10 09:34:48 UTC) #5
henrika_webrtc
LGTM
5 years, 1 month ago (2015-11-10 09:37:19 UTC) #6
kjellander_webrtc
Committed patchset #2 (id:20001) manually as ce83ae1c19eb3fb8aea84d8e02c2c005115e0440 (presubmit successful).
5 years, 1 month ago (2015-11-10 10:08:42 UTC) #7
commit-bot: I haz the power
Patchset 2 (id:??) landed as https://crrev.com/ce83ae1c19eb3fb8aea84d8e02c2c005115e0440 Cr-Commit-Position: refs/heads/master@{#10571}
5 years, 1 month ago (2015-11-10 10:08:46 UTC) #8
brucedawson
5 years, 1 month ago (2015-11-10 18:06:34 UTC) #10
Message was sent while issue was closed.
lgtm! This should avoid much future confusion. Thanks.

Powered by Google App Engine
This is Rietveld 408576698