Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(393)

Issue 1389963002: Update lower-level codereview.settings files. (Closed)

Created:
5 years, 2 months ago by kjellander_webrtc
Modified:
5 years, 2 months ago
CC:
webrtc-reviews_webrtc.org, yujie_mao (webrtc), Andrew MacDonald, tterriberry_mozilla.com, qiang.lu, niklas.enbom, peah-webrtc
Base URL:
https://chromium.googlesource.com/external/webrtc.git@master
Target Ref:
refs/pending/heads/master
Project:
webrtc
Visibility:
Public.

Description

Update lower-level codereview.settings files. Every now and then we get CLs to codereview.webrtc.org that are created from a Chromium checkout by editing the code in third_party/webrtc or third_party/libjingle. By editing these lower-level codereview.settings files, we instead cause a crash during 'git cl upload', but the contents of the file will also be printed, which can work as an error message. The alternative would be to entirely remove the files. BUG= R=andrew@webrtc.org, tommi@webrtc.org Committed: https://crrev.com/a38e31a054c1f3ac9b42931c58814993281744b2 Cr-Commit-Position: refs/heads/master@{#10191}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+8 lines, -30 lines) Patch
M talk/codereview.settings View 1 chunk +4 lines, -10 lines 0 comments Download
D tools/codereview.settings View 1 chunk +0 lines, -10 lines 0 comments Download
M webrtc/codereview.settings View 1 chunk +4 lines, -10 lines 0 comments Download

Messages

Total messages: 12 (4 generated)
kjellander_webrtc
I'm not entirely sure why we've kept these around for so long, do you remember? ...
5 years, 2 months ago (2015-10-06 19:51:13 UTC) #2
brucedawson
Thanks. It's good to catch errors as early as possible and this looks like it ...
5 years, 2 months ago (2015-10-06 19:55:06 UTC) #4
Andrew MacDonald
lgtm The one advantage of this was allowing Chromium devs to upload CLs which a ...
5 years, 2 months ago (2015-10-06 20:58:45 UTC) #5
kjellander (google.com)
On 2015/10/06 20:58:45, Andrew MacDonald wrote: > lgtm > > The one advantage of this ...
5 years, 2 months ago (2015-10-06 21:07:23 UTC) #6
kjellander (google.com)
+tommi for talk OWNERS
5 years, 2 months ago (2015-10-06 21:09:07 UTC) #9
tommi
lgtm
5 years, 2 months ago (2015-10-06 21:18:51 UTC) #10
kjellander_webrtc
Committed patchset #1 (id:1) manually as a38e31a054c1f3ac9b42931c58814993281744b2 (presubmit successful).
5 years, 2 months ago (2015-10-06 21:19:40 UTC) #11
commit-bot: I haz the power
5 years, 2 months ago (2015-10-06 21:19:45 UTC) #12
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/a38e31a054c1f3ac9b42931c58814993281744b2
Cr-Commit-Position: refs/heads/master@{#10191}

Powered by Google App Engine
This is Rietveld 408576698