Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(774)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 1431103002: Move the Rent-A-Codec™ from CodecOwner to CodecManager (Closed)

Created:
5 years, 1 month ago by kwiberg-webrtc
Modified:
5 years, 1 month ago
Reviewers:
hlundin-webrtc
CC:
webrtc-reviews_webrtc.org, tterriberry_mozilla.com, hlundin-webrtc, peah-webrtc, kwiberg-webrtc, tlegrand-webrtc, the sun
Base URL:
https://chromium.googlesource.com/external/webrtc.git@rac-dyn
Target Ref:
refs/pending/heads/master
Project:
webrtc
Visibility:
Public.

Description

Move the Rent-A-Codec™ from CodecOwner to CodecManager Future CLs will move it even further down the stack. BUG=webrtc:5028 Committed: https://crrev.com/c95c366f5a894d18b836dd16afcaa629134b0cae Cr-Commit-Position: refs/heads/master@{#10580}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+32 lines, -53 lines) Patch
M webrtc/modules/audio_coding/main/acm2/codec_manager.h View 2 chunks +2 lines, -0 lines 0 comments Download
M webrtc/modules/audio_coding/main/acm2/codec_manager.cc View 3 chunks +12 lines, -8 lines 0 comments Download
M webrtc/modules/audio_coding/main/acm2/codec_owner.h View 4 chunks +0 lines, -14 lines 0 comments Download
M webrtc/modules/audio_coding/main/acm2/codec_owner.cc View 2 chunks +0 lines, -15 lines 0 comments Download
M webrtc/modules/audio_coding/main/acm2/codec_owner_unittest.cc View 5 chunks +8 lines, -10 lines 0 comments Download
A + webrtc/modules/audio_coding/main/acm2/rent_a_codec_unittest.cc View 1 chunk +9 lines, -6 lines 0 comments Download
M webrtc/modules/modules.gyp View 1 chunk +1 line, -0 lines 0 comments Download

Depends on Patchset:

Issue 1410333015 Patch 60001

Dependent Patchsets:

Issue 1423803007 Patch 1

Messages

Total messages: 8 (3 generated)
kwiberg-webrtc
ʘ‿ʘ
5 years, 1 month ago (2015-11-07 07:49:05 UTC) #3
hlundin-webrtc
Nice! Our basic design for CodecManager and CodecOwner still seems to hold water. LGTM
5 years, 1 month ago (2015-11-10 10:34:46 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1431103002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1431103002/1
5 years, 1 month ago (2015-11-10 12:07:39 UTC) #6
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 1 month ago (2015-11-10 14:35:25 UTC) #7
commit-bot: I haz the power
5 years, 1 month ago (2015-11-10 14:35:33 UTC) #8
Message was sent while issue was closed. 
Patchset 1 (id:??) landed as
https://crrev.com/c95c366f5a894d18b836dd16afcaa629134b0cae
Cr-Commit-Position: refs/heads/master@{#10580}

Powered by Google App Engine
This is Rietveld 408576698