Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(58)

Issue 1428063007: Revert of Move audioproc_test_utils into enable_protobuf condition. (Closed)

Created:
5 years, 1 month ago by kjellander (google.com)
Modified:
5 years, 1 month ago
CC:
webrtc-reviews_webrtc.org, peah-webrtc, Andrew MacDonald, tterriberry_mozilla.com, hlundin-webrtc, kwiberg-webrtc, the sun, aluebs-webrtc, bjornv1
Base URL:
https://chromium.googlesource.com/external/webrtc.git@master
Target Ref:
refs/pending/heads/master
Project:
webrtc
Visibility:
Public.

Description

Revert of Move audioproc_test_utils into enable_protobuf condition. (patchset #1 id:1 of https://codereview.webrtc.org/1419533010/ ) Reason for revert: I'm going to revert this and https://codereview.webrtc.org/1409943002 to get things back in a good state. Original issue's description: > Move audioproc_test_utils into enable_protobuf condition. > > From https://codereview.webrtc.org/1409943002 this target doesn't > pass GYP on iOS unless build_with_libjingle==1. > Our bots currently build with that, but we want to remove that GYP_DEFINES > from the bots since http://www.webrtc.org/native-code/ios doesn't > say it's needed. > > R=aluebs@webrtc.org > > Committed: https://crrev.com/e2a89251d9a75c2439daddd80f732ab505d0e1b9 > Cr-Commit-Position: refs/heads/master@{#10510} TBR=andrew@webrtc.org,aluebs@webrtc.org,kjellander@webrtc.org NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true Committed: https://crrev.com/f97bfed6c7af152765240a1ca414f967a519500e Cr-Commit-Position: refs/heads/master@{#10521}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+15 lines, -15 lines) Patch
M webrtc/modules/audio_processing/audio_processing_tests.gypi View 2 chunks +15 lines, -15 lines 0 comments Download

Messages

Total messages: 10 (2 generated)
kjellander (google.com)
Created Revert of Move audioproc_test_utils into enable_protobuf condition.
5 years, 1 month ago (2015-11-05 13:56:30 UTC) #1
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1428063007/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1428063007/1
5 years, 1 month ago (2015-11-05 13:56:38 UTC) #2
commit-bot: I haz the power
No L-G-T-M from a valid reviewer yet. Only full committers are accepted. Even if an ...
5 years, 1 month ago (2015-11-05 13:56:40 UTC) #4
kjellander_webrtc
Made the revert with my google.com account :( lgtm'ing with webrtc.org to get this in.
5 years, 1 month ago (2015-11-05 14:01:19 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1428063007/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1428063007/1
5 years, 1 month ago (2015-11-05 14:01:31 UTC) #7
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 1 month ago (2015-11-05 14:02:18 UTC) #8
commit-bot: I haz the power
Patchset 1 (id:??) landed as https://crrev.com/f97bfed6c7af152765240a1ca414f967a519500e Cr-Commit-Position: refs/heads/master@{#10521}
5 years, 1 month ago (2015-11-05 14:02:28 UTC) #9
aluebs-webrtc
5 years, 1 month ago (2015-11-05 18:50:08 UTC) #10
Message was sent while issue was closed.
lgtm

Powered by Google App Engine
This is Rietveld 408576698