Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(71)

Issue 1419533010: Move audioproc_test_utils into enable_protobuf condition. (Closed)

Created:
5 years, 1 month ago by kjellander_webrtc
Modified:
5 years, 1 month ago
CC:
webrtc-reviews_webrtc.org, peah-webrtc, Andrew MacDonald, tterriberry_mozilla.com, hlundin-webrtc, kwiberg-webrtc, the sun, aluebs-webrtc, bjornv1
Base URL:
https://chromium.googlesource.com/external/webrtc.git@master
Target Ref:
refs/pending/heads/master
Project:
webrtc
Visibility:
Public.

Description

Move audioproc_test_utils into enable_protobuf condition. From https://codereview.webrtc.org/1409943002 this target doesn't pass GYP on iOS unless build_with_libjingle==1. Our bots currently build with that, but we want to remove that GYP_DEFINES from the bots since http://www.webrtc.org/native-code/ios doesn't say it's needed. R=aluebs@webrtc.org Committed: https://crrev.com/e2a89251d9a75c2439daddd80f732ab505d0e1b9 Cr-Commit-Position: refs/heads/master@{#10510}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+15 lines, -15 lines) Patch
M webrtc/modules/audio_processing/audio_processing_tests.gypi View 2 chunks +15 lines, -15 lines 0 comments Download

Messages

Total messages: 11 (3 generated)
kjellander_webrtc
5 years, 1 month ago (2015-11-04 15:39:15 UTC) #4
aluebs-webrtc
lgtm
5 years, 1 month ago (2015-11-04 18:45:03 UTC) #5
kjellander_webrtc
Committed patchset #1 (id:1) manually as e2a89251d9a75c2439daddd80f732ab505d0e1b9 (presubmit successful).
5 years, 1 month ago (2015-11-04 18:57:03 UTC) #6
commit-bot: I haz the power
Patchset 1 (id:??) landed as https://crrev.com/e2a89251d9a75c2439daddd80f732ab505d0e1b9 Cr-Commit-Position: refs/heads/master@{#10510}
5 years, 1 month ago (2015-11-04 18:57:10 UTC) #7
kjellander_webrtc
On 2015/11/04 18:57:10, commit-bot: I haz the power wrote: > Patchset 1 (id:??) landed as ...
5 years, 1 month ago (2015-11-04 19:49:48 UTC) #8
zjx20
On 2015/11/04 15:39:15, kjellander (webrtc) wrote: Hi @kjellander, This CL fixes this error: Updating projects ...
5 years, 1 month ago (2015-11-05 03:28:36 UTC) #9
kjellander_webrtc
On 2015/11/05 03:28:36, zjx20 wrote: > On 2015/11/04 15:39:15, kjellander (webrtc) wrote: > > Hi ...
5 years, 1 month ago (2015-11-05 06:50:44 UTC) #10
kjellander (google.com)
5 years, 1 month ago (2015-11-05 13:56:30 UTC) #11
Message was sent while issue was closed.
A revert of this CL (patchset #1 id:1) has been created in
https://codereview.webrtc.org/1428063007/ by kjellander@google.com.

The reason for reverting is: I'm going to revert this and
https://codereview.webrtc.org/1409943002 to get things back in a good state..

Powered by Google App Engine
This is Rietveld 408576698