Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(208)

Issue 1425693005: system_wrappers: Fix include header guards. (Closed)

Created:
5 years, 1 month ago by kjellander_webrtc
Modified:
5 years, 1 month ago
Reviewers:
tommi
CC:
webrtc-reviews_webrtc.org, tterriberry_mozilla.com, Andrew MacDonald, peah-webrtc, mflodman, henrika_webrtc
Base URL:
https://chromium.googlesource.com/external/webrtc.git@master
Target Ref:
refs/pending/heads/master
Project:
webrtc
Visibility:
Public.

Description

system_wrappers: Fix include header guards. This should have been a part of https://codereview.webrtc.org/1413333002/ The header guard PRESUBMIT rule is being enabled in https://codereview.webrtc.org/1419203005 so things like this won't happen in the future. BUG=5095 NOTRY=True Committed: https://crrev.com/d56d68cd272783ae0cfe11834c2a141ec62519c2 Cr-Commit-Position: refs/heads/master@{#10475}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+105 lines, -105 lines) Patch
M webrtc/system_wrappers/include/aligned_array.h View 2 chunks +3 lines, -3 lines 0 comments Download
M webrtc/system_wrappers/include/aligned_malloc.h View 2 chunks +3 lines, -3 lines 0 comments Download
M webrtc/system_wrappers/include/asm_defines.h View 2 chunks +3 lines, -3 lines 0 comments Download
M webrtc/system_wrappers/include/atomic32.h View 2 chunks +3 lines, -3 lines 0 comments Download
M webrtc/system_wrappers/include/clock.h View 2 chunks +3 lines, -3 lines 0 comments Download
M webrtc/system_wrappers/include/compile_assert_c.h View 2 chunks +3 lines, -3 lines 0 comments Download
M webrtc/system_wrappers/include/condition_variable_wrapper.h View 2 chunks +3 lines, -3 lines 0 comments Download
M webrtc/system_wrappers/include/cpu_features_wrapper.h View 2 chunks +3 lines, -3 lines 0 comments Download
M webrtc/system_wrappers/include/cpu_info.h View 2 chunks +3 lines, -3 lines 0 comments Download
M webrtc/system_wrappers/include/critical_section_wrapper.h View 2 chunks +3 lines, -3 lines 0 comments Download
M webrtc/system_wrappers/include/data_log.h View 2 chunks +3 lines, -3 lines 0 comments Download
M webrtc/system_wrappers/include/data_log_c.h View 2 chunks +3 lines, -3 lines 0 comments Download
M webrtc/system_wrappers/include/data_log_impl.h View 2 chunks +3 lines, -3 lines 0 comments Download
M webrtc/system_wrappers/include/event_tracer.h View 1 chunk +3 lines, -3 lines 0 comments Download
M webrtc/system_wrappers/include/event_wrapper.h View 2 chunks +3 lines, -3 lines 0 comments Download
M webrtc/system_wrappers/include/field_trial.h View 2 chunks +3 lines, -3 lines 0 comments Download
M webrtc/system_wrappers/include/field_trial_default.h View 2 chunks +3 lines, -3 lines 0 comments Download
M webrtc/system_wrappers/include/file_wrapper.h View 2 chunks +3 lines, -3 lines 0 comments Download
M webrtc/system_wrappers/include/logcat_trace_context.h View 2 chunks +3 lines, -3 lines 0 comments Download
M webrtc/system_wrappers/include/logging.h View 2 chunks +3 lines, -3 lines 0 comments Download
M webrtc/system_wrappers/include/metrics.h View 2 chunks +3 lines, -3 lines 0 comments Download
M webrtc/system_wrappers/include/ref_count.h View 2 chunks +3 lines, -3 lines 0 comments Download
M webrtc/system_wrappers/include/rtp_to_ntp.h View 2 chunks +3 lines, -3 lines 0 comments Download
M webrtc/system_wrappers/include/rw_lock_wrapper.h View 2 chunks +3 lines, -3 lines 0 comments Download
M webrtc/system_wrappers/include/scoped_vector.h View 2 chunks +3 lines, -3 lines 0 comments Download
M webrtc/system_wrappers/include/sleep.h View 2 chunks +3 lines, -3 lines 0 comments Download
M webrtc/system_wrappers/include/sort.h View 2 chunks +3 lines, -3 lines 0 comments Download
M webrtc/system_wrappers/include/static_instance.h View 2 chunks +3 lines, -3 lines 0 comments Download
M webrtc/system_wrappers/include/stl_util.h View 2 chunks +3 lines, -3 lines 0 comments Download
M webrtc/system_wrappers/include/stringize_macros.h View 2 chunks +3 lines, -3 lines 0 comments Download
M webrtc/system_wrappers/include/thread_wrapper.h View 2 chunks +3 lines, -3 lines 0 comments Download
M webrtc/system_wrappers/include/tick_util.h View 2 chunks +3 lines, -3 lines 0 comments Download
M webrtc/system_wrappers/include/timestamp_extrapolator.h View 2 chunks +3 lines, -3 lines 0 comments Download
M webrtc/system_wrappers/include/trace.h View 2 chunks +3 lines, -3 lines 0 comments Download
M webrtc/system_wrappers/include/utf_util_win.h View 2 chunks +3 lines, -3 lines 0 comments Download

Messages

Total messages: 11 (6 generated)
kjellander_webrtc
While investigating this I also found that cpplint isn't enabled for any source code except ...
5 years, 1 month ago (2015-11-02 08:53:02 UTC) #4
tommi
lgtm
5 years, 1 month ago (2015-11-02 09:54:31 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1425693005/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1425693005/1
5 years, 1 month ago (2015-11-02 10:08:39 UTC) #9
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 1 month ago (2015-11-02 10:12:45 UTC) #10
commit-bot: I haz the power
5 years, 1 month ago (2015-11-02 10:13:00 UTC) #11
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/d56d68cd272783ae0cfe11834c2a141ec62519c2
Cr-Commit-Position: refs/heads/master@{#10475}

Powered by Google App Engine
This is Rietveld 408576698