Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(302)

Issue 1419203005: PRESUBMIT: Enable header guard checks for cpplint. (Closed)

Created:
5 years, 1 month ago by kjellander_webrtc
Modified:
5 years, 1 month ago
Reviewers:
phoglund
CC:
webrtc-reviews_webrtc.org, qiang.lu, niklas.enbom, yujie_mao (webrtc), peah-webrtc, Andrew MacDonald
Base URL:
https://chromium.googlesource.com/external/webrtc.git@master
Target Ref:
refs/pending/heads/master
Project:
webrtc
Visibility:
Public.

Description

PRESUBMIT: Enable header guard checks for cpplint. This check has always been disabled since the start in https://webrtc-codereview.appspot.com/317011 since it didn't support our style guide back then (wanted our source code to be prefixed with SRC_ in the header guards). I belive this was later fixed in https://chromiumcodereview.appspot.com/15864011. At least it can now be enabled. BUG=5149 NOTRY=True Committed: https://crrev.com/8cc126f91bc0dcb3506100d780146850de23b714 Cr-Commit-Position: refs/heads/master@{#10482}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+0 lines, -7 lines) Patch
M PRESUBMIT.py View 1 chunk +0 lines, -7 lines 0 comments Download

Messages

Total messages: 8 (3 generated)
kjellander_webrtc
5 years, 1 month ago (2015-11-02 08:49:43 UTC) #2
phoglund
lgtm
5 years, 1 month ago (2015-11-02 12:56:19 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1419203005/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1419203005/1
5 years, 1 month ago (2015-11-02 13:16:45 UTC) #6
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 1 month ago (2015-11-02 13:20:44 UTC) #7
commit-bot: I haz the power
5 years, 1 month ago (2015-11-02 13:20:54 UTC) #8
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/8cc126f91bc0dcb3506100d780146850de23b714
Cr-Commit-Position: refs/heads/master@{#10482}

Powered by Google App Engine
This is Rietveld 408576698