PRESUBMIT.py - Issue 1419203005: PRESUBMIT: Enable header guard checks for cpplint.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: PRESUBMIT.py

Issue 1419203005: PRESUBMIT: Enable header guard checks for cpplint. (Closed) Base URL: https://chromium.googlesource.com/external/webrtc.git@master

Patch Set: Created 5 years, 1 month ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: PRESUBMIT.py

diff --git a/PRESUBMIT.py b/PRESUBMIT.py

index e7ceac94cf72662ceb6d67f41077e7677e985c56..a832761c89dbd05a4205729a132260d5df334b22 100755

--- a/PRESUBMIT.py

+++ b/PRESUBMIT.py

@@ -68,13 +68,6 @@ def _CheckApprovedFilesLintClean(input_api, output_api,

# pylint: disable=W0212

cpplint._cpplint_state.ResetErrorCounts()

- # Justifications for each filter:

- #

- # - build/header_guard : WebRTC coding style says they should be prefixed

- # with WEBRTC_, which is not possible to configure in

- # cpplint.py.

- cpplint._SetFilters('-build/header_guard')

# Use the strictest verbosity level for cpplint.py (level 1) which is the

# default when running cpplint.py from command line.

# To make it possible to work with not-yet-converted code, we're only applying

« no previous file with comments | « no previous file | no next file » | no next file with comments »