Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(187)

Issue 1425133002: ACM/NetEq: Restructure how post-decode VAD is enabled (Closed)

Created:
5 years, 1 month ago by hlundin-webrtc
Modified:
5 years, 1 month ago
Reviewers:
kwiberg-webrtc
CC:
webrtc-reviews_webrtc.org, tterriberry_mozilla.com, hlundin-webrtc, peah-webrtc, kwiberg-webrtc, tlegrand-webrtc
Base URL:
https://chromium.googlesource.com/external/webrtc.git@acm-recv-nack
Target Ref:
refs/pending/heads/master
Project:
webrtc
Visibility:
Public.

Description

ACM/NetEq: Restructure how post-decode VAD is enabled This change avoids calling neteq_->EnableVad() and DisableVad from the AcmReceiver constructor. Instead, the new member enable_post_decode_vad is added to NetEq's config struct. It is disabled by defualt, but ACM sets it to enabled. This preserves the behavior both of NetEq stand-alone (i.e., in tests) and of ACM. BUG=webrtc:3520 Committed: https://crrev.com/9bc2667fa6deee5d4162b13a878481640a58cce5 Cr-Commit-Position: refs/heads/master@{#10476}

Patch Set 1 #

Patch Set 2 : Actually doing something with the new config #

Unified diffs Side-by-side diffs Delta from patch set Stats (+14 lines, -11 lines) Patch
M webrtc/modules/audio_coding/main/acm2/acm_receiver.cc View 2 chunks +1 line, -10 lines 0 comments Download
M webrtc/modules/audio_coding/main/include/audio_coding_module.h View 1 chunk +5 lines, -1 line 0 comments Download
M webrtc/modules/audio_coding/neteq/include/neteq.h View 2 chunks +2 lines, -0 lines 0 comments Download
M webrtc/modules/audio_coding/neteq/neteq.cc View 1 chunk +2 lines, -0 lines 0 comments Download
M webrtc/modules/audio_coding/neteq/neteq_impl.cc View 1 1 chunk +4 lines, -0 lines 0 comments Download

Depends on Patchset:

Messages

Total messages: 18 (6 generated)
hlundin-webrtc
PTAL
5 years, 1 month ago (2015-10-29 10:55:48 UTC) #2
kwiberg-webrtc
lgtm
5 years, 1 month ago (2015-11-01 11:09:04 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1425133002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1425133002/1
5 years, 1 month ago (2015-11-01 20:44:26 UTC) #5
commit-bot: I haz the power
Try jobs failed on following builders: linux_msan on tryserver.webrtc (JOB_FAILED, http://build.chromium.org/p/tryserver.webrtc/builders/linux_msan/builds/5650)
5 years, 1 month ago (2015-11-01 20:57:06 UTC) #7
hlundin-webrtc
Actually doing something with the new config
5 years, 1 month ago (2015-11-02 10:28:10 UTC) #8
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1425133002/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1425133002/20001
5 years, 1 month ago (2015-11-02 10:29:06 UTC) #10
hlundin-webrtc
I managed to forget a rather crucial detail in the first patch set, but the ...
5 years, 1 month ago (2015-11-02 10:31:41 UTC) #11
kwiberg-webrtc
lgtm
5 years, 1 month ago (2015-11-02 10:59:29 UTC) #12
commit-bot: I haz the power
Dry run: This issue passed the CQ dry run.
5 years, 1 month ago (2015-11-02 11:20:20 UTC) #14
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1425133002/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1425133002/20001
5 years, 1 month ago (2015-11-02 11:24:51 UTC) #16
commit-bot: I haz the power
Committed patchset #2 (id:20001)
5 years, 1 month ago (2015-11-02 11:26:04 UTC) #17
commit-bot: I haz the power
5 years, 1 month ago (2015-11-02 11:26:09 UTC) #18
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/9bc2667fa6deee5d4162b13a878481640a58cce5
Cr-Commit-Position: refs/heads/master@{#10476}

Powered by Google App Engine
This is Rietveld 408576698