Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(208)

Side by Side Diff: webrtc/modules/audio_coding/main/include/audio_coding_module.h

Issue 1425133002: ACM/NetEq: Restructure how post-decode VAD is enabled (Closed) Base URL: https://chromium.googlesource.com/external/webrtc.git@acm-recv-nack
Patch Set: Actually doing something with the new config Created 5 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 /* 1 /*
2 * Copyright (c) 2012 The WebRTC project authors. All Rights Reserved. 2 * Copyright (c) 2012 The WebRTC project authors. All Rights Reserved.
3 * 3 *
4 * Use of this source code is governed by a BSD-style license 4 * Use of this source code is governed by a BSD-style license
5 * that can be found in the LICENSE file in the root of the source 5 * that can be found in the LICENSE file in the root of the source
6 * tree. An additional intellectual property rights grant can be found 6 * tree. An additional intellectual property rights grant can be found
7 * in the file PATENTS. All contributing project authors may 7 * in the file PATENTS. All contributing project authors may
8 * be found in the AUTHORS file in the root of the source tree. 8 * be found in the AUTHORS file in the root of the source tree.
9 */ 9 */
10 10
(...skipping 42 matching lines...) Expand 10 before | Expand all | Expand 10 after
53 53
54 virtual int32_t InFrameType(FrameType frame_type) = 0; 54 virtual int32_t InFrameType(FrameType frame_type) = 0;
55 }; 55 };
56 56
57 class AudioCodingModule { 57 class AudioCodingModule {
58 protected: 58 protected:
59 AudioCodingModule() {} 59 AudioCodingModule() {}
60 60
61 public: 61 public:
62 struct Config { 62 struct Config {
63 Config() : id(0), neteq_config(), clock(Clock::GetRealTimeClock()) {} 63 Config() : id(0), neteq_config(), clock(Clock::GetRealTimeClock()) {
64 // Post-decode VAD is disabled by default in NetEq, however, Audio
65 // Conference Mixer relies on VAD decisions and fails without them.
66 neteq_config.enable_post_decode_vad = true;
67 }
64 68
65 int id; 69 int id;
66 NetEq::Config neteq_config; 70 NetEq::Config neteq_config;
67 Clock* clock; 71 Clock* clock;
68 }; 72 };
69 73
70 /////////////////////////////////////////////////////////////////////////// 74 ///////////////////////////////////////////////////////////////////////////
71 // Creation and destruction of a ACM. 75 // Creation and destruction of a ACM.
72 // 76 //
73 // The second method is used for testing where a simulated clock can be 77 // The second method is used for testing where a simulated clock can be
(...skipping 675 matching lines...) Expand 10 before | Expand all | Expand 10 after
749 virtual std::vector<uint16_t> GetNackList( 753 virtual std::vector<uint16_t> GetNackList(
750 int64_t round_trip_time_ms) const = 0; 754 int64_t round_trip_time_ms) const = 0;
751 755
752 virtual void GetDecodingCallStatistics( 756 virtual void GetDecodingCallStatistics(
753 AudioDecodingCallStats* call_stats) const = 0; 757 AudioDecodingCallStats* call_stats) const = 0;
754 }; 758 };
755 759
756 } // namespace webrtc 760 } // namespace webrtc
757 761
758 #endif // WEBRTC_MODULES_AUDIO_CODING_MAIN_INCLUDE_AUDIO_CODING_MODULE_H_ 762 #endif // WEBRTC_MODULES_AUDIO_CODING_MAIN_INCLUDE_AUDIO_CODING_MODULE_H_
OLDNEW
« no previous file with comments | « webrtc/modules/audio_coding/main/acm2/acm_receiver.cc ('k') | webrtc/modules/audio_coding/neteq/include/neteq.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698