Make an enum class out of NetEqDecoder, and hide the neteq_decoders_ table

Make an enum class out of NetEqDecoder, and hide the neteq_decoders_ table

This operation was relatively simple, since no one was doing anything
fishy with this enum. A large number of lines had to be changed
because the enum values now live in their own namespace, but this is
arguably worth it since it is now much clearer what sort of constant
they are.

BUG=webrtc:5028
Committed: https://crrev.com/ee1879ca40ffe4af9bb9613e03eacc5c2c4881fc
Cr-Commit-Position: refs/heads/master@{#10449}

[kwiberg-webrtc, 2015-10-27 19:43:08]

Patchset #1 (id:1) has been deleted

[kwiberg-webrtc, 2015-10-27 20:07:35]

Patchset #1 (id:20001) has been deleted

[kwiberg-webrtc, 2015-10-28 06:08:14]

Patchset #1 (id:40001) has been deleted

[kwiberg-webrtc, 2015-10-28 10:07:23]

Description was changed from

==========
Make an enum class out of NetEqDecoder, and hide the neteq_decoders_ table

This operation was relatively simple, since no one was doing anything
fishy with this enum. A large number of lines had to be changed
because the enum values now live in their own namespace, but this is
arguably worth it since it is now much clearer what sort of constant
they are.

BUG=webrtc:5028
==========

to

==========
Make an enum class out of NetEqDecoder, and hide the neteq_decoders_ table

This operation was relatively simple, since no one was doing anything
fishy with this enum. A large number of lines had to be changed
because the enum values now live in their own namespace, but this is
arguably worth it since it is now much clearer what sort of constant
they are.

BUG=webrtc:5028
==========

[kwiberg-webrtc, 2015-10-28 10:07:23]

kwiberg@webrtc.org changed reviewers:
+ henrik.lundin@webrtc.org

[kwiberg-webrtc, 2015-10-28 10:07:53]

PTAL

[hlundin-webrtc, 2015-10-28 15:14:47]

Nice. LGTM with one nit.

https://codereview.webrtc.org/1424083002/diff/60001/webrtc/modules/audio_codi...
File webrtc/modules/audio_coding/main/acm2/acm_receiver.cc (right):

https://codereview.webrtc.org/1424083002/diff/60001/webrtc/modules/audio_codi...
webrtc/modules/audio_coding/main/acm2/acm_receiver.cc:447: RTC_DCHECK(cid);  //
acm_codec_id was a valid codec index.
I prefer you stream the debug information to RTC_DCHECK for improved
debuggability.

[kwiberg-webrtc, 2015-10-29 09:29:15]

New patch set posted with exactly the changes you asked for.

https://codereview.webrtc.org/1424083002/diff/60001/webrtc/modules/audio_codi...
File webrtc/modules/audio_coding/main/acm2/acm_receiver.cc (right):

https://codereview.webrtc.org/1424083002/diff/60001/webrtc/modules/audio_codi...
webrtc/modules/audio_coding/main/acm2/acm_receiver.cc:447: RTC_DCHECK(cid);  //
acm_codec_id was a valid codec index.
On 2015/10/28 15:14:47, hlundin-webrtc wrote:
> I prefer you stream the debug information to RTC_DCHECK for improved
> debuggability.

Done.

[kwiberg-webrtc, 2015-10-29 10:46:43]

The CQ bit was checked by kwiberg@webrtc.org

[kwiberg-webrtc, 2015-10-29 10:46:43]

The patchset sent to the CQ was uploaded after l-g-t-m from
henrik.lundin@webrtc.org
Link to the patchset: https://codereview.webrtc.org/1424083002/#ps80001 (title:
"Custom DCHECK error messages")

[commit-bot: I haz the power, 2015-10-29 10:46:56]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1424083002/80001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1424083002/80001

[commit-bot: I haz the power, 2015-10-29 10:53:20]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2015-10-29 10:53:20]

Try jobs failed on following builders:
  presubmit on tryserver.webrtc (JOB_FAILED,
http://build.chromium.org/p/tryserver.webrtc/builders/presubmit/builds/1458)

[kwiberg-webrtc, 2015-10-29 11:05:28]

The CQ bit was checked by kwiberg@webrtc.org

[kwiberg-webrtc, 2015-10-29 11:05:28]

The patchset sent to the CQ was uploaded after l-g-t-m from
henrik.lundin@webrtc.org
Link to the patchset: https://codereview.webrtc.org/1424083002/#ps100001 (title:
"rebase")

[commit-bot: I haz the power, 2015-10-29 11:05:45]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1424083002/100001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1424083002/100001

[commit-bot: I haz the power, 2015-10-29 13:20:32]

Committed patchset #3 (id:100001)

[commit-bot: I haz the power, 2015-10-29 13:20:46]

Patchset 3 (id:??) landed as
https://crrev.com/ee1879ca40ffe4af9bb9613e03eacc5c2c4881fc
Cr-Commit-Position: refs/heads/master@{#10449}