Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1194)

Unified Diff: webrtc/modules/audio_coding/neteq/tools/neteq_rtpplay.cc

Issue 1424083002: Make an enum class out of NetEqDecoder, and hide the neteq_decoders_ table (Closed) Base URL: https://chromium.googlesource.com/external/webrtc.git@master
Patch Set: rebase Created 5 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « webrtc/modules/audio_coding/neteq/tools/neteq_quality_test.cc ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: webrtc/modules/audio_coding/neteq/tools/neteq_rtpplay.cc
diff --git a/webrtc/modules/audio_coding/neteq/tools/neteq_rtpplay.cc b/webrtc/modules/audio_coding/neteq/tools/neteq_rtpplay.cc
index 756354b7c95e6685e4e930b57df9a1e535f90700..0aaf8c71fdfc8389d591797b6d2b6da1fc66bc14 100644
--- a/webrtc/modules/audio_coding/neteq/tools/neteq_rtpplay.cc
+++ b/webrtc/modules/audio_coding/neteq/tools/neteq_rtpplay.cc
@@ -147,39 +147,39 @@ const bool hex_ssrc_dummy =
// Maps a codec type to a printable name string.
std::string CodecName(webrtc::NetEqDecoder codec) {
switch (codec) {
- case webrtc::kDecoderPCMu:
+ case webrtc::NetEqDecoder::kDecoderPCMu:
return "PCM-u";
- case webrtc::kDecoderPCMa:
+ case webrtc::NetEqDecoder::kDecoderPCMa:
return "PCM-a";
- case webrtc::kDecoderILBC:
+ case webrtc::NetEqDecoder::kDecoderILBC:
return "iLBC";
- case webrtc::kDecoderISAC:
+ case webrtc::NetEqDecoder::kDecoderISAC:
return "iSAC";
- case webrtc::kDecoderISACswb:
+ case webrtc::NetEqDecoder::kDecoderISACswb:
return "iSAC-swb (32 kHz)";
- case webrtc::kDecoderOpus:
+ case webrtc::NetEqDecoder::kDecoderOpus:
return "Opus";
- case webrtc::kDecoderPCM16B:
+ case webrtc::NetEqDecoder::kDecoderPCM16B:
return "PCM16b-nb (8 kHz)";
- case webrtc::kDecoderPCM16Bwb:
+ case webrtc::NetEqDecoder::kDecoderPCM16Bwb:
return "PCM16b-wb (16 kHz)";
- case webrtc::kDecoderPCM16Bswb32kHz:
+ case webrtc::NetEqDecoder::kDecoderPCM16Bswb32kHz:
return "PCM16b-swb32 (32 kHz)";
- case webrtc::kDecoderPCM16Bswb48kHz:
+ case webrtc::NetEqDecoder::kDecoderPCM16Bswb48kHz:
return "PCM16b-swb48 (48 kHz)";
- case webrtc::kDecoderG722:
+ case webrtc::NetEqDecoder::kDecoderG722:
return "G.722";
- case webrtc::kDecoderRED:
+ case webrtc::NetEqDecoder::kDecoderRED:
return "redundant audio (RED)";
- case webrtc::kDecoderAVT:
+ case webrtc::NetEqDecoder::kDecoderAVT:
return "AVT/DTMF";
- case webrtc::kDecoderCNGnb:
+ case webrtc::NetEqDecoder::kDecoderCNGnb:
return "comfort noise (8 kHz)";
- case webrtc::kDecoderCNGwb:
+ case webrtc::NetEqDecoder::kDecoderCNGwb:
return "comfort noise (16 kHz)";
- case webrtc::kDecoderCNGswb32kHz:
+ case webrtc::NetEqDecoder::kDecoderCNGswb32kHz:
return "comfort noise (32 kHz)";
- case webrtc::kDecoderCNGswb48kHz:
+ case webrtc::NetEqDecoder::kDecoderCNGswb48kHz:
return "comfort noise (48 kHz)";
default:
assert(false);
@@ -200,25 +200,30 @@ void RegisterPayloadType(NetEq* neteq,
// Registers all decoders in |neteq|.
void RegisterPayloadTypes(NetEq* neteq) {
assert(neteq);
- RegisterPayloadType(neteq, webrtc::kDecoderPCMu, FLAGS_pcmu);
- RegisterPayloadType(neteq, webrtc::kDecoderPCMa, FLAGS_pcma);
- RegisterPayloadType(neteq, webrtc::kDecoderILBC, FLAGS_ilbc);
- RegisterPayloadType(neteq, webrtc::kDecoderISAC, FLAGS_isac);
- RegisterPayloadType(neteq, webrtc::kDecoderISACswb, FLAGS_isac_swb);
- RegisterPayloadType(neteq, webrtc::kDecoderOpus, FLAGS_opus);
- RegisterPayloadType(neteq, webrtc::kDecoderPCM16B, FLAGS_pcm16b);
- RegisterPayloadType(neteq, webrtc::kDecoderPCM16Bwb, FLAGS_pcm16b_wb);
- RegisterPayloadType(neteq, webrtc::kDecoderPCM16Bswb32kHz,
+ RegisterPayloadType(neteq, webrtc::NetEqDecoder::kDecoderPCMu, FLAGS_pcmu);
+ RegisterPayloadType(neteq, webrtc::NetEqDecoder::kDecoderPCMa, FLAGS_pcma);
+ RegisterPayloadType(neteq, webrtc::NetEqDecoder::kDecoderILBC, FLAGS_ilbc);
+ RegisterPayloadType(neteq, webrtc::NetEqDecoder::kDecoderISAC, FLAGS_isac);
+ RegisterPayloadType(neteq, webrtc::NetEqDecoder::kDecoderISACswb,
+ FLAGS_isac_swb);
+ RegisterPayloadType(neteq, webrtc::NetEqDecoder::kDecoderOpus, FLAGS_opus);
+ RegisterPayloadType(neteq, webrtc::NetEqDecoder::kDecoderPCM16B,
+ FLAGS_pcm16b);
+ RegisterPayloadType(neteq, webrtc::NetEqDecoder::kDecoderPCM16Bwb,
+ FLAGS_pcm16b_wb);
+ RegisterPayloadType(neteq, webrtc::NetEqDecoder::kDecoderPCM16Bswb32kHz,
FLAGS_pcm16b_swb32);
- RegisterPayloadType(neteq, webrtc::kDecoderPCM16Bswb48kHz,
+ RegisterPayloadType(neteq, webrtc::NetEqDecoder::kDecoderPCM16Bswb48kHz,
FLAGS_pcm16b_swb48);
- RegisterPayloadType(neteq, webrtc::kDecoderG722, FLAGS_g722);
- RegisterPayloadType(neteq, webrtc::kDecoderAVT, FLAGS_avt);
- RegisterPayloadType(neteq, webrtc::kDecoderRED, FLAGS_red);
- RegisterPayloadType(neteq, webrtc::kDecoderCNGnb, FLAGS_cn_nb);
- RegisterPayloadType(neteq, webrtc::kDecoderCNGwb, FLAGS_cn_wb);
- RegisterPayloadType(neteq, webrtc::kDecoderCNGswb32kHz, FLAGS_cn_swb32);
- RegisterPayloadType(neteq, webrtc::kDecoderCNGswb48kHz, FLAGS_cn_swb48);
+ RegisterPayloadType(neteq, webrtc::NetEqDecoder::kDecoderG722, FLAGS_g722);
+ RegisterPayloadType(neteq, webrtc::NetEqDecoder::kDecoderAVT, FLAGS_avt);
+ RegisterPayloadType(neteq, webrtc::NetEqDecoder::kDecoderRED, FLAGS_red);
+ RegisterPayloadType(neteq, webrtc::NetEqDecoder::kDecoderCNGnb, FLAGS_cn_nb);
+ RegisterPayloadType(neteq, webrtc::NetEqDecoder::kDecoderCNGwb, FLAGS_cn_wb);
+ RegisterPayloadType(neteq, webrtc::NetEqDecoder::kDecoderCNGswb32kHz,
+ FLAGS_cn_swb32);
+ RegisterPayloadType(neteq, webrtc::NetEqDecoder::kDecoderCNGswb48kHz,
+ FLAGS_cn_swb48);
}
void PrintCodecMappingEntry(webrtc::NetEqDecoder codec, google::int32 flag) {
@@ -226,23 +231,28 @@ void PrintCodecMappingEntry(webrtc::NetEqDecoder codec, google::int32 flag) {
}
void PrintCodecMapping() {
- PrintCodecMappingEntry(webrtc::kDecoderPCMu, FLAGS_pcmu);
- PrintCodecMappingEntry(webrtc::kDecoderPCMa, FLAGS_pcma);
- PrintCodecMappingEntry(webrtc::kDecoderILBC, FLAGS_ilbc);
- PrintCodecMappingEntry(webrtc::kDecoderISAC, FLAGS_isac);
- PrintCodecMappingEntry(webrtc::kDecoderISACswb, FLAGS_isac_swb);
- PrintCodecMappingEntry(webrtc::kDecoderOpus, FLAGS_opus);
- PrintCodecMappingEntry(webrtc::kDecoderPCM16B, FLAGS_pcm16b);
- PrintCodecMappingEntry(webrtc::kDecoderPCM16Bwb, FLAGS_pcm16b_wb);
- PrintCodecMappingEntry(webrtc::kDecoderPCM16Bswb32kHz, FLAGS_pcm16b_swb32);
- PrintCodecMappingEntry(webrtc::kDecoderPCM16Bswb48kHz, FLAGS_pcm16b_swb48);
- PrintCodecMappingEntry(webrtc::kDecoderG722, FLAGS_g722);
- PrintCodecMappingEntry(webrtc::kDecoderAVT, FLAGS_avt);
- PrintCodecMappingEntry(webrtc::kDecoderRED, FLAGS_red);
- PrintCodecMappingEntry(webrtc::kDecoderCNGnb, FLAGS_cn_nb);
- PrintCodecMappingEntry(webrtc::kDecoderCNGwb, FLAGS_cn_wb);
- PrintCodecMappingEntry(webrtc::kDecoderCNGswb32kHz, FLAGS_cn_swb32);
- PrintCodecMappingEntry(webrtc::kDecoderCNGswb48kHz, FLAGS_cn_swb48);
+ PrintCodecMappingEntry(webrtc::NetEqDecoder::kDecoderPCMu, FLAGS_pcmu);
+ PrintCodecMappingEntry(webrtc::NetEqDecoder::kDecoderPCMa, FLAGS_pcma);
+ PrintCodecMappingEntry(webrtc::NetEqDecoder::kDecoderILBC, FLAGS_ilbc);
+ PrintCodecMappingEntry(webrtc::NetEqDecoder::kDecoderISAC, FLAGS_isac);
+ PrintCodecMappingEntry(webrtc::NetEqDecoder::kDecoderISACswb, FLAGS_isac_swb);
+ PrintCodecMappingEntry(webrtc::NetEqDecoder::kDecoderOpus, FLAGS_opus);
+ PrintCodecMappingEntry(webrtc::NetEqDecoder::kDecoderPCM16B, FLAGS_pcm16b);
+ PrintCodecMappingEntry(webrtc::NetEqDecoder::kDecoderPCM16Bwb,
+ FLAGS_pcm16b_wb);
+ PrintCodecMappingEntry(webrtc::NetEqDecoder::kDecoderPCM16Bswb32kHz,
+ FLAGS_pcm16b_swb32);
+ PrintCodecMappingEntry(webrtc::NetEqDecoder::kDecoderPCM16Bswb48kHz,
+ FLAGS_pcm16b_swb48);
+ PrintCodecMappingEntry(webrtc::NetEqDecoder::kDecoderG722, FLAGS_g722);
+ PrintCodecMappingEntry(webrtc::NetEqDecoder::kDecoderAVT, FLAGS_avt);
+ PrintCodecMappingEntry(webrtc::NetEqDecoder::kDecoderRED, FLAGS_red);
+ PrintCodecMappingEntry(webrtc::NetEqDecoder::kDecoderCNGnb, FLAGS_cn_nb);
+ PrintCodecMappingEntry(webrtc::NetEqDecoder::kDecoderCNGwb, FLAGS_cn_wb);
+ PrintCodecMappingEntry(webrtc::NetEqDecoder::kDecoderCNGswb32kHz,
+ FLAGS_cn_swb32);
+ PrintCodecMappingEntry(webrtc::NetEqDecoder::kDecoderCNGswb48kHz,
+ FLAGS_cn_swb48);
}
bool IsComfortNoise(uint8_t payload_type) {
« no previous file with comments | « webrtc/modules/audio_coding/neteq/tools/neteq_quality_test.cc ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698