Add QP stats for received video streams to StatsReport.

Add QP stats for received video streams to StatsReport for tracking video quality.

A running average of the QP (per-frame value) for a received VP8 video stream is reported. QP range is 0-127.

BUG=

[åsapersson, 2015-10-23 10:57:35]

Patchset #1 (id:1) has been deleted

[åsapersson, 2015-10-23 11:12:55]

Patchset #1 (id:20001) has been deleted

[åsapersson, 2015-10-23 12:33:43]

Description was changed from

==========
Add QP stats for video receive streams.

BUG=
==========

to

==========
Add QP stats for video receive streams.

BUG=
==========

[åsapersson, 2015-10-23 12:33:43]

asapersson@webrtc.org changed reviewers:
+ mflodman@webrtc.org, pbos@webrtc.org

[åsapersson, 2015-10-23 12:38:40]

Description was changed from

==========
Add QP stats for video receive streams.

BUG=
==========

to

==========
Add QP stats for video receive streams to StatsReport.

BUG=
==========

[åsapersson, 2015-10-27 14:10:38]

asapersson@webrtc.org changed reviewers:
+ perkj@webrtc.org

[perkj_webrtc, 2015-10-27 20:50:35]

I have not reviewed the whole cl.

https://codereview.webrtc.org/1420963005/diff/40001/talk/app/webrtc/statstype...
File talk/app/webrtc/statstypes.cc (right):

https://codereview.webrtc.org/1420963005/diff/40001/talk/app/webrtc/statstype...
talk/app/webrtc/statstypes.cc:560: return "googQpReceived";
Has this been cleared with Hta and or juberti? I thought we were not allowed to
add more goog specific.

[mflodman, 2015-10-28 07:16:03]

On 2015/10/27 20:50:35, perkj1 wrote:
> I have not reviewed the whole cl.
> 
>
https://codereview.webrtc.org/1420963005/diff/40001/talk/app/webrtc/statstype...
> File talk/app/webrtc/statstypes.cc (right):
> 
>
https://codereview.webrtc.org/1420963005/diff/40001/talk/app/webrtc/statstype...
> talk/app/webrtc/statstypes.cc:560: return "googQpReceived";
> Has this been cleared with Hta and or juberti? I thought we were not allowed
to
> add more goog specific.

I'm out the rest of the week and won't be able to review until Monday, so feel
free to replace me with another reviewer.

[åsapersson, 2015-10-28 08:50:36]

Description was changed from

==========
Add QP stats for video receive streams to StatsReport.

BUG=
==========

to

==========
Add QP stats for video receive streams to StatsReport for tracking video
quality.

BUG=
==========

[åsapersson, 2015-10-28 12:15:32]

asapersson@webrtc.org changed reviewers:
+ hta@webrtc.org

[åsapersson, 2015-10-28 12:17:31]

Adding hta as a reviewer.

[hta-webrtc, 2015-10-29 14:50:54]

General guidance is to not add more goog* stats.
Instead, what we should do is:
- Make the case for collecting this stat
- Figure out a name we can live with if everyone implements it
- Publish a proposal for that stats value
- Implement

We don't want to promise to wait for acceptance before we implement, but we want
the proposal to be public.

I have hesitations about this one. QP is a per-frame value, and is strongly
influenced by rate control; spot-picking QP values from "the last frame that was
received before getStats was called" seems like it's collecting a number rather
than collecting something that's useful for statistics.

What's the use case that drives this proposal?

[åsapersson, 2015-11-25 08:09:20]

Description was changed from

==========
Add QP stats for video receive streams to StatsReport for tracking video
quality.

BUG=
==========

to

==========
Add QP stats for video receive streams to StatsReport for tracking video
quality.

A running average of the QP is reported.

BUG=
==========

[åsapersson, 2015-11-25 08:12:43]

Description was changed from

==========
Add QP stats for video receive streams to StatsReport for tracking video
quality.

A running average of the QP is reported.

BUG=
==========

to

==========
Add QP stats for video receive streams to StatsReport for tracking video
quality.

A running average of the QP for a received VP8 video stream  is reported. QP
range is 0-127.

BUG=
==========

[åsapersson, 2015-11-25 08:18:37]

Description was changed from

==========
Add QP stats for video receive streams to StatsReport for tracking video
quality.

A running average of the QP for a received VP8 video stream  is reported. QP
range is 0-127.

BUG=
==========

to

==========
Add QP stats for video receive streams to StatsReport for tracking video
quality.

A running average of the QP for a received VP8 video stream is reported. QP
range is 0-127.

BUG=
==========

[åsapersson, 2015-11-25 08:19:53]

Description was changed from

==========
Add QP stats for video receive streams to StatsReport for tracking video
quality.

A running average of the QP for a received VP8 video stream is reported. QP
range is 0-127.

BUG=
==========

to

==========
Add QP stats for received video streams to StatsReport for tracking video
quality.

A running average of the QP for a received VP8 video stream is reported. QP
range is 0-127.

BUG=
==========

[åsapersson, 2015-11-25 08:23:20]

Description was changed from

==========
Add QP stats for received video streams to StatsReport for tracking video
quality.

A running average of the QP for a received VP8 video stream is reported. QP
range is 0-127.

BUG=
==========

to

==========
Add QP stats for received video streams to StatsReport for tracking video
quality.

A running average of the QP (per-frame value) for a received VP8 video stream is
reported. QP range is 0-127.

BUG=
==========

[åsapersson, 2015-11-25 10:35:52]

Patchset #2 (id:60001) has been deleted

[åsapersson, 2015-11-25 11:23:33]

Patchset #2 (id:80001) has been deleted

[åsapersson, 2015-11-25 12:39:52]

On 2015/10/29 14:50:54, hta-webrtc wrote:
> General guidance is to not add more goog* stats.
> Instead, what we should do is:
> - Make the case for collecting this stat
> - Figure out a name we can live with if everyone implements it
> - Publish a proposal for that stats value
> - Implement
> 
> We don't want to promise to wait for acceptance before we implement, but we
want
> the proposal to be public.
> 
> I have hesitations about this one. QP is a per-frame value, and is strongly
> influenced by rate control; spot-picking QP values from "the last frame that
was
> received before getStats was called" seems like it's collecting a number
rather
> than collecting something that's useful for statistics.
> 
> What's the use case that drives this proposal?

I have updated the CL so a running average of the QP is reported to GetStats.

The stats would correspond to:
The quantizer value used (running average of per-frame value) for encoding the
sent video stream (the highest resolution stream is reported). The QP range is
0-127 for VP8.

The quantizer value used (running average of per-frame value) for encoding the
received video stream. The QP range is 0-127 for VP8.

[åsapersson, 2015-11-26 08:44:13]

Patchset #3 (id:120001) has been deleted

[åsapersson, 2016-05-23 09:43:30]

asapersson@webrtc.org changed reviewers:
- hta@webrtc.org, mflodman@webrtc.org, pbos@webrtc.org, perkj@webrtc.org