Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(18)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 1419803002: Rename ChannelGroup to CongestionController and move to webrtc/call/. (Closed)

Created:
5 years, 2 months ago by mflodman
Modified:
5 years, 2 months ago
Reviewers:
pbos-webrtc
CC:
webrtc-reviews_webrtc.org, yujie_mao (webrtc), stefan-webrtc, tterriberry_mozilla.com, andresp, the sun, perkj_webrtc
Base URL:
https://chromium.googlesource.com/external/webrtc.git@master
Target Ref:
refs/pending/heads/master
Project:
webrtc
Visibility:
Public.

Description

Rename ChannelGroup to CongestionController and move to webrtc/call/. BUG=webrtc:5079 R=pbos@webrtc.org Committed: https://crrev.com/0c478b3d75be3c026e68f03a11cb558c3655c926 Cr-Commit-Position: refs/heads/master@{#10358}

Patch Set 1 #

Patch Set 2 : Rebase #

Total comments: 1
Unified diffs Side-by-side diffs Delta from patch set Stats (+102 lines, -498 lines) Patch
M webrtc/call/BUILD.gn View 1 chunk +1 line, -0 lines 0 comments Download
M webrtc/call/call.cc View 1 11 chunks +24 lines, -20 lines 0 comments Download
A + webrtc/call/congestion_controller.h View 1 5 chunks +8 lines, -14 lines 1 comment Download
A + webrtc/call/congestion_controller.cc View 1 11 chunks +23 lines, -22 lines 0 comments Download
M webrtc/call/webrtc_call.gypi View 1 chunk +1 line, -0 lines 0 comments Download
M webrtc/video/BUILD.gn View 1 chunk +0 lines, -2 lines 0 comments Download
M webrtc/video/video_receive_stream.h View 1 3 chunks +3 lines, -3 lines 0 comments Download
M webrtc/video/video_receive_stream.cc View 1 4 chunks +20 lines, -15 lines 0 comments Download
M webrtc/video/video_send_stream.h View 1 3 chunks +3 lines, -3 lines 0 comments Download
M webrtc/video/video_send_stream.cc View 1 9 chunks +19 lines, -15 lines 0 comments Download
M webrtc/video/webrtc_video.gypi View 1 chunk +0 lines, -2 lines 0 comments Download
D webrtc/video_engine/vie_channel_group.h View 1 1 chunk +0 lines, -99 lines 0 comments Download
D webrtc/video_engine/vie_channel_group.cc View 1 1 chunk +0 lines, -303 lines 0 comments Download

Messages

Total messages: 6 (1 generated)
mflodman
Please take a look Peter.
5 years, 2 months ago (2015-10-21 04:16:50 UTC) #2
pbos-webrtc
lgtm https://codereview.webrtc.org/1419803002/diff/20001/webrtc/call/congestion_controller.h File webrtc/call/congestion_controller.h (right): https://codereview.webrtc.org/1419803002/diff/20001/webrtc/call/congestion_controller.h#newcode69 webrtc/call/congestion_controller.h:69: rtc::scoped_ptr<VieRemb> remb_; TODO to rename/move?
5 years, 2 months ago (2015-10-21 13:15:09 UTC) #3
mflodman
Committed patchset #2 (id:20001) manually as 0c478b3d75be3c026e68f03a11cb558c3655c926 (presubmit successful).
5 years, 2 months ago (2015-10-21 13:52:41 UTC) #4
commit-bot: I haz the power
Patchset 2 (id:??) landed as https://crrev.com/0c478b3d75be3c026e68f03a11cb558c3655c926 Cr-Commit-Position: refs/heads/master@{#10358}
5 years, 2 months ago (2015-10-21 13:52:44 UTC) #5
mflodman
5 years, 2 months ago (2015-10-21 13:53:30 UTC) #6
Message was sent while issue was closed. 
On 2015/10/21 13:15:09, pbos-webrtc wrote:
> lgtm
> 
>
https://codereview.webrtc.org/1419803002/diff/20001/webrtc/call/congestion_co...
> File webrtc/call/congestion_controller.h (right):
> 
>
https://codereview.webrtc.org/1419803002/diff/20001/webrtc/call/congestion_co...
> webrtc/call/congestion_controller.h:69: rtc::scoped_ptr<VieRemb> remb_;
> TODO to rename/move?

There's a TODO in the CC-file and I'll stick to that one for now. But I'll
follow up soon on this.

Powered by Google App Engine
This is Rietveld 408576698