Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(350)

Unified Diff: webrtc/modules/remote_bitrate_estimator/test/estimators/send_side.cc

Issue 1419503004: Set send times in send time history via OnSentPacket. (Closed) Base URL: https://chromium.googlesource.com/external/webrtc.git@master
Patch Set: Comments addressed Created 5 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: webrtc/modules/remote_bitrate_estimator/test/estimators/send_side.cc
diff --git a/webrtc/modules/remote_bitrate_estimator/test/estimators/send_side.cc b/webrtc/modules/remote_bitrate_estimator/test/estimators/send_side.cc
index 250d0c1262a5d5e4e2b1e4232d3febe034a818f8..8a7352874b4a42be2710332e1e883c5a505c5317 100644
--- a/webrtc/modules/remote_bitrate_estimator/test/estimators/send_side.cc
+++ b/webrtc/modules/remote_bitrate_estimator/test/estimators/send_side.cc
@@ -26,7 +26,7 @@ FullBweSender::FullBweSender(int kbps, BitrateObserver* observer, Clock* clock)
rbe_(new RemoteBitrateEstimatorAbsSendTime(this, clock)),
feedback_observer_(bitrate_controller_->CreateRtcpBandwidthObserver()),
clock_(clock),
- send_time_history_(10000),
+ send_time_history_(clock_, 10000),
has_received_ack_(false),
last_acked_seq_num_(0) {
assert(kbps >= kMinBitrateKbps);
@@ -92,10 +92,11 @@ void FullBweSender::OnPacketsSent(const Packets& packets) {
for (Packet* packet : packets) {
if (packet->GetPacketType() == Packet::kMedia) {
MediaPacket* media_packet = static_cast<MediaPacket*>(packet);
- PacketInfo info(0, media_packet->sender_timestamp_ms(),
- media_packet->header().sequenceNumber,
- media_packet->payload_size(), packet->paced());
- send_time_history_.AddAndRemoveOld(info);
+ send_time_history_.AddAndRemoveOld(media_packet->header().sequenceNumber,
+ media_packet->payload_size(),
+ packet->paced());
+ send_time_history_.OnSentPacket(media_packet->header().sequenceNumber,
+ media_packet->sender_timestamp_ms());
}
}
}
@@ -125,7 +126,7 @@ SendSideBweReceiver::~SendSideBweReceiver() {
void SendSideBweReceiver::ReceivePacket(int64_t arrival_time_ms,
const MediaPacket& media_packet) {
packet_feedback_vector_.push_back(PacketInfo(
- arrival_time_ms, media_packet.sender_timestamp_ms(),
+ -1, arrival_time_ms, media_packet.sender_timestamp_ms(),
media_packet.header().sequenceNumber, media_packet.payload_size(), true));
// Log received packet information.

Powered by Google App Engine
This is Rietveld 408576698