Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(179)

Issue 1419033007: Disable PhysicalSocketTest.TestUdpReadyToSendIPv4 on Android. (Closed)

Created:
5 years, 1 month ago by kjellander_webrtc
Modified:
5 years, 1 month ago
Reviewers:
pthatcher1
CC:
webrtc-reviews_webrtc.org, tterriberry_mozilla.com, pbos-webrtc
Base URL:
https://chromium.googlesource.com/external/webrtc.git@master
Target Ref:
refs/pending/heads/master
Project:
webrtc
Visibility:
Public.

Description

Disable PhysicalSocketTest.TestUdpReadyToSendIPv4 on Android. The test didn't previously run on Android bots, but was enabled by mistake in https://codereview.webrtc.org/1426643003/ It used to belong to the rtc_unittests target, which also don't run on Android unfortunately. For now, let's just disable this one test on Android to get the bots go green. BUG=4364 TBR=pthatcher@webrtc.org Committed: https://crrev.com/0be3e040f6c3bb1b725bcb8368569267ed0dd40d Cr-Commit-Position: refs/heads/master@{#10464}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+2 lines, -1 line) Patch
M webrtc/base/physicalsocketserver_unittest.cc View 1 chunk +2 lines, -1 line 0 comments Download

Messages

Total messages: 5 (2 generated)
kjellander_webrtc
Committed patchset #1 (id:1) manually as 0be3e040f6c3bb1b725bcb8368569267ed0dd40d (presubmit successful).
5 years, 1 month ago (2015-10-30 20:21:17 UTC) #1
commit-bot: I haz the power
Patchset 1 (id:??) landed as https://crrev.com/0be3e040f6c3bb1b725bcb8368569267ed0dd40d Cr-Commit-Position: refs/heads/master@{#10464}
5 years, 1 month ago (2015-10-30 20:21:18 UTC) #2
kjellander_webrtc
5 years, 1 month ago (2015-10-30 20:26:01 UTC) #4
Message was sent while issue was closed.
On 2015/10/30 20:21:18, commit-bot: I haz the power wrote:
> Patchset 1 (id:??) landed as
> https://crrev.com/0be3e040f6c3bb1b725bcb8368569267ed0dd40d
> Cr-Commit-Position: refs/heads/master@{#10464}

+pbos FYI

Powered by Google App Engine
This is Rietveld 408576698