Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(237)

Side by Side Diff: webrtc/base/physicalsocketserver_unittest.cc

Issue 1419033007: Disable PhysicalSocketTest.TestUdpReadyToSendIPv4 on Android. (Closed) Base URL: https://chromium.googlesource.com/external/webrtc.git@master
Patch Set: Created 5 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « no previous file | no next file » | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 /* 1 /*
2 * Copyright 2004 The WebRTC Project Authors. All rights reserved. 2 * Copyright 2004 The WebRTC Project Authors. All rights reserved.
3 * 3 *
4 * Use of this source code is governed by a BSD-style license 4 * Use of this source code is governed by a BSD-style license
5 * that can be found in the LICENSE file in the root of the source 5 * that can be found in the LICENSE file in the root of the source
6 * tree. An additional intellectual property rights grant can be found 6 * tree. An additional intellectual property rights grant can be found
7 * in the file PATENTS. All contributing project authors may 7 * in the file PATENTS. All contributing project authors may
8 * be found in the AUTHORS file in the root of the source tree. 8 * be found in the AUTHORS file in the root of the source tree.
9 */ 9 */
10 10
(...skipping 197 matching lines...) Expand 10 before | Expand all | Expand 10 after
208 TEST_F(PhysicalSocketTest, MAYBE_TestUdpIPv6) { 208 TEST_F(PhysicalSocketTest, MAYBE_TestUdpIPv6) {
209 SocketTest::TestUdpIPv6(); 209 SocketTest::TestUdpIPv6();
210 } 210 }
211 211
212 // Disable for TSan v2, see 212 // Disable for TSan v2, see
213 // https://code.google.com/p/webrtc/issues/detail?id=3498 for details. 213 // https://code.google.com/p/webrtc/issues/detail?id=3498 for details.
214 // Also disable for MSan, see: 214 // Also disable for MSan, see:
215 // https://code.google.com/p/webrtc/issues/detail?id=4958 215 // https://code.google.com/p/webrtc/issues/detail?id=4958
216 // TODO(deadbeef): Enable again once test is reimplemented to be unflaky. 216 // TODO(deadbeef): Enable again once test is reimplemented to be unflaky.
217 // Also disable for ASan. 217 // Also disable for ASan.
218 // Disabled on Android: https://code.google.com/p/webrtc/issues/detail?id=4364
218 #if defined(THREAD_SANITIZER) || defined(MEMORY_SANITIZER) || \ 219 #if defined(THREAD_SANITIZER) || defined(MEMORY_SANITIZER) || \
219 defined(ADDRESS_SANITIZER) 220 defined(ADDRESS_SANITIZER) || defined(WEBRTC_ANDROID)
220 #define MAYBE_TestUdpReadyToSendIPv4 DISABLED_TestUdpReadyToSendIPv4 221 #define MAYBE_TestUdpReadyToSendIPv4 DISABLED_TestUdpReadyToSendIPv4
221 #else 222 #else
222 #define MAYBE_TestUdpReadyToSendIPv4 TestUdpReadyToSendIPv4 223 #define MAYBE_TestUdpReadyToSendIPv4 TestUdpReadyToSendIPv4
223 #endif 224 #endif
224 TEST_F(PhysicalSocketTest, MAYBE_TestUdpReadyToSendIPv4) { 225 TEST_F(PhysicalSocketTest, MAYBE_TestUdpReadyToSendIPv4) {
225 SocketTest::TestUdpReadyToSendIPv4(); 226 SocketTest::TestUdpReadyToSendIPv4();
226 } 227 }
227 228
228 TEST_F(PhysicalSocketTest, TestUdpReadyToSendIPv6) { 229 TEST_F(PhysicalSocketTest, TestUdpReadyToSendIPv6) {
229 SocketTest::TestUdpReadyToSendIPv6(); 230 SocketTest::TestUdpReadyToSendIPv6();
(...skipping 126 matching lines...) Expand 10 before | Expand all | Expand 10 after
356 thread->Start(runnable.get()); 357 thread->Start(runnable.get());
357 EXPECT_TRUE(ss_->Wait(1500, true)); 358 EXPECT_TRUE(ss_->Wait(1500, true));
358 EXPECT_TRUE(ExpectSignal(SIGTERM)); 359 EXPECT_TRUE(ExpectSignal(SIGTERM));
359 EXPECT_EQ(Thread::Current(), signaled_thread_); 360 EXPECT_EQ(Thread::Current(), signaled_thread_);
360 EXPECT_TRUE(ExpectNone()); 361 EXPECT_TRUE(ExpectNone());
361 } 362 }
362 363
363 #endif 364 #endif
364 365
365 } // namespace rtc 366 } // namespace rtc
OLDNEW
« no previous file with comments | « no previous file | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698