Chromium Code Reviews
|
|
Chromium Code Reviews
Issue
1418513014:
Fix target_arch for ios devices (Closed)
DescriptionFix target_arch for ios devices
Replace armv7 by arm and arm64 in documentation for iOS build
instructions.
BUG=5125
Committed: https://crrev.com/05816eb8d7ec4fe6877339ba5b9fc6412364e436
Cr-Commit-Position: refs/heads/master@{#10761}
Patch Set 1 #
Total comments: 7
Patch Set 2 : iOS build instructions improved #Messages
Total messages: 12 (4 generated)
braveyao@webrtc.org changed reviewers: + braveyao@webrtc.org, tkchin@webrtc.org
It may be easier for me to update the file myself, but if you want to make the fixes below by all means :) https://codereview.webrtc.org/1418513014/diff/1/talk/app/webrtc/objc/README File talk/app/webrtc/objc/README (right): https://codereview.webrtc.org/1418513014/diff/1/talk/app/webrtc/objc/README#n... talk/app/webrtc/objc/README:15: export GYP_DEFINES="build_with_libjingle=1 build_with_chromium=0 libjingle_objc=1" remove libjingle_objc=1 https://codereview.webrtc.org/1418513014/diff/1/talk/app/webrtc/objc/README#n... talk/app/webrtc/objc/README:27: export GYP_DEFINES="$GYP_DEFINES target_arch=arm" wrios first then the export https://codereview.webrtc.org/1418513014/diff/1/talk/app/webrtc/objc/README#n... talk/app/webrtc/objc/README:38: export GYP_DEFINES="$GYP_DEFINES OS=ios target_arch=ia32" this might need a target_subarch=arm32 https://codereview.webrtc.org/1418513014/diff/1/talk/app/webrtc/objc/README#n... talk/app/webrtc/objc/README:45: export GYP_DEFINES="$GYP_DEFINES OS=mac target_arch=x64" this might need a target_subarch=arm64 https://codereview.webrtc.org/1418513014/diff/1/talk/app/webrtc/objc/README#n... talk/app/webrtc/objc/README:49: - Finally, run "gclient runhooks" to generate ninja files. replace gclient runhooks with "webrtc/build/gyp_webrtc", here and elsewhere https://codereview.webrtc.org/1418513014/diff/1/talk/app/webrtc/objc/README#n... talk/app/webrtc/objc/README:67: wrios32 && gclient runhooks && ninja -C out_ios/Debug-iphoneos AppRTCDemo wrios32 && webrtc/build/gyp_webrtc && ninja -C out_ios/Debug-iphoneos AppRTCDemo https://codereview.webrtc.org/1418513014/diff/1/talk/app/webrtc/objc/README#n... talk/app/webrtc/objc/README:72: - To install the sample app on an iOS device: Delete this section
The CQ bit was checked by wr.wllm@gmail.com
The CQ bit was unchecked by wr.wllm@gmail.com
On 2015/10/27 17:00:19, tkchin_webrtc wrote: > It may be easier for me to update the file myself, but if you want to make the > fixes below by all means :) > > https://codereview.webrtc.org/1418513014/diff/1/talk/app/webrtc/objc/README > File talk/app/webrtc/objc/README (right): > > https://codereview.webrtc.org/1418513014/diff/1/talk/app/webrtc/objc/README#n... > talk/app/webrtc/objc/README:15: export GYP_DEFINES="build_with_libjingle=1 > build_with_chromium=0 libjingle_objc=1" > remove libjingle_objc=1 > > https://codereview.webrtc.org/1418513014/diff/1/talk/app/webrtc/objc/README#n... > talk/app/webrtc/objc/README:27: export GYP_DEFINES="$GYP_DEFINES > target_arch=arm" > wrios first then the export > > https://codereview.webrtc.org/1418513014/diff/1/talk/app/webrtc/objc/README#n... > talk/app/webrtc/objc/README:38: export GYP_DEFINES="$GYP_DEFINES OS=ios > target_arch=ia32" > this might need a target_subarch=arm32 > > https://codereview.webrtc.org/1418513014/diff/1/talk/app/webrtc/objc/README#n... > talk/app/webrtc/objc/README:45: export GYP_DEFINES="$GYP_DEFINES OS=mac > target_arch=x64" > this might need a target_subarch=arm64 > > https://codereview.webrtc.org/1418513014/diff/1/talk/app/webrtc/objc/README#n... > talk/app/webrtc/objc/README:49: - Finally, run "gclient runhooks" to generate > ninja files. > replace gclient runhooks with "webrtc/build/gyp_webrtc", here and elsewhere > > https://codereview.webrtc.org/1418513014/diff/1/talk/app/webrtc/objc/README#n... > talk/app/webrtc/objc/README:67: wrios32 && gclient runhooks && ninja -C > out_ios/Debug-iphoneos AppRTCDemo > wrios32 && webrtc/build/gyp_webrtc && ninja -C out_ios/Debug-iphoneos AppRTCDemo > > https://codereview.webrtc.org/1418513014/diff/1/talk/app/webrtc/objc/README#n... > talk/app/webrtc/objc/README:72: - To install the sample app on an iOS device: > Delete this section Done ;)
On 2015/10/27 21:12:19, Costent wrote: > On 2015/10/27 17:00:19, tkchin_webrtc wrote: > > It may be easier for me to update the file myself, but if you want to make the > > fixes below by all means :) > > > > https://codereview.webrtc.org/1418513014/diff/1/talk/app/webrtc/objc/README > > File talk/app/webrtc/objc/README (right): > > > > > https://codereview.webrtc.org/1418513014/diff/1/talk/app/webrtc/objc/README#n... > > talk/app/webrtc/objc/README:15: export GYP_DEFINES="build_with_libjingle=1 > > build_with_chromium=0 libjingle_objc=1" > > remove libjingle_objc=1 > > > > > https://codereview.webrtc.org/1418513014/diff/1/talk/app/webrtc/objc/README#n... > > talk/app/webrtc/objc/README:27: export GYP_DEFINES="$GYP_DEFINES > > target_arch=arm" > > wrios first then the export > > > > > https://codereview.webrtc.org/1418513014/diff/1/talk/app/webrtc/objc/README#n... > > talk/app/webrtc/objc/README:38: export GYP_DEFINES="$GYP_DEFINES OS=ios > > target_arch=ia32" > > this might need a target_subarch=arm32 > > > > > https://codereview.webrtc.org/1418513014/diff/1/talk/app/webrtc/objc/README#n... > > talk/app/webrtc/objc/README:45: export GYP_DEFINES="$GYP_DEFINES OS=mac > > target_arch=x64" > > this might need a target_subarch=arm64 > > > > > https://codereview.webrtc.org/1418513014/diff/1/talk/app/webrtc/objc/README#n... > > talk/app/webrtc/objc/README:49: - Finally, run "gclient runhooks" to generate > > ninja files. > > replace gclient runhooks with "webrtc/build/gyp_webrtc", here and elsewhere > > > > > https://codereview.webrtc.org/1418513014/diff/1/talk/app/webrtc/objc/README#n... > > talk/app/webrtc/objc/README:67: wrios32 && gclient runhooks && ninja -C > > out_ios/Debug-iphoneos AppRTCDemo > > wrios32 && webrtc/build/gyp_webrtc && ninja -C out_ios/Debug-iphoneos > AppRTCDemo > > > > > https://codereview.webrtc.org/1418513014/diff/1/talk/app/webrtc/objc/README#n... > > talk/app/webrtc/objc/README:72: - To install the sample app on an iOS device: > > Delete this section > > Done ;) lgtm but can you sign the CLA please? We need that before we can submit this patch. https://cla.developers.google.com/clas
On 2015/11/16 21:43:23, tkchin_webrtc wrote: > On 2015/10/27 21:12:19, Costent wrote: > > On 2015/10/27 17:00:19, tkchin_webrtc wrote: > > > It may be easier for me to update the file myself, but if you want to make > the > > > fixes below by all means :) > > > > > > https://codereview.webrtc.org/1418513014/diff/1/talk/app/webrtc/objc/README > > > File talk/app/webrtc/objc/README (right): > > > > > > > > > https://codereview.webrtc.org/1418513014/diff/1/talk/app/webrtc/objc/README#n... > > > talk/app/webrtc/objc/README:15: export GYP_DEFINES="build_with_libjingle=1 > > > build_with_chromium=0 libjingle_objc=1" > > > remove libjingle_objc=1 > > > > > > > > > https://codereview.webrtc.org/1418513014/diff/1/talk/app/webrtc/objc/README#n... > > > talk/app/webrtc/objc/README:27: export GYP_DEFINES="$GYP_DEFINES > > > target_arch=arm" > > > wrios first then the export > > > > > > > > > https://codereview.webrtc.org/1418513014/diff/1/talk/app/webrtc/objc/README#n... > > > talk/app/webrtc/objc/README:38: export GYP_DEFINES="$GYP_DEFINES OS=ios > > > target_arch=ia32" > > > this might need a target_subarch=arm32 > > > > > > > > > https://codereview.webrtc.org/1418513014/diff/1/talk/app/webrtc/objc/README#n... > > > talk/app/webrtc/objc/README:45: export GYP_DEFINES="$GYP_DEFINES OS=mac > > > target_arch=x64" > > > this might need a target_subarch=arm64 > > > > > > > > > https://codereview.webrtc.org/1418513014/diff/1/talk/app/webrtc/objc/README#n... > > > talk/app/webrtc/objc/README:49: - Finally, run "gclient runhooks" to > generate > > > ninja files. > > > replace gclient runhooks with "webrtc/build/gyp_webrtc", here and elsewhere > > > > > > > > > https://codereview.webrtc.org/1418513014/diff/1/talk/app/webrtc/objc/README#n... > > > talk/app/webrtc/objc/README:67: wrios32 && gclient runhooks && ninja -C > > > out_ios/Debug-iphoneos AppRTCDemo > > > wrios32 && webrtc/build/gyp_webrtc && ninja -C out_ios/Debug-iphoneos > > AppRTCDemo > > > > > > > > > https://codereview.webrtc.org/1418513014/diff/1/talk/app/webrtc/objc/README#n... > > > talk/app/webrtc/objc/README:72: - To install the sample app on an iOS > device: > > > Delete this section > > > > Done ;) > > lgtm but can you sign the CLA please? We need that before we can submit this > patch. > https://cla.developers.google.com/clas Done ;)
The CQ bit was checked by tkchin@webrtc.org
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1418513014/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1418513014/20001
Message was sent while issue was closed.
Committed patchset #2 (id:20001)
Message was sent while issue was closed.
Patchset 2 (id:??) landed as https://crrev.com/05816eb8d7ec4fe6877339ba5b9fc6412364e436 Cr-Commit-Position: refs/heads/master@{#10761} |
