Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(848)

Unified Diff: talk/session/media/mediasession.cc

Issue 1418123003: Adding reduced size RTCP configuration down to the video stream level. (Closed) Base URL: https://chromium.googlesource.com/external/webrtc.git@master
Patch Set: Created 5 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: talk/session/media/mediasession.cc
diff --git a/talk/session/media/mediasession.cc b/talk/session/media/mediasession.cc
index 2cd2d46d9ca5adbf28f61a83b7b501354a99be75..4ef846fcd7d4246e11c9e02308b4e3969a4fa675 100644
--- a/talk/session/media/mediasession.cc
+++ b/talk/session/media/mediasession.cc
@@ -726,6 +726,8 @@ static bool CreateMediaContentOffer(
offer->set_crypto_required(CT_SDES);
}
offer->set_rtcp_mux(options.rtcp_mux_enabled);
+ // TODO(pthatcher): Once we support this, enable it in CreateOffer.
+ // offer->set_rtcp_reduced_size(true);
pthatcher1 2015/10/23 20:40:01 If we fix VideoSendStream::SignalNetworkState, I t
Taylor Brandstetter 2015/11/11 19:42:40 I'll go with the latter option and change this to
offer->set_multistream(options.is_muc);
offer->set_rtp_header_extensions(rtp_extensions);
@@ -1004,6 +1006,8 @@ static bool CreateMediaContentAnswer(
answer->set_rtp_header_extensions(negotiated_rtp_extensions);
answer->set_rtcp_mux(options.rtcp_mux_enabled && offer->rtcp_mux());
+ // TODO(pthatcher): Once we support this, enable it in CreateOffer.
+ // answer->set_rtcp_reduced_size(offer->rtcp_reduced_size());
if (sdes_policy != SEC_DISABLED) {
CryptoParams crypto;

Powered by Google App Engine
This is Rietveld 408576698