Adding reduced size RTCP configuration down to the video stream level.

talk/session/media/mediasession.cc

 /*
  * libjingle
  * Copyright 2004 Google Inc.
  *
  * Redistribution and use in source and binary forms, with or without
  * modification, are permitted provided that the following conditions are met:
  *
  *  1. Redistributions of source code must retain the above copyright notice,
  *     this list of conditions and the following disclaimer.
  *  2. Redistributions in binary form must reproduce the above copyright notice,
@@ skipping 708 matching lines @@
     bool add_legacy_stream,
     StreamParamsVec* current_streams,
     MediaContentDescriptionImpl<C>* offer) {
   offer->AddCodecs(codecs);
   offer->SortCodecs();
 
   if (secure_policy == SEC_REQUIRED) {
     offer->set_crypto_required(CT_SDES);
   }
   offer->set_rtcp_mux(options.rtcp_mux_enabled);
+  // TODO(pthatcher): Once we support this, enable it in CreateOffer.
+  // offer->set_rtcp_reduced_size(true);

[pthatcher1, 2015/10/23 20:40:01]

If we fix VideoSendStream::SignalNetworkState, I think we can offer it.  But
someone will need to be on the hook for making sure that it works correctly.  So
it might make sense to submit this CL without it offering and then ask someone
else to enable it when they feel like supporting it (pbos might be the right
person for that).

[Taylor Brandstetter, 2015/11/11 19:42:40]

I'll go with the latter option and change this to TODO(pbos). When I uncomment
these lines, I see the "reduced" configuration propagated to the RTCPSender, but
I don't see any reduced size packets. So maybe there's still work to be done?

   offer->set_multistream(options.is_muc);
   offer->set_rtp_header_extensions(rtp_extensions);
 
   if (!AddStreamParams(
           offer->type(), options.streams, current_streams,
           offer, add_legacy_stream)) {
     return false;
   }
 
 #ifdef HAVE_SRTP
@@ skipping 258 matching lines @@
   answer->AddCodecs(negotiated_codecs);
   answer->SortCodecs();
   answer->set_protocol(offer->protocol());
   RtpHeaderExtensions negotiated_rtp_extensions;
   NegotiateRtpHeaderExtensions(local_rtp_extenstions,
                                offer->rtp_header_extensions(),
                                &negotiated_rtp_extensions);
   answer->set_rtp_header_extensions(negotiated_rtp_extensions);
 
   answer->set_rtcp_mux(options.rtcp_mux_enabled && offer->rtcp_mux());
+  // TODO(pthatcher): Once we support this, enable it in CreateOffer.
+  // answer->set_rtcp_reduced_size(offer->rtcp_reduced_size());
 
   if (sdes_policy != SEC_DISABLED) {
     CryptoParams crypto;
     if (SelectCrypto(offer, bundle_enabled, &crypto)) {
       if (current_cryptos) {
         FindMatchingCrypto(*current_cryptos, crypto, &crypto);
       }
       answer->AddCrypto(crypto);
     }
   }
@@ skipping 884 matching lines @@
       GetFirstMediaContentDescription(sdesc, MEDIA_TYPE_VIDEO));
 }
 
 const DataContentDescription* GetFirstDataContentDescription(
     const SessionDescription* sdesc) {
   return static_cast<const DataContentDescription*>(
       GetFirstMediaContentDescription(sdesc, MEDIA_TYPE_DATA));
 }
 
 }  // namespace cricket