Handle iOS devices with no rear-facing camera

Handle iOS devices with no rear-facing camera

Devices exist (specifically the 16GB 5th generation iPod Touch) that do not have
a rear-facing camera.

This CL:
- Adjusts RTCAVFoundationVideoCapturerInternal so initialization doesn't fail
because a rear-facing camera doesn't exist, but still logs a warning
- Provides a check for whether or not a rear-facing camera can be used (useful
for toggling UI elements)
- Turns an attempt to switch to the rear-facing camera into a no-op with a
warning.

BUG=

Committed: https://crrev.com/a1cf366ea9ad5e47240c2a9ba7041c293fc6e84d
Cr-Commit-Position: refs/heads/master@{#11992}

[hjon, 2015-10-22 22:30:36]

hjon@andyet.net changed reviewers:
+ tkchin@webrtc.org

[hjon, 2015-10-22 22:30:36]

Proposed changes to handle iOS devices with no rear-facing camera while not
adding much additional work for developers.

(Moved over from https://webrtc-codereview.appspot.com/52579004/)

[tkchin_webrtc, 2016-03-14 18:16:59]

https://codereview.webrtc.org/1416303003/diff/20001/talk/app/webrtc/objc/avfo...
File talk/app/webrtc/objc/avfoundationvideocapturer.mm (right):

https://codereview.webrtc.org/1416303003/diff/20001/talk/app/webrtc/objc/avfo...
talk/app/webrtc/objc/avfoundationvideocapturer.mm:56: @property(nonatomic,
readonly) BOOL canUseBackCamera;
nit: move above useBackCamera

https://codereview.webrtc.org/1416303003/diff/20001/talk/app/webrtc/objc/avfo...
talk/app/webrtc/objc/avfoundationvideocapturer.mm:118: NSLog(@"No rear-facing
camera exists or it cannot be used; not switching.");
import webrtc/base/RTCLogging and use RTCLog
here and elsewhere in file

https://codereview.webrtc.org/1416303003/diff/20001/talk/app/webrtc/objc/avfo...
talk/app/webrtc/objc/avfoundationvideocapturer.mm:243: error = nil;
nil out error before _backDeviceInput = [AVCap.. instead. (So we keep around old
errors until we need to reuse the local var)

https://codereview.webrtc.org/1416303003/diff/20001/talk/app/webrtc/objc/publ...
File talk/app/webrtc/objc/public/RTCAVFoundationVideoSource.h (right):

https://codereview.webrtc.org/1416303003/diff/20001/talk/app/webrtc/objc/publ...
talk/app/webrtc/objc/public/RTCAVFoundationVideoSource.h:48: // Returns whether
rear-facing camera is available for use.
nit: Move this above useBackCamera

https://codereview.webrtc.org/1416303003/diff/20001/webrtc/api/objc/RTCAVFoun...
File webrtc/api/objc/RTCAVFoundationVideoSource.h (right):

https://codereview.webrtc.org/1416303003/diff/20001/webrtc/api/objc/RTCAVFoun...
webrtc/api/objc/RTCAVFoundationVideoSource.h:37: /** Returns whether rear-facing
camera is available for use. */
ditto move above

[hjon, 2016-03-14 18:31:44]

ptal

https://codereview.webrtc.org/1416303003/diff/20001/talk/app/webrtc/objc/avfo...
File talk/app/webrtc/objc/avfoundationvideocapturer.mm (right):

https://codereview.webrtc.org/1416303003/diff/20001/talk/app/webrtc/objc/avfo...
talk/app/webrtc/objc/avfoundationvideocapturer.mm:56: @property(nonatomic,
readonly) BOOL canUseBackCamera;
On 2016/03/14 18:16:59, tkchin_webrtc wrote:
> nit: move above useBackCamera

Done.

https://codereview.webrtc.org/1416303003/diff/20001/talk/app/webrtc/objc/avfo...
talk/app/webrtc/objc/avfoundationvideocapturer.mm:118: NSLog(@"No rear-facing
camera exists or it cannot be used; not switching.");
On 2016/03/14 18:16:59, tkchin_webrtc wrote:
> import webrtc/base/RTCLogging and use RTCLog
> here and elsewhere in file

Done.

https://codereview.webrtc.org/1416303003/diff/20001/talk/app/webrtc/objc/avfo...
talk/app/webrtc/objc/avfoundationvideocapturer.mm:243: error = nil;
On 2016/03/14 18:16:59, tkchin_webrtc wrote:
> nil out error before _backDeviceInput = [AVCap.. instead. (So we keep around
old
> errors until we need to reuse the local var)
> 

Done.

https://codereview.webrtc.org/1416303003/diff/20001/talk/app/webrtc/objc/publ...
File talk/app/webrtc/objc/public/RTCAVFoundationVideoSource.h (right):

https://codereview.webrtc.org/1416303003/diff/20001/talk/app/webrtc/objc/publ...
talk/app/webrtc/objc/public/RTCAVFoundationVideoSource.h:48: // Returns whether
rear-facing camera is available for use.
On 2016/03/14 18:16:59, tkchin_webrtc wrote:
> nit: Move this above useBackCamera

Done.

https://codereview.webrtc.org/1416303003/diff/20001/webrtc/api/objc/RTCAVFoun...
File webrtc/api/objc/RTCAVFoundationVideoSource.h (right):

https://codereview.webrtc.org/1416303003/diff/20001/webrtc/api/objc/RTCAVFoun...
webrtc/api/objc/RTCAVFoundationVideoSource.h:37: /** Returns whether rear-facing
camera is available for use. */
On 2016/03/14 18:16:59, tkchin_webrtc wrote:
> ditto move above

Done.

[tkchin_webrtc, 2016-03-14 19:16:37]

lgtm

[hjon_webrtc, 2016-03-14 22:13:31]

The CQ bit was checked by hjon@webrtc.org

[commit-bot: I haz the power, 2016-03-14 22:13:34]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1416303003/40001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1416303003/40001

[commit-bot: I haz the power, 2016-03-15 00:13:56]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-03-15 00:13:57]

Try jobs failed on following builders:
  android_arm64_rel on tryserver.webrtc (JOB_TIMED_OUT, no build URL)
  win_baremetal on tryserver.webrtc (JOB_TIMED_OUT, no build URL)

[hjon_webrtc, 2016-03-15 03:23:00]

The CQ bit was checked by hjon@webrtc.org

[commit-bot: I haz the power, 2016-03-15 03:23:11]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1416303003/40001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1416303003/40001

[commit-bot: I haz the power, 2016-03-15 03:55:31]

Committed patchset #3 (id:40001)

[commit-bot: I haz the power, 2016-03-15 03:55:33]

Description was changed from

==========
Handle iOS devices with no rear-facing camera

Devices exist (specifically the 16GB 5th generation iPod Touch) that do not have
a rear-facing camera.

This CL:
- Adjusts RTCAVFoundationVideoCapturerInternal so initialization doesn't fail
because a rear-facing camera doesn't exist, but still logs a warning
- Provides a check for whether or not a rear-facing camera can be used (useful
for toggling UI elements)
- Turns an attempt to switch to the rear-facing camera into a no-op with a
warning.

BUG=
==========

to

==========
Handle iOS devices with no rear-facing camera

Devices exist (specifically the 16GB 5th generation iPod Touch) that do not have
a rear-facing camera.

This CL:
- Adjusts RTCAVFoundationVideoCapturerInternal so initialization doesn't fail
because a rear-facing camera doesn't exist, but still logs a warning
- Provides a check for whether or not a rear-facing camera can be used (useful
for toggling UI elements)
- Turns an attempt to switch to the rear-facing camera into a no-op with a
warning.

BUG=

Committed: https://crrev.com/a1cf366ea9ad5e47240c2a9ba7041c293fc6e84d
Cr-Commit-Position: refs/heads/master@{#11992}
==========

[commit-bot: I haz the power, 2016-03-15 03:55:34]

Patchset 3 (id:??) landed as
https://crrev.com/a1cf366ea9ad5e47240c2a9ba7041c293fc6e84d
Cr-Commit-Position: refs/heads/master@{#11992}