Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(164)

Unified Diff: talk/app/webrtc/objc/avfoundationvideocapturer.mm

Issue 1416303003: Handle iOS devices with no rear-facing camera (Closed) Base URL: https://chromium.googlesource.com/external/webrtc.git@master
Patch Set: Changes based on feedback Created 4 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: talk/app/webrtc/objc/avfoundationvideocapturer.mm
diff --git a/talk/app/webrtc/objc/avfoundationvideocapturer.mm b/talk/app/webrtc/objc/avfoundationvideocapturer.mm
index 0f9dc6825e9135461a6d8d8c5ad713c00c2c01b3..f9845901897a17801ba1ca5bba4efcef39f0d927 100644
--- a/talk/app/webrtc/objc/avfoundationvideocapturer.mm
+++ b/talk/app/webrtc/objc/avfoundationvideocapturer.mm
@@ -34,6 +34,7 @@
#import <UIKit/UIKit.h>
#import "webrtc/base/objc/RTCDispatcher.h"
+#import "webrtc/base/objc/RTCLogging.h"
// TODO(tkchin): support other formats.
static NSString* const kDefaultPreset = AVCaptureSessionPreset640x480;
@@ -52,6 +53,7 @@ static cricket::VideoFormat const kDefaultFormat =
@property(nonatomic, readonly) AVCaptureSession* captureSession;
@property(nonatomic, readonly) BOOL isRunning;
+@property(nonatomic, readonly) BOOL canUseBackCamera;
@property(nonatomic, assign) BOOL useBackCamera; // Defaults to NO.
// We keep a pointer back to AVFoundationVideoCapturer to make callbacks on it
@@ -105,10 +107,19 @@ static cricket::VideoFormat const kDefaultFormat =
_capturer = nullptr;
}
+- (BOOL)canUseBackCamera {
+ return _backDeviceInput != nil;
+}
+
- (void)setUseBackCamera:(BOOL)useBackCamera {
if (_useBackCamera == useBackCamera) {
return;
}
+ if (!self.canUseBackCamera) {
+ RTCLog(@"No rear-facing camera exists or it cannot be used;"
+ "not switching.");
+ return;
+ }
_useBackCamera = useBackCamera;
[self updateSessionInput];
}
@@ -203,10 +214,15 @@ static cricket::VideoFormat const kDefaultFormat =
frontCaptureDevice = captureDevice;
}
}
- if (!frontCaptureDevice || !backCaptureDevice) {
- NSLog(@"Failed to get capture devices.");
+ if (!frontCaptureDevice) {
+ RTCLog(@"Failed to get front capture device.");
return NO;
}
+ if (!backCaptureDevice) {
+ RTCLog(@"Failed to get back capture device");
+ // Don't return NO here because devices exist (16GB 5th generation iPod
+ // Touch) that don't have a rear-facing camera.
+ }
// Set up the session inputs.
NSError* error = nil;
@@ -218,18 +234,21 @@ static cricket::VideoFormat const kDefaultFormat =
error.localizedDescription);
return NO;
}
- _backDeviceInput =
- [AVCaptureDeviceInput deviceInputWithDevice:backCaptureDevice
- error:&error];
- if (!_backDeviceInput) {
- NSLog(@"Failed to get capture device input: %@",
- error.localizedDescription);
- return NO;
+ if (backCaptureDevice) {
+ error = nil;
+ _backDeviceInput =
+ [AVCaptureDeviceInput deviceInputWithDevice:backCaptureDevice
+ error:&error];
+ if (error) {
+ RTCLog(@"Failed to get capture device input: %@",
+ error.localizedDescription);
+ _backDeviceInput = nil;
+ }
}
// Add the inputs.
if (![_captureSession canAddInput:_frontDeviceInput] ||
- ![_captureSession canAddInput:_backDeviceInput]) {
+ (_backDeviceInput && ![_captureSession canAddInput:_backDeviceInput])) {
NSLog(@"Session does not support capture inputs.");
return NO;
}
@@ -353,6 +372,10 @@ AVCaptureSession* AVFoundationVideoCapturer::GetCaptureSession() {
return _capturer.captureSession;
}
+bool AVFoundationVideoCapturer::CanUseBackCamera() const {
+ return _capturer.canUseBackCamera;
+}
+
void AVFoundationVideoCapturer::SetUseBackCamera(bool useBackCamera) {
_capturer.useBackCamera = useBackCamera;
}
« no previous file with comments | « talk/app/webrtc/objc/avfoundationvideocapturer.h ('k') | talk/app/webrtc/objc/public/RTCAVFoundationVideoSource.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698