Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(34)

Issue 1415693002: Remove VideoFrameType aliases for FrameType. (Closed)

Created:
5 years, 2 months ago by pbos-webrtc
Modified:
5 years, 2 months ago
Reviewers:
magjed_webrtc, mflodman
CC:
webrtc-reviews_webrtc.org, interface-changes_webrtc.org, rwolff_gocast.it, yujie_mao (webrtc), Andrew MacDonald, stefan-webrtc, tterriberry_mozilla.com, qiang.lu, niklas.enbom, andresp, peah-webrtc, the sun, perkj_webrtc, mflodman
Base URL:
https://chromium.googlesource.com/external/webrtc.git@master
Target Ref:
refs/pending/heads/master
Project:
webrtc
Visibility:
Public.

Description

Remove VideoFrameType aliases for FrameType. No longer used in Chromium, so these can now be removed. BUG=webrtc:5042 R=mflodman@webrtc.org TBR=magjed@webrtc.org Committed: https://crrev.com/49e196af4060624d620297a6bc017699daa33550 Cr-Commit-Position: refs/heads/master@{#10390}

Patch Set 1 #

Patch Set 2 : rebase #

Unified diffs Side-by-side diffs Delta from patch set Stats (+111 lines, -106 lines) Patch
M talk/app/webrtc/java/jni/androidmediadecoder_jni.cc View 1 1 chunk +1 line, -1 line 0 comments Download
M talk/app/webrtc/java/jni/androidmediaencoder_jni.cc View 1 2 chunks +3 lines, -2 lines 0 comments Download
M webrtc/common_types.h View 1 chunk +0 lines, -8 lines 0 comments Download
M webrtc/modules/video_coding/codecs/h264/h264_video_toolbox_encoder.cc View 2 chunks +3 lines, -2 lines 0 comments Download
M webrtc/modules/video_coding/codecs/i420/i420.cc View 1 1 chunk +1 line, -1 line 0 comments Download
M webrtc/modules/video_coding/codecs/test/stats.cc View 2 chunks +2 lines, -2 lines 0 comments Download
M webrtc/modules/video_coding/codecs/test/videoprocessor.cc View 3 chunks +5 lines, -5 lines 0 comments Download
M webrtc/modules/video_coding/codecs/test/videoprocessor_integrationtest.cc View 1 2 chunks +2 lines, -2 lines 0 comments Download
M webrtc/modules/video_coding/codecs/tools/video_quality_measurement.cc View 1 chunk +1 line, -1 line 0 comments Download
M webrtc/modules/video_coding/codecs/vp8/simulcast_encoder_adapter.cc View 2 chunks +3 lines, -3 lines 0 comments Download
M webrtc/modules/video_coding/codecs/vp8/simulcast_unittest.h View 13 chunks +57 lines, -47 lines 0 comments Download
M webrtc/modules/video_coding/codecs/vp8/test/vp8_impl_unittest.cc View 2 chunks +3 lines, -3 lines 0 comments Download
M webrtc/modules/video_coding/codecs/vp8/vp8_impl.cc View 1 7 chunks +8 lines, -7 lines 0 comments Download
M webrtc/modules/video_coding/codecs/vp9/vp9_impl.cc View 1 5 chunks +5 lines, -5 lines 0 comments Download
M webrtc/modules/video_coding/main/source/encoded_frame.cc View 1 chunk +1 line, -1 line 0 comments Download
M webrtc/modules/video_coding/main/source/media_optimization.cc View 1 chunk +1 line, -1 line 0 comments Download
M webrtc/modules/video_coding/main/source/media_optimization_unittest.cc View 1 chunk +1 line, -1 line 0 comments Download
M webrtc/modules/video_coding/main/source/video_sender_unittest.cc View 1 chunk +6 lines, -6 lines 0 comments Download
M webrtc/test/configurable_frame_size_encoder.cc View 1 chunk +1 line, -1 line 0 comments Download
M webrtc/video/send_statistics_proxy.cc View 1 1 chunk +1 line, -1 line 0 comments Download
M webrtc/video/video_decoder.cc View 1 chunk +1 line, -1 line 0 comments Download
M webrtc/video/video_decoder_unittest.cc View 1 chunk +2 lines, -2 lines 0 comments Download
M webrtc/video/video_encoder_unittest.cc View 1 2 chunks +2 lines, -2 lines 0 comments Download
M webrtc/video_frame.h View 1 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 8 (2 generated)
pbos-webrtc
PTAL, won't commit before Chromium change lands.
5 years, 2 months ago (2015-10-19 17:54:53 UTC) #1
pbos-webrtc
(Chromium change landed, ping :))
5 years, 2 months ago (2015-10-21 15:40:20 UTC) #2
mflodman
LGTM
5 years, 2 months ago (2015-10-22 06:48:46 UTC) #3
pbos-webrtc
TBR=magjed@ for talk/app/webrtc/java/jni/
5 years, 2 months ago (2015-10-23 13:57:59 UTC) #6
pbos-webrtc
Committed patchset #2 (id:20001) manually as 49e196af4060624d620297a6bc017699daa33550 (presubmit successful).
5 years, 2 months ago (2015-10-23 13:58:31 UTC) #7
commit-bot: I haz the power
5 years, 2 months ago (2015-10-23 13:58:36 UTC) #8
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/49e196af4060624d620297a6bc017699daa33550
Cr-Commit-Position: refs/heads/master@{#10390}

Powered by Google App Engine
This is Rietveld 408576698