Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(70)

Side by Side Diff: webrtc/video/video_decoder_unittest.cc

Issue 1415693002: Remove VideoFrameType aliases for FrameType. (Closed) Base URL: https://chromium.googlesource.com/external/webrtc.git@master
Patch Set: rebase Created 5 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « webrtc/video/video_decoder.cc ('k') | webrtc/video/video_encoder_unittest.cc » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 /* 1 /*
2 * Copyright (c) 2015 The WebRTC project authors. All Rights Reserved. 2 * Copyright (c) 2015 The WebRTC project authors. All Rights Reserved.
3 * 3 *
4 * Use of this source code is governed by a BSD-style license 4 * Use of this source code is governed by a BSD-style license
5 * that can be found in the LICENSE file in the root of the source 5 * that can be found in the LICENSE file in the root of the source
6 * tree. An additional intellectual property rights grant can be found 6 * tree. An additional intellectual property rights grant can be found
7 * in the file PATENTS. All contributing project authors may 7 * in the file PATENTS. All contributing project authors may
8 * be found in the AUTHORS file in the root of the source tree. 8 * be found in the AUTHORS file in the root of the source tree.
9 */ 9 */
10 10
(...skipping 68 matching lines...) Expand 10 before | Expand all | Expand 10 after
79 EncodedImage encoded_image; 79 EncodedImage encoded_image;
80 fallback_wrapper_.Decode(encoded_image, false, nullptr, nullptr, -1); 80 fallback_wrapper_.Decode(encoded_image, false, nullptr, nullptr, -1);
81 EXPECT_EQ(1, fake_decoder_.decode_count_); 81 EXPECT_EQ(1, fake_decoder_.decode_count_);
82 82
83 // Fail -> fake_decoder shouldn't be used anymore. 83 // Fail -> fake_decoder shouldn't be used anymore.
84 fallback_wrapper_.Decode(encoded_image, false, nullptr, nullptr, -1); 84 fallback_wrapper_.Decode(encoded_image, false, nullptr, nullptr, -1);
85 EXPECT_EQ(1, fake_decoder_.decode_count_) 85 EXPECT_EQ(1, fake_decoder_.decode_count_)
86 << "Decoder used even though fallback should be active."; 86 << "Decoder used even though fallback should be active.";
87 87
88 // Should be able to recover on a keyframe. 88 // Should be able to recover on a keyframe.
89 encoded_image._frameType = kKeyFrame; 89 encoded_image._frameType = kVideoFrameKey;
90 fake_decoder_.decode_return_code_ = WEBRTC_VIDEO_CODEC_OK; 90 fake_decoder_.decode_return_code_ = WEBRTC_VIDEO_CODEC_OK;
91 fallback_wrapper_.Decode(encoded_image, false, nullptr, nullptr, -1); 91 fallback_wrapper_.Decode(encoded_image, false, nullptr, nullptr, -1);
92 EXPECT_EQ(2, fake_decoder_.decode_count_) 92 EXPECT_EQ(2, fake_decoder_.decode_count_)
93 << "Wrapper did not try to decode a keyframe using registered decoder."; 93 << "Wrapper did not try to decode a keyframe using registered decoder.";
94 94
95 encoded_image._frameType = kDeltaFrame; 95 encoded_image._frameType = kVideoFrameDelta;
96 fallback_wrapper_.Decode(encoded_image, false, nullptr, nullptr, -1); 96 fallback_wrapper_.Decode(encoded_image, false, nullptr, nullptr, -1);
97 EXPECT_EQ(3, fake_decoder_.decode_count_) 97 EXPECT_EQ(3, fake_decoder_.decode_count_)
98 << "Decoder not used on future delta frames."; 98 << "Decoder not used on future delta frames.";
99 } 99 }
100 100
101 TEST_F(VideoDecoderSoftwareFallbackWrapperTest, DoesNotFallbackOnEveryError) { 101 TEST_F(VideoDecoderSoftwareFallbackWrapperTest, DoesNotFallbackOnEveryError) {
102 VideoCodec codec = {}; 102 VideoCodec codec = {};
103 fallback_wrapper_.InitDecode(&codec, 2); 103 fallback_wrapper_.InitDecode(&codec, 2);
104 fake_decoder_.decode_return_code_ = WEBRTC_VIDEO_CODEC_ERROR; 104 fake_decoder_.decode_return_code_ = WEBRTC_VIDEO_CODEC_ERROR;
105 EncodedImage encoded_image; 105 EncodedImage encoded_image;
(...skipping 50 matching lines...) Expand 10 before | Expand all | Expand 10 after
156 EXPECT_EQ(&callback, fake_decoder_.decode_complete_callback_); 156 EXPECT_EQ(&callback, fake_decoder_.decode_complete_callback_);
157 157
158 fake_decoder_.decode_return_code_ = WEBRTC_VIDEO_CODEC_FALLBACK_SOFTWARE; 158 fake_decoder_.decode_return_code_ = WEBRTC_VIDEO_CODEC_FALLBACK_SOFTWARE;
159 EncodedImage encoded_image; 159 EncodedImage encoded_image;
160 fallback_wrapper_.Decode(encoded_image, false, nullptr, nullptr, -1); 160 fallback_wrapper_.Decode(encoded_image, false, nullptr, nullptr, -1);
161 fallback_wrapper_.RegisterDecodeCompleteCallback(&callback2); 161 fallback_wrapper_.RegisterDecodeCompleteCallback(&callback2);
162 EXPECT_EQ(&callback2, fake_decoder_.decode_complete_callback_); 162 EXPECT_EQ(&callback2, fake_decoder_.decode_complete_callback_);
163 } 163 }
164 164
165 } // namespace webrtc 165 } // namespace webrtc
OLDNEW
« no previous file with comments | « webrtc/video/video_decoder.cc ('k') | webrtc/video/video_encoder_unittest.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698