Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(374)

Issue 1414853009: Add icu as a dependency on Android. (Closed)

Created:
5 years, 1 month ago by kjellander_webrtc
Modified:
5 years, 1 month ago
Reviewers:
pbos-webrtc
CC:
webrtc-reviews_webrtc.org, qiang.lu, niklas.enbom, yujie_mao (webrtc), peah-webrtc, Andrew MacDonald
Base URL:
https://chromium.googlesource.com/external/webrtc.git@master
Target Ref:
refs/pending/heads/master
Project:
webrtc
Visibility:
Public.

Description

Add icu as a dependency on Android. Turns out ICU is referenced by //base/test/BUILD.gn which is loaded when we generate projects with GN for Android. This adds ICU back for Android only (was removed in https://codereview.webrtc.org/1417563006). TBR=pbos@webrtc.org NOTRY=true Committed: https://crrev.com/5376100d00f23f27b2640343136be70da895f8ff Cr-Commit-Position: refs/heads/master@{#10587}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+2 lines, -0 lines) Patch
M .gitignore View 1 chunk +1 line, -0 lines 0 comments Download
M setup_links.py View 1 chunk +1 line, -0 lines 0 comments Download

Messages

Total messages: 7 (2 generated)
kjellander_webrtc
5 years, 1 month ago (2015-11-10 18:56:17 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1414853009/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1414853009/1
5 years, 1 month ago (2015-11-10 18:56:24 UTC) #4
pbos-webrtc
lgtm
5 years, 1 month ago (2015-11-10 18:56:45 UTC) #5
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 1 month ago (2015-11-10 18:58:27 UTC) #6
commit-bot: I haz the power
5 years, 1 month ago (2015-11-10 18:58:37 UTC) #7
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/5376100d00f23f27b2640343136be70da895f8ff
Cr-Commit-Position: refs/heads/master@{#10587}

Powered by Google App Engine
This is Rietveld 408576698