Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(568)

Issue 1417563006: Remove icu as a dependency (Closed)

Created:
5 years, 1 month ago by kjellander_webrtc
Modified:
5 years, 1 month ago
Reviewers:
phoglund
CC:
webrtc-reviews_webrtc.org, qiang.lu, niklas.enbom, yujie_mao (webrtc), peah-webrtc, Andrew MacDonald
Base URL:
https://chromium.googlesource.com/external/webrtc.git@master
Target Ref:
refs/pending/heads/master
Project:
webrtc
Visibility:
Public.

Description

Remove icu as a dependency In https://codereview.webrtc.org/1430023005 all the code references to ICU were removed. This actually removes the library from being referenced. TESTED=git cl try -c --bot=win_compile_rel --bot=linux_compile_rel --bot=android_compile_rel --bot=mac_compile_rel --bot=ios_rel -m tryserver.webrtc R=phoglund@webrtc.org Committed: https://crrev.com/a34bb2a78c713e5b9e2224bf7f793d140b0ca608 Cr-Commit-Position: refs/heads/master@{#10584}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+0 lines, -2 lines) Patch
M .gitignore View 1 chunk +0 lines, -1 line 0 comments Download
M setup_links.py View 1 chunk +0 lines, -1 line 0 comments Download

Messages

Total messages: 6 (2 generated)
kjellander_webrtc
5 years, 1 month ago (2015-11-10 15:07:13 UTC) #3
phoglund
lgtm
5 years, 1 month ago (2015-11-10 15:43:20 UTC) #4
kjellander_webrtc
Committed patchset #1 (id:1) manually as a34bb2a78c713e5b9e2224bf7f793d140b0ca608 (presubmit successful).
5 years, 1 month ago (2015-11-10 15:46:23 UTC) #5
commit-bot: I haz the power
5 years, 1 month ago (2015-11-10 15:46:25 UTC) #6
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/a34bb2a78c713e5b9e2224bf7f793d140b0ca608
Cr-Commit-Position: refs/heads/master@{#10584}

Powered by Google App Engine
This is Rietveld 408576698