Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(152)

Issue 1414793020: Remove interface directories kept to avoid breaking downstream. (Closed)

Created:
5 years, 1 month ago by kjellander_webrtc
Modified:
5 years, 1 month ago
Reviewers:
tommi
CC:
webrtc-reviews_webrtc.org, tterriberry_mozilla.com, stefan-webrtc, mflodman
Base URL:
https://chromium.googlesource.com/external/webrtc.git@master
Target Ref:
refs/pending/heads/master
Project:
webrtc
Visibility:
Public.

Description

Remove interface directories kept to avoid breaking downstream. This is a follow-up CL for https://codereview.webrtc.org/1417683006 now that downstream code has been updated to use the 'include' directories for header files instead. BUG=webrtc:5095 TESTED=git cl try -c --bot=android_compile_rel --bot=linux_compile_rel --bot=win_compile_rel --bot=mac_compile_rel -m tryserver.webrtc --bot=ios_rel Committed: https://crrev.com/19299fb28b2578d721649fff65419d4eb9ea1af3 Cr-Commit-Position: refs/heads/master@{#10547}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+0 lines, -3667 lines) Patch
D webrtc/modules/audio_conference_mixer/interface/audio_conference_mixer.h View 1 chunk +0 lines, -79 lines 0 comments Download
D webrtc/modules/audio_conference_mixer/interface/audio_conference_mixer_defines.h View 1 chunk +0 lines, -62 lines 0 comments Download
D webrtc/modules/interface/module.h View 1 chunk +0 lines, -83 lines 0 comments Download
D webrtc/modules/interface/module_common_types.h View 1 chunk +0 lines, -812 lines 0 comments Download
D webrtc/modules/media_file/interface/media_file.h View 1 chunk +0 lines, -182 lines 0 comments Download
D webrtc/modules/media_file/interface/media_file_defines.h View 1 chunk +0 lines, -53 lines 0 comments Download
D webrtc/modules/rtp_rtcp/interface/fec_receiver.h View 1 chunk +0 lines, -48 lines 0 comments Download
D webrtc/modules/rtp_rtcp/interface/receive_statistics.h View 1 chunk +0 lines, -104 lines 0 comments Download
D webrtc/modules/rtp_rtcp/interface/remote_ntp_time_estimator.h View 1 chunk +0 lines, -53 lines 0 comments Download
D webrtc/modules/rtp_rtcp/interface/rtp_cvo.h View 1 chunk +0 lines, -56 lines 0 comments Download
D webrtc/modules/rtp_rtcp/interface/rtp_header_parser.h View 1 chunk +0 lines, -46 lines 0 comments Download
D webrtc/modules/rtp_rtcp/interface/rtp_payload_registry.h View 1 chunk +0 lines, -195 lines 0 comments Download
D webrtc/modules/rtp_rtcp/interface/rtp_receiver.h View 1 chunk +0 lines, -105 lines 0 comments Download
D webrtc/modules/rtp_rtcp/interface/rtp_rtcp.h View 1 chunk +0 lines, -643 lines 0 comments Download
D webrtc/modules/rtp_rtcp/interface/rtp_rtcp_defines.h View 1 chunk +0 lines, -442 lines 0 comments Download
D webrtc/modules/utility/interface/audio_frame_operations.h View 1 chunk +0 lines, -60 lines 0 comments Download
D webrtc/modules/utility/interface/file_player.h View 1 chunk +0 lines, -113 lines 0 comments Download
D webrtc/modules/utility/interface/file_recorder.h View 1 chunk +0 lines, -86 lines 0 comments Download
D webrtc/modules/utility/interface/helpers_android.h View 1 chunk +0 lines, -89 lines 0 comments Download
D webrtc/modules/utility/interface/helpers_ios.h View 1 chunk +0 lines, -61 lines 0 comments Download
D webrtc/modules/utility/interface/jvm_android.h View 1 chunk +0 lines, -187 lines 0 comments Download
D webrtc/modules/utility/interface/mock/mock_process_thread.h View 1 chunk +0 lines, -40 lines 0 comments Download
D webrtc/modules/utility/interface/process_thread.h View 1 chunk +0 lines, -68 lines 0 comments Download

Messages

Total messages: 8 (3 generated)
kjellander_webrtc
I'd like this to go in quickly to avoid anyone making a change in an ...
5 years, 1 month ago (2015-11-06 12:47:40 UTC) #3
tommi
lgtm
5 years, 1 month ago (2015-11-06 22:34:15 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1414793020/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1414793020/1
5 years, 1 month ago (2015-11-06 22:34:34 UTC) #6
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 1 month ago (2015-11-06 23:24:51 UTC) #7
commit-bot: I haz the power
5 years, 1 month ago (2015-11-06 23:24:58 UTC) #8
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/19299fb28b2578d721649fff65419d4eb9ea1af3
Cr-Commit-Position: refs/heads/master@{#10547}

Powered by Google App Engine
This is Rietveld 408576698