modules: more interface -> include renames

modules: more interface -> include renames

This changes the following module directories:
* webrtc/modules/audio_conference_mixer/interface
* webrtc/modules/interface
* webrtc/modules/media_file/interface
* webrtc/modules/rtp_rtcp/interface
* webrtc/modules/utility/interface

To avoid breaking downstream, I followed this recipe:
1. Copy the interface dir to a new sibling directory: include
2. Update the header guards in the include directory to match the style guide.
3. Update the header guards in the interface directory to match the ones in include. This is required to avoid getting redefinitions in the not-yet-updated downstream code.
4. Add a pragma warning in the header files in the interface dir. Example:
#pragma message("WARNING: webrtc/modules/interface is DEPRECATED; "
                "use webrtc/modules/include")
5. Search for all source references to webrtc/modules/interface and update them to webrtc/modules/include (*.c*,*.h,*.mm,*.S)
6. Update all GYP+GN files. This required manual inspection since many subdirectories of webrtc/modules referenced the interface dir using ../interface etc(*.gyp*,*.gn*)

BUG=5095
TESTED=Passing compile-trybots with --clobber flag:
git cl try --clobber --bot=win_compile_rel --bot=linux_compile_rel --bot=android_compile_rel --bot=mac_compile_rel --bot=ios_rel -m tryserver.webrtc

R=stefan@webrtc.org, tommi@webrtc.org

Committed: https://crrev.com/ff761fba8274d93bd73e76c8b8a1f2d0776dd840
Cr-Commit-Position: refs/heads/master@{#10500}

[kjellander_webrtc, 2015-11-02 12:45:24]

Description was changed from

==========
modules: rename interface -> include

To avoid breaking downstream, the following directories were copied
to a new "include" dir. The old headers got pragma warnings added about
deprecation (a very short deprecation since I plan to remove them as
soon downstream is updated):
* webrtc/modules/interface
* webrtc/modules/rtp_rtcp/interface

The following directories were renamed right away (few/no important
clients downstream):
* webrtc/modules/audio_conference_mixer/interface
* webrtc/modules/media_file/interface
* webrtc/modules/utility/interface

BUG=5095
==========

to

==========
modules: more interface -> include renames

To avoid breaking downstream, the following directories were copied
to a new "include" dir. The old headers got pragma warnings added about
deprecation (a very short deprecation since I plan to remove them as
soon downstream is updated):
* webrtc/modules/interface
* webrtc/modules/rtp_rtcp/interface

The following directories were renamed right away (few/no important
clients downstream):
* webrtc/modules/audio_conference_mixer/interface
* webrtc/modules/media_file/interface
* webrtc/modules/utility/interface

BUG=5095
==========

[kjellander_webrtc, 2015-11-02 12:51:13]

Description was changed from

==========
modules: more interface -> include renames

To avoid breaking downstream, the following directories were copied
to a new "include" dir. The old headers got pragma warnings added about
deprecation (a very short deprecation since I plan to remove them as
soon downstream is updated):
* webrtc/modules/interface
* webrtc/modules/rtp_rtcp/interface

The following directories were renamed right away (few/no important
clients downstream):
* webrtc/modules/audio_conference_mixer/interface
* webrtc/modules/media_file/interface
* webrtc/modules/utility/interface

BUG=5095
==========

to

==========
modules: more interface -> include renames

To avoid breaking downstream, the following directories were copied
to a new "include" dir. The old headers got pragma warnings added about
deprecation (a very short deprecation since I plan to remove them as
soon downstream is updated):
* webrtc/modules/interface
* webrtc/modules/rtp_rtcp/interface

The following directories were renamed right away (few/no important
clients downstream):
* webrtc/modules/audio_conference_mixer/interface
* webrtc/modules/media_file/interface
* webrtc/modules/utility/interface

BUG=5095
TESTED=Passing compile-trybots with --clobber flag:
git cl try --clobber --bot=win_compile_rel --bot=linux_compile_rel
--bot=android_compile_rel --bot=mac_compile_rel --bot=ios_rel -m
tryserver.webrtc
==========

[kjellander_webrtc, 2015-11-02 13:10:33]

Description was changed from

==========
modules: more interface -> include renames

To avoid breaking downstream, the following directories were copied
to a new "include" dir. The old headers got pragma warnings added about
deprecation (a very short deprecation since I plan to remove them as
soon downstream is updated):
* webrtc/modules/interface
* webrtc/modules/rtp_rtcp/interface

The following directories were renamed right away (few/no important
clients downstream):
* webrtc/modules/audio_conference_mixer/interface
* webrtc/modules/media_file/interface
* webrtc/modules/utility/interface

BUG=5095
TESTED=Passing compile-trybots with --clobber flag:
git cl try --clobber --bot=win_compile_rel --bot=linux_compile_rel
--bot=android_compile_rel --bot=mac_compile_rel --bot=ios_rel -m
tryserver.webrtc
==========

to

==========
modules: more interface -> include renames

To avoid breaking downstream, the following directories were copied
to a new "include" dir. The old headers got pragma warnings added about
deprecation (a very short deprecation since I plan to remove them as
soon downstream is updated):
* webrtc/modules/interface
* webrtc/modules/rtp_rtcp/interface

The following directories were renamed right away (few/no important
clients downstream):
* webrtc/modules/audio_conference_mixer/interface
* webrtc/modules/media_file/interface
* webrtc/modules/utility/interface

All header guards are updated for the headers in the include dirs.

BUG=5095
TESTED=Passing compile-trybots with --clobber flag:
git cl try --clobber --bot=win_compile_rel --bot=linux_compile_rel
--bot=android_compile_rel --bot=mac_compile_rel --bot=ios_rel -m
tryserver.webrtc
==========

[kjellander_webrtc, 2015-11-02 13:14:56]

kjellander@webrtc.org changed reviewers:
+ stefan@webrtc.org, tommi@webrtc.org

[kjellander_webrtc, 2015-11-02 13:14:57]

stefan: webrtc/modules/rtp_rtcp 
tommi: rubberstamp for the rest.

Remaining rtp_rtp OWNERS: FYI, so nobody is modifying the interface headers
until I'm done with the cleanup (after updating downstream clients).

[tommi, 2015-11-02 13:18:25]

rs lgtm

[stefan-webrtc, 2015-11-04 02:22:40]

Seems fairly straight forward. Some lines are now too long, but otherwise lgtm.

https://codereview.webrtc.org/1417683006/diff/1/webrtc/modules/rtp_rtcp/inter...
File webrtc/modules/rtp_rtcp/interface/receive_statistics.h (right):

https://codereview.webrtc.org/1417683006/diff/1/webrtc/modules/rtp_rtcp/inter...
webrtc/modules/rtp_rtcp/interface/receive_statistics.h:14: #pragma
message("WARNING: rtp_rtcp/interface is DEPRECATED; use rtp_rtcp/include")
You may want to git cl format this CL.

[kjellander_webrtc, 2015-11-04 06:57:58]

Description was changed from

==========
modules: more interface -> include renames

To avoid breaking downstream, the following directories were copied
to a new "include" dir. The old headers got pragma warnings added about
deprecation (a very short deprecation since I plan to remove them as
soon downstream is updated):
* webrtc/modules/interface
* webrtc/modules/rtp_rtcp/interface

The following directories were renamed right away (few/no important
clients downstream):
* webrtc/modules/audio_conference_mixer/interface
* webrtc/modules/media_file/interface
* webrtc/modules/utility/interface

All header guards are updated for the headers in the include dirs.

BUG=5095
TESTED=Passing compile-trybots with --clobber flag:
git cl try --clobber --bot=win_compile_rel --bot=linux_compile_rel
--bot=android_compile_rel --bot=mac_compile_rel --bot=ios_rel -m
tryserver.webrtc
==========

to

==========
modules: more interface -> include renames

This changes the following module directories:
* webrtc/modules/audio_conference_mixer/interface
* webrtc/modules/interface
* webrtc/modules/media_file/interface
* webrtc/modules/rtp_rtcp/interface
* webrtc/modules/utility/interface

To avoid breaking downstream, I followed this recipe:
1. Copy the interface dir to a new sibling directory: include
2. Update the header guards in the include directory to match the style guide.
3. Update the header guards in the interface directory to match the ones in
include. This is required to avoid getting redefinitions in the not-yet-updated
downstream code.
4. Add a pragma warning in the header files in the interface dir. Example:
#pragma message("WARNING: webrtc/modules/interface is DEPRECATED; "
                "use webrtc/modules/include")
                
4. Search for all source references to webrtc/modules/interface and update them
to webrtc/modules/include (*.c*,*.h,*.mm,*.S)
5. Update all GYP+GN files. This required manual inspection since many
subdirectories of webrtc/modules referenced the interface dir using ../interface
etc(*.gyp*,*.gn*)


BUG=5095
TESTED=Passing compile-trybots with --clobber flag:
git cl try --clobber --bot=win_compile_rel --bot=linux_compile_rel
--bot=android_compile_rel --bot=mac_compile_rel --bot=ios_rel -m
tryserver.webrtc
==========

[kjellander_webrtc, 2015-11-04 06:58:23]

Description was changed from

==========
modules: more interface -> include renames

This changes the following module directories:
* webrtc/modules/audio_conference_mixer/interface
* webrtc/modules/interface
* webrtc/modules/media_file/interface
* webrtc/modules/rtp_rtcp/interface
* webrtc/modules/utility/interface

To avoid breaking downstream, I followed this recipe:
1. Copy the interface dir to a new sibling directory: include
2. Update the header guards in the include directory to match the style guide.
3. Update the header guards in the interface directory to match the ones in
include. This is required to avoid getting redefinitions in the not-yet-updated
downstream code.
4. Add a pragma warning in the header files in the interface dir. Example:
#pragma message("WARNING: webrtc/modules/interface is DEPRECATED; "
                "use webrtc/modules/include")
                
4. Search for all source references to webrtc/modules/interface and update them
to webrtc/modules/include (*.c*,*.h,*.mm,*.S)
5. Update all GYP+GN files. This required manual inspection since many
subdirectories of webrtc/modules referenced the interface dir using ../interface
etc(*.gyp*,*.gn*)


BUG=5095
TESTED=Passing compile-trybots with --clobber flag:
git cl try --clobber --bot=win_compile_rel --bot=linux_compile_rel
--bot=android_compile_rel --bot=mac_compile_rel --bot=ios_rel -m
tryserver.webrtc
==========

to

==========
modules: more interface -> include renames

This changes the following module directories:
* webrtc/modules/audio_conference_mixer/interface
* webrtc/modules/interface
* webrtc/modules/media_file/interface
* webrtc/modules/rtp_rtcp/interface
* webrtc/modules/utility/interface

To avoid breaking downstream, I followed this recipe:
1. Copy the interface dir to a new sibling directory: include
2. Update the header guards in the include directory to match the style guide.
3. Update the header guards in the interface directory to match the ones in
include. This is required to avoid getting redefinitions in the not-yet-updated
downstream code.
4. Add a pragma warning in the header files in the interface dir. Example:
#pragma message("WARNING: webrtc/modules/interface is DEPRECATED; "
                "use webrtc/modules/include")
5. Search for all source references to webrtc/modules/interface and update them
to webrtc/modules/include (*.c*,*.h,*.mm,*.S)
6. Update all GYP+GN files. This required manual inspection since many
subdirectories of webrtc/modules referenced the interface dir using ../interface
etc(*.gyp*,*.gn*)


BUG=5095
TESTED=Passing compile-trybots with --clobber flag:
git cl try --clobber --bot=win_compile_rel --bot=linux_compile_rel
--bot=android_compile_rel --bot=mac_compile_rel --bot=ios_rel -m
tryserver.webrtc
==========

[kjellander_webrtc, 2015-11-04 07:28:20]

Submitting this now. I have ran all downstream builds I can find with this patch
applied and they're still passing.

https://codereview.webrtc.org/1417683006/diff/1/webrtc/modules/rtp_rtcp/inter...
File webrtc/modules/rtp_rtcp/interface/receive_statistics.h (right):

https://codereview.webrtc.org/1417683006/diff/1/webrtc/modules/rtp_rtcp/inter...
webrtc/modules/rtp_rtcp/interface/receive_statistics.h:14: #pragma
message("WARNING: rtp_rtcp/interface is DEPRECATED; use rtp_rtcp/include")
On 2015/11/04 02:22:40, stefan-webrtc (holmer) wrote:
> You may want to git cl format this CL.

I was unable to wrap it in a good way that made pragma happy. I don't think it's
a big deal since these files are going away as soon downstream is updated.

[kjellander_webrtc, 2015-11-04 07:32:12]

Committed patchset #5 (id:80001) manually as
ff761fba8274d93bd73e76c8b8a1f2d0776dd840 (presubmit successful).

[commit-bot: I haz the power, 2015-11-04 07:32:22]

Patchset 5 (id:??) landed as
https://crrev.com/ff761fba8274d93bd73e76c8b8a1f2d0776dd840
Cr-Commit-Position: refs/heads/master@{#10500}