webrtc/modules/video_coding/codecs/vp8/vp8_sequence_coder.cc - Issue 1414693006: Add DecodedImageCallback::Decoded() function with custom decode time value.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: webrtc/modules/video_coding/codecs/vp8/vp8_sequence_coder.cc

Issue 1414693006: Add DecodedImageCallback::Decoded() function with custom decode time value. (Closed) Base URL: https://chromium.googlesource.com/external/webrtc.git@master

Patch Set: addressed comments. Created 5 years, 1 month ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « webrtc/modules/video_coding/codecs/vp8/test/vp8_impl_unittest.cc ('k') | webrtc/modules/video_coding/main/source/codec_timer.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: webrtc/modules/video_coding/codecs/vp8/vp8_sequence_coder.cc

diff --git a/webrtc/modules/video_coding/codecs/vp8/vp8_sequence_coder.cc b/webrtc/modules/video_coding/codecs/vp8/vp8_sequence_coder.cc

index 5843d83fa78dc733d0a2afe76341145e4f6f55b7..ea7db5a7f67c539f7b3bc1d254eca4befd0c5bba 100644

--- a/webrtc/modules/video_coding/codecs/vp8/vp8_sequence_coder.cc

+++ b/webrtc/modules/video_coding/codecs/vp8/vp8_sequence_coder.cc

@@ -9,6 +9,7 @@

#include "testing/gtest/include/gtest/gtest.h"

+#include "webrtc/base/checks.h"

#include "webrtc/base/scoped_ptr.h"

#include "webrtc/common_video/interface/video_image.h"

#include "webrtc/common_video/libyuv/include/webrtc_libyuv.h"

@@ -68,7 +69,11 @@ class Vp8SequenceCoderDecodeCallback : public webrtc::DecodedImageCallback {

public:

explicit Vp8SequenceCoderDecodeCallback(FILE* decoded_file)

: decoded_file_(decoded_file) {}

- int Decoded(webrtc::VideoFrame& frame);

+ int32_t Decoded(webrtc::VideoFrame& frame) override;

+ int32_t Decoded(webrtc::VideoFrame& frame, int64_t decode_time_ms) override {

+ RTC_NOTREACHED();

+ return -1;;

+ }

bool DecodeComplete();

private: