Add DecodedImageCallback::Decoded() function with custom decode time value.

webrtc/video_decoder.h

 /*
  *  Copyright (c) 2014 The WebRTC project authors. All Rights Reserved.
  *
  *  Use of this source code is governed by a BSD-style license
  *  that can be found in the LICENSE file in the root of the source
  *  tree. An additional intellectual property rights grant can be found
  *  in the file PATENTS.  All contributing project authors may
  *  be found in the AUTHORS file in the root of the source tree.
  */
 
@@ skipping 11 matching lines @@
 class RTPFragmentationHeader;
 // TODO(pbos): Expose these through a public (root) header or change these APIs.
 struct CodecSpecificInfo;
 struct VideoCodec;
 
 class DecodedImageCallback {
  public:
   virtual ~DecodedImageCallback() {}
 
   virtual int32_t Decoded(VideoFrame& decodedImage) = 0;
+  // Provides an alternative interface that allows the decoder to specify the
+  // decode time excluding waiting time for any previous pending frame to
+  // return. This is necessary for breaking positive feedback in the delay
+  // estimation when the decoder has a single output buffer.
+  virtual int32_t Decoded(VideoFrame& decodedImage, int64_t decode_time_ms) {
+    // The default implementation ignores custom decode time value.
+    return Decoded(decodedImage);
+  }

[stefan-webrtc, 2015/11/10 10:32:00]

Are there many places where you have to make this change if you don't provide a
default implementation? I would have preferred that if it's reasonable to avoid.

Maybe we can follow-up with removing this default impl at least? In that case
add a TODO.

+
   virtual int32_t ReceivedDecodedReferenceFrame(const uint64_t pictureId) {
     return -1;
   }
 
   virtual int32_t ReceivedDecodedFrame(const uint64_t pictureId) { return -1; }
 };
 
 class VideoDecoder {
  public:
   enum DecoderType {
@@ skipping 54 matching lines @@
 
   VideoCodec codec_settings_;
   int32_t number_of_cores_;
   rtc::scoped_ptr<VideoDecoder> fallback_decoder_;
   DecodedImageCallback* callback_;
 };
 
 }  // namespace webrtc
 
 #endif  // WEBRTC_VIDEO_DECODER_H_