Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(955)

Issue 1413983004: Reland of Adding the ability to create an RtpSender without a track. (Closed)

Created:
5 years, 1 month ago by Taylor Brandstetter
Modified:
5 years, 1 month ago
Reviewers:
pthatcher2, pthatcher1
CC:
webrtc-reviews_webrtc.org, interface-changes_webrtc.org, rwolff_gocast.it, yujie_mao (webrtc), Andrew MacDonald, tterriberry_mozilla.com, qiang.lu, niklas.enbom, peah-webrtc
Base URL:
https://chromium.googlesource.com/external/webrtc.git@master
Target Ref:
refs/pending/heads/master
Project:
webrtc
Visibility:
Public.

Description

Reland of Adding the ability to create an RtpSender without a track. (patchset #1 id:1 of https://codereview.webrtc.org/1426443007/ ) Reason for revert: Relanding, after changing the expectations of WebRtcBrowserTest.CallAndModifyStream. Original issue's description: > Revert of Adding the ability to create an RtpSender without a track. (patchset #8 id:140001 of https://codereview.webrtc.org/1413713003/ ) > > Reason for revert: > Causing a compiler warning, and causing WebRtcBrowserTest.CallAndModifyStream to fail. > > Original issue's description: > > Adding the ability to create an RtpSender without a track. > > > > This CL also changes AddStream to immediately create a sender, rather > > than waiting until the track is seen in SDP. And the PeerConnection now > > builds the list of "send streams" from the list of senders, rather than > > the collection of local media streams. > > > > Committed: https://crrev.com/ac9d92ccbe2b29590c53f702e11dc625820480d5 > > Cr-Commit-Position: refs/heads/master@{#10414} > > TBR=pthatcher@webrtc.org,pthatcher@chromium.org > NOPRESUBMIT=true > NOTREECHECKS=true > NOTRY=true > > Committed: https://crrev.com/8f46c63f6f764254892f4111b54aa1cc8f32eeeb > Cr-Commit-Position: refs/heads/master@{#10417} TBR=pthatcher@webrtc.org,pthatcher@chromium.org NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true Committed: https://crrev.com/6834fa10f142bf5e2275142acb834898911d09ae Cr-Commit-Position: refs/heads/master@{#10730}

Patch Set 1 #

Patch Set 2 : Renaming constant so it doesn't conflict with Chromium code. #

Patch Set 3 : Fixing merge issue. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+702 lines, -248 lines) Patch
M talk/app/webrtc/audiotrack.cc View 1 2 chunks +2 lines, -2 lines 0 comments Download
M talk/app/webrtc/mediastreaminterface.h View 1 1 chunk +3 lines, -0 lines 0 comments Download
M talk/app/webrtc/mediastreamprovider.h View 1 2 chunks +4 lines, -5 lines 0 comments Download
M talk/app/webrtc/peerconnection.h View 1 3 chunks +5 lines, -6 lines 0 comments Download
M talk/app/webrtc/peerconnection.cc View 1 12 chunks +111 lines, -131 lines 0 comments Download
M talk/app/webrtc/peerconnection_unittest.cc View 1 2 6 chunks +59 lines, -29 lines 0 comments Download
M talk/app/webrtc/peerconnectioninterface.h View 1 1 chunk +6 lines, -0 lines 0 comments Download
M talk/app/webrtc/peerconnectioninterface_unittest.cc View 1 1 chunk +2 lines, -0 lines 0 comments Download
M talk/app/webrtc/peerconnectionproxy.h View 1 1 chunk +3 lines, -0 lines 0 comments Download
M talk/app/webrtc/rtpsender.h View 1 5 chunks +58 lines, -11 lines 0 comments Download
M talk/app/webrtc/rtpsender.cc View 1 5 chunks +159 lines, -47 lines 0 comments Download
M talk/app/webrtc/rtpsenderinterface.h View 1 3 chunks +20 lines, -0 lines 0 comments Download
M talk/app/webrtc/rtpsenderreceiver_unittest.cc View 1 4 chunks +210 lines, -3 lines 0 comments Download
M talk/app/webrtc/videotrack.cc View 1 2 chunks +2 lines, -2 lines 0 comments Download
M talk/app/webrtc/webrtcsession.cc View 1 2 3 chunks +0 lines, -3 lines 0 comments Download
M webrtc/base/helpers.h View 1 1 chunk +3 lines, -0 lines 0 comments Download
M webrtc/base/helpers.cc View 1 3 chunks +48 lines, -9 lines 0 comments Download
M webrtc/base/helpers_unittest.cc View 1 1 chunk +7 lines, -0 lines 0 comments Download

Messages

Total messages: 8 (2 generated)
Taylor Brandstetter
Created Reland of Adding the ability to create an RtpSender without a track.
5 years, 1 month ago (2015-11-09 22:36:24 UTC) #1
pthatcher1
lgtm
5 years, 1 month ago (2015-11-10 20:23:43 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1413983004/300001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1413983004/300001
5 years, 1 month ago (2015-11-20 17:49:50 UTC) #5
commit-bot: I haz the power
Committed patchset #3 (id:300001)
5 years, 1 month ago (2015-11-20 17:50:02 UTC) #6
commit-bot: I haz the power
Patchset 3 (id:??) landed as https://crrev.com/6834fa10f142bf5e2275142acb834898911d09ae Cr-Commit-Position: refs/heads/master@{#10730}
5 years, 1 month ago (2015-11-20 17:50:07 UTC) #7
Taylor Brandstetter
5 years, 1 month ago (2015-11-20 19:42:58 UTC) #8
Message was sent while issue was closed.
A revert of this CL (patchset #3 id:300001) has been created in
https://codereview.webrtc.org/1460323002/ by deadbeef@webrtc.org.

The reason for reverting is: Still breaking CallAndModifyStream. Chromium CL
intended to fix it (https://codereview.chromium.org/1435713002/) wasn't
sufficient, because I forgot to call addStream/removeStream on the second
connection..

Powered by Google App Engine
This is Rietveld 408576698