Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(116)

Issue 1413843003: Revert of Add experiment on weak ping delay during call set up time (Closed)

Created:
5 years, 2 months ago by guoweis_webrtc
Modified:
5 years, 2 months ago
Reviewers:
tommi, juberti1, pthatcher1
CC:
webrtc-reviews_webrtc.org, tterriberry_mozilla.com, hbos
Base URL:
https://chromium.googlesource.com/external/webrtc@master
Target Ref:
refs/pending/heads/master
Project:
webrtc
Visibility:
Public.

Description

Revert of Add experiment on weak ping delay during call set up time (patchset #1 id:1 of https://codereview.webrtc.org/1406153005/ ) Reason for revert: Still cause break on mac. reverting it again. Original issue's description: > Reland of Add experiment on weak ping delay during call set up time (patchset #1 id:1 of https://codereview.webrtc.org/1423443002/ ) > > Reason for revert: > This should be safe to land now. > > Original issue's description: > > Revert of Add experiment on weak ping delay during call set up time (patchset #4 id:60001 of https://codereview.webrtc.org/1411883002/ ) > > > > Reason for revert: > > guoweis - Here's the target that's failing: > > https://code.google.com/p/chromium/codesearch#chromium/src/third_party/libjingle/libjingle_nacl.gyp&l=17 > > > > This has unfortunately been causing problems repeatedly for us since libjingle_nacl is maintained separately from libjingle (I don't know the history). > > > > The way this works for Chrome in general is that the FindFullName method is implemented in init_webrtc.cc in the overrides folder in Chrome and that hooks WebRTC up with Chrome's implementation. I'm not sure if that's the right thing to do for nacl, how webrtc is initialized there etc. I'll ping the nacl team for some help too offline and include you. Reverting this change for now. > > > > Original issue's description: > > > Add experiment on weak ping delay during call set up time > > > > > > BUG= > > > R=pthatcher@webrtc.org > > > > > > Committed: https://crrev.com/3bf69b15f4c0c0ca4ab17c237084684a37bb8279 > > > Cr-Commit-Position: refs/heads/master@{#10343} > > > > TBR=pthatcher@webrtc.org,juberti@webrtc.org,guoweis@webrtc.org > > NOPRESUBMIT=true > > NOTREECHECKS=true > > NOTRY=true > > BUG= > > > > Committed: https://crrev.com/a01d44022355796d4fd86d00aae6d3263573b6f1 > > Cr-Commit-Position: refs/heads/master@{#10350} > > TBR=pthatcher@webrtc.org,juberti@webrtc.org,tommi@webrtc.org > NOPRESUBMIT=true > NOTREECHECKS=true > NOTRY=true > BUG= > > Committed: https://crrev.com/e26ce1b7a4644942b239ed788a737200762db3b3 > Cr-Commit-Position: refs/heads/master@{#10379} TBR=pthatcher@webrtc.org,juberti@webrtc.org,tommi@webrtc.org NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG= Committed: https://crrev.com/4f6a8b5f559c5f782af396efeb42cf94de0623be Cr-Commit-Position: refs/heads/master@{#10380}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+22 lines, -34 lines) Patch
M webrtc/p2p/base/p2ptransportchannel.h View 2 chunks +0 lines, -3 lines 0 comments Download
M webrtc/p2p/base/p2ptransportchannel.cc View 4 chunks +22 lines, -31 lines 0 comments Download

Messages

Total messages: 4 (0 generated)
guoweis_webrtc
Created Revert of Add experiment on weak ping delay during call set up time
5 years, 2 months ago (2015-10-23 01:00:29 UTC) #1
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1413843003/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1413843003/1
5 years, 2 months ago (2015-10-23 01:00:32 UTC) #2
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 2 months ago (2015-10-23 01:00:43 UTC) #3
commit-bot: I haz the power
5 years, 2 months ago (2015-10-23 01:00:51 UTC) #4
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/4f6a8b5f559c5f782af396efeb42cf94de0623be
Cr-Commit-Position: refs/heads/master@{#10380}

Powered by Google App Engine
This is Rietveld 408576698