Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(31)

Issue 1413603005: Reland of Add experiment on weak ping delay during call set up time (Closed)

Created:
5 years, 1 month ago by guoweis_webrtc
Modified:
5 years, 1 month ago
Reviewers:
juberti1, hbos, pthatcher1
CC:
webrtc-reviews_webrtc.org, tterriberry_mozilla.com
Base URL:
https://chromium.googlesource.com/external/webrtc@master
Target Ref:
refs/pending/heads/master
Project:
webrtc
Visibility:
Public.

Description

Reland of Add experiment on weak ping delay during call set up time (patchset #1 id:1 of https://codereview.webrtc.org/1416773003/ ) Reason for revert: https://codereview.chromium.org/1419253002 is landed to address this linker issue. Keep my fingers crossed. Original issue's description: > Revert of Add experiment on weak ping delay during call set up time (patchset #4 id:60001 of https://codereview.webrtc.org/1411883002/ ) > > Reason for revert: > This CL breaks Chromium, undefined reference link error to webrtc::field_trial::FindFullName. Adding the dependency system_wrappers to the rtc_p2p target is not enough to fix this. > > Looking at field_trial.h (in system_wrappers/interface/, not to be confused with the one in test/) the documentation says "WebRTC clients MUST provide an implementation of: ...FindFullName... Or link with a default one provided in: ...system_wrappers.gyp:field_trial_default). > > So maybe just depend on field_trial_default? Not sure what should be done in case there are implications to adding this dependency, I'm reverting this. Sorry :) > > Original issue's description: > > Add experiment on weak ping delay during call set up time > > > > BUG= > > R=pthatcher@webrtc.org > > > > Committed: https://crrev.com/3bf69b15f4c0c0ca4ab17c237084684a37bb8279 > > Cr-Commit-Position: refs/heads/master@{#10343} > > TBR=pthatcher@webrtc.org,juberti@webrtc.org,guoweis@webrtc.org > NOPRESUBMIT=true > NOTREECHECKS=true > NOTRY=true > BUG= > TBR=pthatcher@webrtc.org,juberti@webrtc.org,hbos@webrtc.org NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG= Committed: https://crrev.com/b0bb77fd615c5ce413b16f6157b2ffc25898631f Cr-Commit-Position: refs/heads/master@{#10418}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+34 lines, -22 lines) Patch
M webrtc/p2p/base/p2ptransportchannel.h View 2 chunks +3 lines, -0 lines 0 comments Download
M webrtc/p2p/base/p2ptransportchannel.cc View 4 chunks +31 lines, -22 lines 0 comments Download

Messages

Total messages: 4 (0 generated)
guoweis_webrtc
Created Reland of Add experiment on weak ping delay during call set up time
5 years, 1 month ago (2015-10-26 22:09:45 UTC) #1
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1413603005/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1413603005/1
5 years, 1 month ago (2015-10-26 22:09:56 UTC) #2
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 1 month ago (2015-10-26 22:10:05 UTC) #3
commit-bot: I haz the power
5 years, 1 month ago (2015-10-26 22:10:17 UTC) #4
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/b0bb77fd615c5ce413b16f6157b2ffc25898631f
Cr-Commit-Position: refs/heads/master@{#10418}

Powered by Google App Engine
This is Rietveld 408576698