Chromium Code Reviews| Index: webrtc/modules/audio_processing/include/audio_processing.h |
| diff --git a/webrtc/modules/audio_processing/include/audio_processing.h b/webrtc/modules/audio_processing/include/audio_processing.h |
| index 318b2f89533652b6fd1ad896d269f78deb0d004d..605460376c9d66c95c5428b0a64dd177fbd795d7 100644 |
| --- a/webrtc/modules/audio_processing/include/audio_processing.h |
| +++ b/webrtc/modules/audio_processing/include/audio_processing.h |
| @@ -389,13 +389,19 @@ class AudioProcessing { |
| // Starts recording debugging information to a file specified by |filename|, |
| // a NULL-terminated string. If there is an ongoing recording, the old file |
| // will be closed, and recording will continue in the newly specified file. |
| - // An already existing file will be overwritten without warning. |
| + // An already existing file will be overwritten without warning. A maximum |
| + // file size (in bytes) for the log can be specified. The logging is stopped |
| + // once the limit has been reached. If max_log_size_bytes is set to a value |
| + // <= 0, no limit will be used. |
| static const size_t kMaxFilenameSize = 1024; |
| - virtual int StartDebugRecording(const char filename[kMaxFilenameSize]) = 0; |
| + virtual int StartDebugRecording(const char filename[kMaxFilenameSize], |
| + int64_t max_log_size_bytes) = 0; |
| // Same as above but uses an existing file handle. Takes ownership |
| - // of |handle| and closes it at StopDebugRecording(). |
| - virtual int StartDebugRecording(FILE* handle) = 0; |
| + // of |handle| and closes it at StopDebugRecording(). A maximum file size |
| + // (in bytes) for the log can be specified. The logging is stopped once the |
| + // limit has been reached. |
|
Andrew MacDonald
2015/11/24 17:28:59
nit: Just refer to the comments above rather than
ivoc
2015/12/01 15:17:16
Done.
|
| + virtual int StartDebugRecording(FILE* handle, int64_t max_log_size_bytes) = 0; |
| // Same as above but uses an existing PlatformFile handle. Takes ownership |
| // of |handle| and closes it at StopDebugRecording(). |