Added option to specify a maximum file size when recording an AEC dump.

webrtc/modules/audio_processing/include/audio_processing.h

 /*
  *  Copyright (c) 2012 The WebRTC project authors. All Rights Reserved.
  *
  *  Use of this source code is governed by a BSD-style license
  *  that can be found in the LICENSE file in the root of the source
  *  tree. An additional intellectual property rights grant can be found
  *  in the file PATENTS.  All contributing project authors may
  *  be found in the AUTHORS file in the root of the source tree.
  */
 
@@ skipping 371 matching lines @@
   // set_stream_delay_ms(). May be positive or negative.
   //
   // Note that this could cause an otherwise valid value passed to
   // set_stream_delay_ms() to return an error.
   virtual void set_delay_offset_ms(int offset) = 0;
   virtual int delay_offset_ms() const = 0;
 
   // Starts recording debugging information to a file specified by |filename|,
   // a NULL-terminated string. If there is an ongoing recording, the old file
   // will be closed, and recording will continue in the newly specified file.
-  // An already existing file will be overwritten without warning.
+  // An already existing file will be overwritten without warning. A maximum
+  // file size (in bytes) for the log can be specified. The logging is stopped
+  // once the limit has been reached. If max_log_size_bytes is set to a value
+  // <= 0, no limit will be used.
   static const size_t kMaxFilenameSize = 1024;
-  virtual int StartDebugRecording(const char filename[kMaxFilenameSize]) = 0;
+  virtual int StartDebugRecording(const char filename[kMaxFilenameSize],
+                                  int64_t max_log_size_bytes) = 0;
 
   // Same as above but uses an existing file handle. Takes ownership
-  // of |handle| and closes it at StopDebugRecording().
-  virtual int StartDebugRecording(FILE* handle) = 0;
+  // of |handle| and closes it at StopDebugRecording(). A maximum file size
+  // (in bytes) for the log can be specified. The logging is stopped once the
+  // limit has been reached.

[Andrew MacDonald, 2015/11/24 17:28:59]

nit: Just refer to the comments above rather than repeating.

[ivoc, 2015/12/01 15:17:16]

Done.

+  virtual int StartDebugRecording(FILE* handle, int64_t max_log_size_bytes) = 0;
 
   // Same as above but uses an existing PlatformFile handle. Takes ownership
   // of |handle| and closes it at StopDebugRecording().
   // TODO(xians): Make this interface pure virtual.
   virtual int StartDebugRecordingForPlatformFile(rtc::PlatformFile handle) {

[Andrew MacDonald, 2015/11/24 17:28:59]

Any reason this one doesn't take a max size parameter?

[ivoc, 2015/12/01 15:17:16]

I think this is the function that Chrome calls to start recording AEC dumps. I
didn't want to touch it to prevent Chrome breakage.

[Andrew MacDonald, 2015/12/02 00:11:12]

OK. Perhaps mention that no logging limit will be used for this interface.

       return -1;
   }
 
   // Stops recording debugging information, and closes the file. Recording
   // cannot be resumed in the same file (without overwriting it).
   virtual int StopDebugRecording() = 0;
 
   // Use to send UMA histograms at end of a call. Note that all histogram
   // specific member variables are reset.
   virtual void UpdateHistogramsOnCallEnd() = 0;
@@ skipping 515 matching lines @@
   // This does not impact the size of frames passed to |ProcessStream()|.
   virtual int set_frame_size_ms(int size) = 0;
   virtual int frame_size_ms() const = 0;
 
  protected:
   virtual ~VoiceDetection() {}
 };
 }  // namespace webrtc
 
 #endif  // WEBRTC_MODULES_AUDIO_PROCESSING_INCLUDE_AUDIO_PROCESSING_H_