Added option to specify a maximum file size when recording an AEC dump.

webrtc/modules/audio_processing/include/audio_processing.h

Index: webrtc/modules/audio_processing/include/audio_processing.h
diff --git a/webrtc/modules/audio_processing/include/audio_processing.h b/webrtc/modules/audio_processing/include/audio_processing.h
index 318b2f89533652b6fd1ad896d269f78deb0d004d..57ba4a5795216f6b4c3073bc0a0e57a741ef150b 100644
--- a/webrtc/modules/audio_processing/include/audio_processing.h
+++ b/webrtc/modules/audio_processing/include/audio_processing.h
@@ -391,11 +391,24 @@ class AudioProcessing {
   // will be closed, and recording will continue in the newly specified file.
   // An already existing file will be overwritten without warning.
   static const size_t kMaxFilenameSize = 1024;
-  virtual int StartDebugRecording(const char filename[kMaxFilenameSize]) = 0;
+  int StartDebugRecording(const char filename[kMaxFilenameSize]) {
+    return StartDebugRecording(filename, -1);
+  }
+
+  // Same as above, but a maximum file size (in bytes) for the log can be
+  // specified. The logging is stopped once the limit has been reached.
+  virtual int StartDebugRecording(const char filename[kMaxFilenameSize],
+                                  int64_t max_log_size_bytes) = 0;
 
   // Same as above but uses an existing file handle. Takes ownership
   // of |handle| and closes it at StopDebugRecording().
-  virtual int StartDebugRecording(FILE* handle) = 0;
+  int StartDebugRecording(FILE* handle) {

[the sun, 2015/11/11 15:54:42]

Are both of these functions in use, or can we drop one of them?

[ivoc, 2015/11/11 16:44:31]

It is used internally in a few places, mainly in the unit tests. I went through
each call and replaced them with the other version, and then I removed this
function and the char[] based one as well.

+    return StartDebugRecording(handle, -1);
+  }
+
+  // Same as above, but a maximum file size (in bytes) for the log can be
+  // specified. The logging is stopped once the limit has been reached.
+  virtual int StartDebugRecording(FILE* handle, int64_t max_log_size_bytes) = 0;
 
   // Same as above but uses an existing PlatformFile handle. Takes ownership
   // of |handle| and closes it at StopDebugRecording().