Added option to specify a maximum file size when recording an AEC dump.

webrtc/modules/audio_processing/include/audio_processing.h

 /*
  *  Copyright (c) 2012 The WebRTC project authors. All Rights Reserved.
  *
  *  Use of this source code is governed by a BSD-style license
  *  that can be found in the LICENSE file in the root of the source
  *  tree. An additional intellectual property rights grant can be found
  *  in the file PATENTS.  All contributing project authors may
  *  be found in the AUTHORS file in the root of the source tree.
  */
 
@@ skipping 373 matching lines @@
   // Note that this could cause an otherwise valid value passed to
   // set_stream_delay_ms() to return an error.
   virtual void set_delay_offset_ms(int offset) = 0;
   virtual int delay_offset_ms() const = 0;
 
   // Starts recording debugging information to a file specified by |filename|,
   // a NULL-terminated string. If there is an ongoing recording, the old file
   // will be closed, and recording will continue in the newly specified file.
   // An already existing file will be overwritten without warning.
   static const size_t kMaxFilenameSize = 1024;
-  virtual int StartDebugRecording(const char filename[kMaxFilenameSize]) = 0;
+  int StartDebugRecording(const char filename[kMaxFilenameSize]) {
+    return StartDebugRecording(filename, -1);
+  }
+
+  // Same as above, but a maximum file size (in bytes) for the log can be
+  // specified. The logging is stopped once the limit has been reached.
+  virtual int StartDebugRecording(const char filename[kMaxFilenameSize],
+                                  int64_t max_log_size_bytes) = 0;
 
   // Same as above but uses an existing file handle. Takes ownership
   // of |handle| and closes it at StopDebugRecording().
-  virtual int StartDebugRecording(FILE* handle) = 0;
+  int StartDebugRecording(FILE* handle) {

[the sun, 2015/11/11 15:54:42]

Are both of these functions in use, or can we drop one of them?

[ivoc, 2015/11/11 16:44:31]

It is used internally in a few places, mainly in the unit tests. I went through
each call and replaced them with the other version, and then I removed this
function and the char[] based one as well.

+    return StartDebugRecording(handle, -1);
+  }
+
+  // Same as above, but a maximum file size (in bytes) for the log can be
+  // specified. The logging is stopped once the limit has been reached.
+  virtual int StartDebugRecording(FILE* handle, int64_t max_log_size_bytes) = 0;
 
   // Same as above but uses an existing PlatformFile handle. Takes ownership
   // of |handle| and closes it at StopDebugRecording().
   // TODO(xians): Make this interface pure virtual.
   virtual int StartDebugRecordingForPlatformFile(rtc::PlatformFile handle) {
       return -1;
   }
 
   // Stops recording debugging information, and closes the file. Recording
   // cannot be resumed in the same file (without overwriting it).
@@ skipping 520 matching lines @@
   // This does not impact the size of frames passed to |ProcessStream()|.
   virtual int set_frame_size_ms(int size) = 0;
   virtual int frame_size_ms() const = 0;
 
  protected:
   virtual ~VoiceDetection() {}
 };
 }  // namespace webrtc
 
 #endif  // WEBRTC_MODULES_AUDIO_PROCESSING_INCLUDE_AUDIO_PROCESSING_H_