Added option to specify a maximum file size when recording an AEC dump.

talk/media/base/mediaengine.h

Index: talk/media/base/mediaengine.h
diff --git a/talk/media/base/mediaengine.h b/talk/media/base/mediaengine.h
index c5b90962f9730e90965d91a0b585b77b7e256bfd..58c984c03cef2db0b18bb2fa51e6aa9a33ab05d9 100644
--- a/talk/media/base/mediaengine.h
+++ b/talk/media/base/mediaengine.h
@@ -119,8 +119,11 @@ class MediaEngineInterface {
   virtual void SetVoiceLogging(int min_sev, const char* filter) = 0;
   virtual void SetVideoLogging(int min_sev, const char* filter) = 0;
 
-  // Starts AEC dump using existing file.
-  virtual bool StartAecDump(rtc::PlatformFile file) = 0;
+  // Starts AEC dump using existing file, a maximum file size in bytes can be
+  // specified. If the log file grows to be larger than the limit, logging is
+  // stopped and the file is closed. If max_size_bytes is set to a value <= 0,

[kwiberg-webrtc, 2015/11/08 19:09:07]

Is it really the case that logging stops *after* the file has exceeded the
limit?

[ivoc, 2015/11/11 16:44:31]

It is not, fixed the comment.

+  // no limit will be used.
+  virtual bool StartAecDump(rtc::PlatformFile file, int64_t max_size_bytes) = 0;
 
   // Starts RtcEventLog using existing file.
   virtual bool StartRtcEventLog(rtc::PlatformFile file) = 0;
@@ -221,8 +224,8 @@ class CompositeMediaEngine : public MediaEngineInterface {
     video_.SetLogging(min_sev, filter);
   }
 
-  virtual bool StartAecDump(rtc::PlatformFile file) {
-    return voice_.StartAecDump(file);
+  virtual bool StartAecDump(rtc::PlatformFile file, int64_t max_size_bytes) {
+    return voice_.StartAecDump(file, max_size_bytes);
   }
 
   virtual bool StartRtcEventLog(rtc::PlatformFile file) {
@@ -262,7 +265,9 @@ class NullVoiceEngine {
     return rtp_header_extensions_;
   }
   void SetLogging(int min_sev, const char* filter) {}
-  bool StartAecDump(rtc::PlatformFile file) { return false; }
+  bool StartAecDump(rtc::PlatformFile file, int64_t max_size_bytes) {
+    return false;
+  }
   bool StartRtcEventLog(rtc::PlatformFile file) { return false; }
   void StopRtcEventLog() {}